AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090522115613.05d66d5a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>,<dl-engineering@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	102AB4F33EBBDB4C91915B145C8E9FB312973558DF@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 22 May 2009 11:56:35 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Cc: dl-Engineering <dl-engineering@onstor.com>
Subject: Re: Code reviews required before checking in files
Message-ID: <20090522115635.23784796@ripper.onstor.net>
In-Reply-To: <102AB4F33EBBDB4C91915B145C8E9FB312973558DF@exch1.onstor.net>
References: <102AB4F33EBBDB4C91915B145C8E9FB312973558DF@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 22 May 2009 11:51:54 -0700 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Hi folks,
>    I tightened up the perforce triggers so you will need the
> "Reviewed by" field in areas where p4 submit was letting it slide
> before. Most noticeable will be the nfx-tree/test directory. Also
> shell scripts, perl files and modules (*.sh, *.pl, *.pm) will now
> require a review.
> 
> This is being done to help enforce the existing code review policies
> here at ONStor.
> 
> If in the future you find a change that was checked in without a
> reviewer that should have been, don't hesitate to bring it to my
> attention and I will add the trigger.
> 
> Thanks,
> 
> Your friendly neighborhood SCM dude.

Seconded by your friendly neighborhood SCM nazi biatch... ~:^)
Feel free to forward to Larry any other patterns that should be
triggered on that currently aren't.

Cheers,

a

