AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090611115020.5bfefc1f@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<chris.vandever@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AD19EE471@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 11 Jun 2009 11:51:09 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Chris Vandever <chris.vandever@onstor.com>
Subject: Re: please review 29293
Message-ID: <20090611115109.2a01eba6@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AD19EE471@exch1.onstor.net>
References: <20090527164201.4f7dbe1f@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB52AD19EE471@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

BTW, I would have liked to take a couple of weeks, but the exchange
went something like this, but not like this:

I have to take vacation?

Yes.

OK, I'm going to Costa Rica for 3 weeks.

Well, no.

2 weeks.

No.

1 week?

No.

3-4 days?

OK, but you'll have to surrender your passport.



On Thu, 11 Jun 2009 11:13:59 -0700 Chris Vandever
<chris.vandever@onstor.com> wrote:

> I apologize for the delay on this.  I didn't get to it before you
> left on vacation, and for some reason I thought you were going to be
> gone for several weeks.  Anyway, here it is.
> 
> The way I understand it the problem is that we only display 511 map
> rule entries, even if there are more.  The fundamental problem is
> that the CLI is using a buffer of size REC_ARRAY_BUFF_SIZE (which is
> 4096 bytes and thus holds only 512 recEntries) instead of a buffer of
> (ID_MA__CFG_IDXMAX * sizeof(clusDb_recEntry_t)).  There's also an off
> by 1 problem in cluster_getIdmapRuleList() @850 (in the original
> code) where we break out of the while loop when there's still room
> for 1 more entry.
> 
> The biggest problem with the change you're proposing is that it will
> significantly INCREASE the clusDb accesses in the CLI, and will have
> zero change in authen_delIdMapRule() (which looks like it should be
> working just fine since it allocates a large enough buffer to get all
> of the recEntries at one time).  Every time we pass in a non-zero
> cursor to cluster_getIdMapRuleList() we will do exactly the same
> number of clusDb accesses as for a zero cursor.  However, since the
> CLI will now require multiple calls to display everything, each call
> with a non-zero cursor will end up duplicating the accesses already
> done in the previous call before it can start on the new accesses.
> In the case where the customer has somewhere between 512 and 999 id
> map rules, we'll lookup the first 511 twice.
> 
> ChrisV
> 
> 
> -----Original Message-----
> From: Andy Sharp
> Sent: Wednesday, May 27, 2009 4:42 PM
> To: Chris Vandever
> Subject: Re: please review 29293
> 
> There never used to be.  I'll check with Larry.
> 
> On Wed, 27 May 2009 15:43:09 -0700 Chris Vandever
> <chris.vandever@onstor.com> wrote:
> 
> > I can't access your p4 client using p4v.  It claims there's a
> > password required.
> >
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Wednesday, May 27, 2009 2:13 PM
> > To: Chris Vandever
> > Subject: please review 29293
> >
> > Well, here's a golden-oldie.  I'm trying to clean out some of my
> > changelists, and I remembered this one from a-way back.  As I
> > vaguely recall, you wanted more extensive changes to other parts of
> > the API for some reason, so it never got checked in.
> >
> > With the roadmap as it currently exists, I'm thinking those changes
> > to the API aren't terribly necessary, so I thought I'd float this
> > one again to see if I can get it off my list, and to make one of our
> > Japanese customers happier ~:^)
> >
> > Let me know what you think.
> >
> > Thanks,
> >
> > a
> >
> > Change 29293 by andys@ripper on 2008/05/17 23:11:09 *pending*
> >
> >       TED00023242 - Case 7541/ SGI Japan/ idmap list is limited to
> >         511 entries
> >
> >       Add the concept of a cursor to cluster_getIdmapRuleList();
> >       use that to modify _idmap show_ to be able to fetch and
> > display an arbitrary number of records from the database.
> > Substantially reduces clusterdb accesses from some code paths in
> > authen-lib.
> >
> >       Eliminate unused cluster_showIdmapRule method.
> >
> >       reviewed by
> >
> > Affected files ...
> >
> > ... //depot/dev/nfx-tree/code/ssc-authen-lib/idmap-cfg.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-idmap-api.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-idmap-api.h#1 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_idmap.c#7 edit
> >
> 
