AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<e.Jin@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AD1BC60EE@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 15 Jun 2009 16:25:58 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Danqing Jin <e.Jin@onstor.com>
Subject: Re: Request for code review for p4 change 32646
Message-ID: <20090615162558.1d3af312@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AD1BC60EE@exch1.onstor.net>
References: <2779531E7C760D4491C96305019FEEB52AD1BC60EE@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 12 Jun 2009 17:57:00 -0700 Danqing Jin <e.Jin@onstor.com> wrote:

> Andy,
> 
> Could you please review my change (32646) for defect 26925?
> 
> Thanks,
> -Danqing-


= Change 32646 by danqingj@danqingj-dev on 2009/06/12 17:54:09 *pending*
= 
= 	Fix for CQ26925:  vsvr enable fails with the net executable dumping
= 	core (bus error) during 3.3.3 testing 
= 	
= 	The problem here is that the address of the char pointer "tmp" can
= 	misalign along the pointer address boundary after earlier position
= 	manipulation.  The fix is to align it along the address boundary.
= 	
= 	Reviewed by: andyS



nfx-tree/code/samba/nfx/nfx_ldap.c

     line 99 could this not cause len to be way bigger than I think
     you want it to be?

     line 118: this looks broken to me.  could cause tmp to point past
     the size allocated in the realloc call.  why is it necessary
     that tmp be sizeof(char *) aligned?  if this code runs on EEE,
     this could potentially add 7 to tmp.



