AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>,<sandrine.boulanger@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AD1CA7F7E@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 16 Jun 2009 17:36:14 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ed Kwan <ed.kwan@onstor.com>
Cc: Sandrine Boulanger <sandrine.boulanger@onstor.com>
Subject: Re: please review code change for TED 26932 Case 12662 - ONStor -
 Export/Import of shares not working correctly
Message-ID: <20090616173614.0611d671@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AD1CA7F7E@exch1.onstor.net>
References: <2779531E7C760D4491C96305019FEEB52AD1CA7F7E@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 16 Jun 2009 17:19:45 -0700 Ed Kwan <ed.kwan@onstor.com> wrote:

> [edk@edk-linux sm-utils]$ p4 describe 32654
> Change 32654 by edk@edk-dev on 2009/06/16 17:17:40 *pending*
> 
>         For TED 26932 Case 12662 - ONStor - Export/Import of shares
> not working correctly Do not specify the "-f" flag if there is no
> force groups. Reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-utils/cmd-utils.c#31 edit
> ... //depot/dev/nfx-tree/test/t/all/features/nfxsh/volume/share/000_setup_config.t#1
> add ... //depot/dev/nfx-tree/test/t/all/features/nfxsh/volume/share/001_import.t#1
> add ... //depot/dev/nfx-tree/test/t/all/features/nfxsh/volume/share/test_config.yaml#1
> add
> 
> [edk@edk-linux sm-utils]$ p4 diff ...
> ==== //depot/dev/nfx-tree/code/sm-utils/cmd-utils.c#31
> - /homes/edk/p4/dev/nfx-tree/code/sm-utils/cmd-utils.c ====
> 3190,3191c3190,3192 <         fprintf(fp, " -f%s",
> ((extra->cds_force_group_len > 0) ? <
> extra->cds_force_group : "")); ---
> >         if (extra->cds_force_group_len > 0) {
> >             fprintf(fp, " -f%s", extra->cds_force_group);
> >         }
> 
> [edk@edk-linux test]$ ./runtests -v 2 t/all/features/nfxsh/volume/
> # [Tue Jun 16 16:59:12 2009] new(): ONStor::Test::Run object
> instantiated, with verbosity at 2 # [Tue Jun 16 16:59:12 2009]
> queue(): Searching directory `t/all/features/nfxsh/volume/' # [Tue
> Jun 16 16:59:12 2009] queue(): Searching directory
> `t/all/features/nfxsh/volume//share' # [Tue Jun 16 16:59:12 2009]
> queue(): Queueing test
> `t/all/features/nfxsh/volume//share/000_setup_config.t' # [Tue Jun 16
> 16:59:12 2009] queue(): Queueing test
> `t/all/features/nfxsh/volume//share/001_import.t' # [Tue Jun 16
> 16:59:12 2009] queue(): Skipping a file which doesn't end in .t --
> `t/all/features/nfxsh/volume//share/test_config.yaml' # [Tue Jun 16
> 16:59:12 2009] _process_queue(): Running setup test file
> `/homes/edk/p4/dev/nfx-tree/test/t/all/features/nfxsh/volume/share/000_setup_config.t'
> 1..1 ok 1 - Setup done # [Tue Jun 16 16:59:14 2009] _process_queue():
> Setup file
> `/homes/edk/p4/dev/nfx-tree/test/t/all/features/nfxsh/volume/share/000_setup_config.t'
> passed all tests OK # [Tue Jun 16 16:59:14 2009] _process_queue():
> Running test file
> `/homes/edk/p4/dev/nfx-tree/test/t/all/features/nfxsh/volume/share/001_import.t'
> 1..1 ok 1 - share import succesful # [Tue Jun 16 16:59:54 2009]
> _process_queue(): Test file
> `/homes/edk/p4/dev/nfx-tree/test/t/all/features/nfxsh/volume/share/001_import.t'
> passed all tests OK # [Tue Jun 16 16:59:54 2009] _process_queue():
> All tests complete Setup files passed: 1 Setup files failed: 0
> 
> Test files run: 1
> Test files where all tests passed: 1
> Test files where at least one test failed: 0
> 
> Tests run: 1
> Tests passed: 1
> Tests failed: 0
> Tests skipped: 0
> Tests marked todo: 0
> Test TAP errors: 0
> Result: PASS
> 



  ^
  +-- that's cool


= Change 32654 by edk@edk-dev on 2009/06/16 17:17:40 *pending*
= 
= 	For TED 26932 Case 12662 - ONStor - Export/Import of shares
not working correctly = 	Do not specify the "-f" flag if there is no force groups.
= 	Reviewed by
= 


please mention the test files included in the checkin


nfx-tree/code/sm-utils/cmd-utils.c

     looks good

nfx-tree/test/t/all/features/nfxsh/volume/share/000_setup_config.t

     >>add
     nfx-tree/test/t/all/features/nfxsh/volume/share/000_setup_config.t

     ok

nfx-tree/test/t/all/features/nfxsh/volume/share/001_import.t

     >>add nfx-tree/test/t/all/features/nfxsh/volume/share/001_import.t

     line 42, trailing space

nfx-tree/test/t/all/features/nfxsh/volume/share/test_config.yaml

     >>add
     nfx-tree/test/t/all/features/nfxsh/volume/share/test_config.yaml

     ok

