AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090624180457.5066b11f@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	102AB4F33EBBDB4C91915B145C8E9FB31377A3D48B@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 24 Jun 2009 18:05:17 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: please review 32728 mk-binary-repo script
Message-ID: <20090624180517.6aba3624@ripper.onstor.net>
In-Reply-To: <102AB4F33EBBDB4C91915B145C8E9FB31377A3D48B@exch1.onstor.net>
References: <20090624164055.0f724ee7@ripper.onstor.net>
	<102AB4F33EBBDB4C91915B145C8E9FB31377A3D48B@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 24 Jun 2009 17:58:15 -0700 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Answers inline below...
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, June 24, 2009 4:41 PM
> To: Larry Scheer
> Subject: Re: please review 32728 mk-binary-repo script
> 
> On Wed, 24 Jun 2009 12:20:04 -0700 Larry Scheer
> <larry.scheer@onstor.com> wrote:
> 
> > Change 32728 by larrys@larrys on 2009/06/24 12:18:09 *pending*
> > 
> >         Rework script to support multiple distros and architectures.
> >         Add creation of full cross-etch repository.
> >         Reviewed by: AndyS
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/pkg-tools/mk-binary-repo#2 edit
> 
> 
> 
> 
> 
> = Change 32728 by larrys@larrys on 2009/06/24 12:18:09 *pending*
> = 
> = 	Rework script to support multiple distros and architectures.
> = 	Add creation of full cross-etch repository.
> = 	Reviewed by: AndyS
> = 
> 
> 
> What is the overall function of the script?
> 
> LCS > Create and update Onstor Debian package repository from our p4
> package directories.
> 
> 
> linux/pkg-tools/mk-binary-repo
> 
>      line 17 have you tested the usage case?  i didn't think
> backslashes worked inside double quotes
> LCS > It does work I have done it for years. I also tested line 17.
> 
>      line 33 just curious, what's the -F_ option to awk mean?
> LCS > It makes the field separator an underscore.
> 
>      line 59, put the | at the end of the line, and then the \ is
>      not needed
> LCS > Thanks for that bit of info. I have vague recollections of
> being burned by pipes that span lines in the past so I will leave it
> as I have it because I don't have time to retest.

NO!  FIX IT!  Aeeeieeeeeaaaaaaaaiieeeee!

Just kidding.

Kennedy, you have approval for launch.  I say again, launch is a 'go'.


