AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	102AB4F33EBBDB4C91915B145C8E9FB31377A3D4A9@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 30 Jun 2009 12:21:11 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: Please review change 32780 perforce backup script
Message-ID: <20090630122111.501b7ce4@ripper.onstor.net>
In-Reply-To: <102AB4F33EBBDB4C91915B145C8E9FB31377A3D4A9@exch1.onstor.net>
References: <102AB4F33EBBDB4C91915B145C8E9FB31377A3D4A9@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 30 Jun 2009 12:07:27 -0700 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Change 32780 by larrys@larrys on 2009/06/30 12:06:06 *pending*
> 
>         Major cleanup of perforce backup script. Root has super user
> access to archive storage so we no longer need to do everything as
> user perforce. Script would silently fail and report a successful
> backup; added a function to report failure and exit script when a
> major failure occurs. Reviewed by: AndyS
> 
> Affected files ...
> 
> ... //depot/cm/p4_scripts/p4backup.sh#15 edit
> 



= Change 32780 by larrys@larrys on 2009/06/30 12:06:06 *pending*
= 
= 	Major cleanup of perforce backup script. Root has super user
access to = 	archive storage so we no longer need to do
everything as user perforce. = 	Script would silently fail and
report a successful backup; added a = 	function to report
failure and exit script when a major failure occurs. = 	Reviewed
by: AndyS = 

p4_scripts/p4backup.sh

     looks good

     delete the #### END thing ~:^)

