AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090710121418.3f1459f7@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	102AB4F33EBBDB4C91915B145C8E9FB31377A3D4CA@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 10 Jul 2009 12:14:33 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: Please review change 32793 -- This change makes
 install_toolchain work for both Debian and Red Hat systems
Message-ID: <20090710121433.46582831@ripper.onstor.net>
In-Reply-To: <102AB4F33EBBDB4C91915B145C8E9FB31377A3D4CA@exch1.onstor.net>
References: <102AB4F33EBBDB4C91915B145C8E9FB31377A3D4CA@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 7 Jul 2009 20:30:55 -0700 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Andy,
>     This change list does the work to get the Debian workstation
> functioning in our build environment.
> 
> Change 32793 by larrys@larrys on 2009/07/01 16:12:12 *pending*
> 
>         Support for Debian based engineering servers and desktops.
>         o Add mipsel cross packages for amd64 architecture.
>         o Fix some problems with mk-binary-repo when creating a full
> cross-arch repository using debian packages found in a single
> directory. o Replace libgcc1-mipsel-cross package with a version that
> doesn't depend on an installation of a native version of gcc-4.1.
>         o Add debian package support to tool-chain-pkg.mk remove
> unused macros and rules.
>         Reviewed by: AndyS
> 
> Affected files ...
> 
> ... //depot/dev/linux/Pkgs/binary/Deb/cross/binutils-mipsel-linux-gnu_2.17-3_amd64.deb#1
> add ... //depot/dev/linux/Pkgs/binary/Deb/cross/cpp-4.1-mipsel-linux-gnu_4.1.1-21_amd64.deb#1
> add ... //depot/dev/linux/Pkgs/binary/Deb/cross/g++-4.1-mipsel-linux-gnu_4.1.1-21_amd64.deb#1
> add ... //depot/dev/linux/Pkgs/binary/Deb/cross/gcc-4.1-mipsel-linux-gnu-base_4.1.1-21_amd64.deb#1
> add ... //depot/dev/linux/Pkgs/binary/Deb/cross/gcc-4.1-mipsel-linux-gnu-base_4.1.1-21_i386.deb#1
> add ... //depot/dev/linux/Pkgs/binary/Deb/cross/gcc-4.1-mipsel-linux-gnu_4.1.1-21_amd64.deb#1
> add ... //depot/dev/linux/Pkgs/binary/Deb/cross/libgcc1-mipsel-cross_4.1.1-21_all.deb#1
> edit ... //depot/dev/linux/Pkgs/binary/Deb/cross/libstdc++6-4.1-dbg-mipsel-cross_4.1.1-21_all.deb#1
> edit ... //depot/dev/linux/Pkgs/binary/Deb/cross/libstdc++6-4.1-dev-mipsel-cross_4.1.1-21_all.deb#1
> edit ... //depot/dev/linux/Pkgs/binary/Deb/cross/libstdc++6-4.1-pic-mipsel-cross_4.1.1-21_all.deb#1
> edit ... //depot/dev/linux/Pkgs/binary/Deb/cross/libstdc++6-mipsel-cross_4.1.1-21_all.deb#1
> edit ... //depot/dev/linux/Pkgs/binary/Deb/cross/net-tools-mipsel-cross_1.60-17_all.deb#1
> add ... //depot/dev/linux/Pkgs/binary/Deb/cross/readline-common-mipsel-cross_5.2-2_all.deb#1
> add ... //depot/dev/linux/pkg-tools/mk-binary-repo#4 edit
> ... //depot/dev/nfx-tree/Tools/deb-pkg.mk#1 add
> ... //depot/dev/nfx-tree/Tools/rpm-pkg.mk#1 add
> ... //depot/dev/nfx-tree/Tools/tool-chain-pkg.mk#5 edit
> 



= Change 32793 by larrys@larrys on 2009/07/01 16:12:12 *pending*
= 
= 	Support for Debian based engineering servers and desktops.
= 	o Add mipsel cross packages for amd64 architecture.
= 	o Fix some problems with mk-binary-repo when creating a full
cross-arch = 	  repository using Debian packages found in a
single directory. = 	o Replace libgcc1-mipsel-cross package with
a version that doesn't = 	  depend on an installation of a
native version of gcc-4.1. = 	o Add Debian package support to
tool-chain-pkg.mk remove unused macros = 	  and rules.
= 	Reviewed by: AndyS
= 

Makefile

     looks good

linux/Pkgs/binary/Deb/cross/binutils-mipsel-linux-gnu_2.17-3_amd64.deb

     >>add
     linux/Pkgs/binary/Deb/cross/binutils-mipsel-linux-gnu_2.17-3_amd64.deb

linux/Pkgs/binary/Deb/cross/cpp-4.1-mipsel-linux-gnu_4.1.1-21_amd64.deb

     >>add
     linux/Pkgs/binary/Deb/cross/cpp-4.1-mipsel-linux-gnu_4.1.1-21_amd64.deb

linux/Pkgs/binary/Deb/cross/g++-4.1-mipsel-linux-gnu_4.1.1-21_amd64.deb

     >>add
     linux/Pkgs/binary/Deb/cross/g++-4.1-mipsel-linux-gnu_4.1.1-21_amd64.deb

linux/Pkgs/binary/Deb/cross/gcc-4.1-mipsel-linux-gnu-base_4.1.1-21_amd64.deb

     >>add
     linux/Pkgs/binary/Deb/cross/gcc-4.1-mipsel-linux-gnu-base_4.1.1-21_amd64.deb

linux/Pkgs/binary/Deb/cross/gcc-4.1-mipsel-linux-gnu-base_4.1.1-21_i386.deb

     >>add
     linux/Pkgs/binary/Deb/cross/gcc-4.1-mipsel-linux-gnu-base_4.1.1-21_i386.deb

linux/Pkgs/binary/Deb/cross/gcc-4.1-mipsel-linux-gnu_4.1.1-21_amd64.deb

     >>add
     linux/Pkgs/binary/Deb/cross/gcc-4.1-mipsel-linux-gnu_4.1.1-21_amd64.deb

linux/Pkgs/binary/Deb/cross/libgcc1-mipsel-cross_4.1.1-21_all.deb

     looks good

linux/Pkgs/binary/Deb/cross/libstdc++6-4.1-dbg-mipsel-cross_4.1.1-21_all.deb

     looks good

linux/Pkgs/binary/Deb/cross/libstdc++6-4.1-dev-mipsel-cross_4.1.1-21_all.deb

     looks good

linux/Pkgs/binary/Deb/cross/libstdc++6-4.1-pic-mipsel-cross_4.1.1-21_all.deb

     looks good

linux/Pkgs/binary/Deb/cross/libstdc++6-mipsel-cross_4.1.1-21_all.deb

     looks good

linux/Pkgs/binary/Deb/cross/libsyck0-dev_0.55-3.3_amd64.deb

     >>add linux/Pkgs/binary/Deb/cross/libsyck0-dev_0.55-3.3_amd64.deb

linux/Pkgs/binary/Deb/cross/libsyck0-dev_0.55-3.3_i386.deb

     >>add linux/Pkgs/binary/Deb/cross/libsyck0-dev_0.55-3.3_i386.deb

linux/Pkgs/binary/Deb/cross/net-tools-mipsel-cross_1.60-17_all.deb

     >>add
     linux/Pkgs/binary/Deb/cross/net-tools-mipsel-cross_1.60-17_all.deb

linux/Pkgs/binary/Deb/cross/readline-common-mipsel-cross_5.2-2_all.deb

     >>add
     linux/Pkgs/binary/Deb/cross/readline-common-mipsel-cross_5.2-2_all.deb

linux/Pkgs/binary/Deb/cross/tap_1.01-1_amd64.deb

     >>add linux/Pkgs/binary/Deb/cross/tap_1.01-1_amd64.deb

linux/Pkgs/binary/Deb/cross/tap_1.01-1_i386.deb

     >>branch linux/Pkgs/binary/Deb/cross/tap_1.01-1_i386.deb

linux/Pkgs/binary/Deb/tap_1.01-1_i386.deb

     >>delete linux/Pkgs/binary/Deb/tap_1.01-1_i386.deb

linux/pkg-tools/mk-binary-repo

     looks good

nfx-tree/Tools/deb-pkg.mk

     >>add nfx-tree/Tools/deb-pkg.mk

     Probably should fix the comments to just say Linux OS rather
     than SSC Linux OS, since it's about to be on everything cougar
     very soon.  Several files.

nfx-tree/Tools/rpm-pkg.mk

     ok

nfx-tree/Tools/tool-chain-pkg.mk

     you shouldn't have to use strip everywhere, since you are testing
     variables that your file is in full control of.

     also, in general, test for the positive not the negative for
     future-proofing: instead of doing

     ifneq ($(strip $(USE_RPM)),)
     	PKG_EXT		:= rpm
	PKGDIR	        := $(RPM_PKG_DIR)
     else
     	PKG_EXT		:= deb
	PKGDIR	        := $(DEB_PKG_DIR)
     endif

     do

     ifeq ($(USE_DEB), yes)
     	PKG_EXT		:= deb
	PKGDIR	        := $(DEB_PKG_DIR)
     else
     	PKG_EXT		:= rpm
	PKGDIR	        := $(RPM_PKG_DIR)
     endif

     well, you get the idea.

     line 157, USE_RPM needs to be in quotes

     line 192 no reason to obfuscate the p4 command

