AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090710230843.2095b251@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	102AB4F33EBBDB4C91915B145C8E9FB31377A3D4DC@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 10 Jul 2009 23:09:02 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: Please review change 32793 -- This change makes
 install_toolchain work for both Debian and Red Hat systems
Message-ID: <20090710230902.4138b225@ripper.onstor.net>
In-Reply-To: <102AB4F33EBBDB4C91915B145C8E9FB31377A3D4DC@exch1.onstor.net>
References: <20090710121433.46582831@ripper.onstor.net>
	<102AB4F33EBBDB4C91915B145C8E9FB31377A3D4DC@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 10 Jul 2009 19:29:33 -0700 Larry Scheer
<larry.scheer@onstor.com> wrote:

> nfx-tree/Tools/deb-pkg.mk
> 
>      >>add nfx-tree/Tools/deb-pkg.mk
> 
>      Probably should fix the comments to just say Linux OS rather
>      than SSC Linux OS, since it's about to be on everything cougar
>      very soon.  Several files.
> 
> LCS >> Fixed
> 
> nfx-tree/Tools/rpm-pkg.mk
> 
>      ok
> 
> nfx-tree/Tools/tool-chain-pkg.mk
> 
>      you shouldn't have to use strip everywhere, since you are testing
>      variables that your file is in full control of.
> 
> LCS >> I use strip all over the place because it keeps developers
> from accidentally breaking my Makefiles. Using strip as I do is an
> old builder's trick. 

Acceptable.

LCS >> I can change the negative to a positive.
> Not quite sure what you mean by "future-proofing" The method you show
> will break if another Linux variant is added that uses or adopts deb
> packages unless the DEB_BASED macro is also updated. I think there is
> less maintenance of the file needed using my method. 

The example wasn't the perfect example, I freely admit.  By
future-proofing, well, hell, you know what I mean.  Might have been
better if I left the order as you originally had it but just made it
positive instead of negative.


> 
>      also, in general, test for the positive not the negative for
>      future-proofing: instead of doing
> 
>      ifneq ($(strip $(USE_RPM)),)
>      	PKG_EXT		:= rpm
> 	PKGDIR	        := $(RPM_PKG_DIR)
>      else
>      	PKG_EXT		:= deb
> 	PKGDIR	        := $(DEB_PKG_DIR)
>      endif
> 
>      do
> 
>      ifeq ($(USE_DEB), yes)
>      	PKG_EXT		:= deb
> 	PKGDIR	        := $(DEB_PKG_DIR)
>      else
>      	PKG_EXT		:= rpm
> 	PKGDIR	        := $(RPM_PKG_DIR)
>      endif
> 
>      well, you get the idea.
> 
>      line 157, USE_RPM needs to be in quotes
> 
> LCS >> Actually no, adding quotes breaks the test. Trust me on this.
> If quotes are added you also need to add the -n or -z. It is a very
> subtle difference.

If you don't have quotes, and it's empty, you will get a syntax error,
and the script will bomb.  That's what I'm worried about.


> 
>      line 192 no reason to obfuscate the p4 command
> 
> LCS >> Fixed
> 


All good.  Use your best judgement and check 'er in.

Thanks,

a
