AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090711125924.3fc5d075@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AD1E6D0B8@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Sat, 11 Jul 2009 12:59:32 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ed Kwan <ed.kwan@onstor.com>
Subject: Re: please review code change for TED 27094 NCM: vsvr: edit vsvr:
 autocreate volID drop box only display the 1st 4 volumes belong to vsvr
Message-ID: <20090711125932.53a92161@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AD1E6D0B8@exch1.onstor.net>
References: <2779531E7C760D4491C96305019FEEB52AD1E6D0B8@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Pretty simple change, looks ok to me.  For my own education I'd like to
know a little more about what's going on, but you don't have to hold up
the checkin for that ~:^)

On Fri, 10 Jul 2009 18:36:46 -0700 Ed Kwan <ed.kwan@onstor.com> wrote:

> Change 32856 by edk@edk-dev on 2009/07/10 17:15:55 *pending*
> 
>         For TED 27094 NCM: vsvr: edit vsvr: autocreate volID drop box
> only display the 1st 4 volumes belong to vsvr
>         Before processing the list of volumes in the "Volumes owned"
> section, merge them to a single line if they span multiple lines.
>         Reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-webui/js/vsvr/edit.js#13 edit
> 
> [edk@edk-linux vsvr]$ p4 diff -dc ...
> ==== //depot/dev/nfx-tree/code/ssc-webui/js/vsvr/edit.js#13
> - /homes/edk/p4/dev/nfx-tree/code/ssc-webui/js/vsvr/edit.js ====
> *************** *** 287,292 ****
> --- 287,299 ----
>               }
>               else if(string.has(vsvr_info[i], "Volumes owned"))
>               {
> +                 var next_line;
> +                 for (next_line=i+1; next_line<vsvr_info.length &&
> +                                     !string.has(vsvr_info[next_line],
> ":");
> +                                         next_line++) {
> +                         vsvr_info[i] = vsvr_info[i] +
> vsvr_info[next_line];
> +                 }
> +
>                   vsvr_info[i] =
> string.trim_multi_space(vsvr_info[i]); vsvr_info[i] =
> vsvr_info[i].split(" "); for(j = 3; j < vsvr_info[i].length-1; j++)
