AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090713184249.7fc65e31@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<brian.stark@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
FMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AD1B85F08@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 13 Jul 2009 18:43:00 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Brian Stark <brian.stark@onstor.com>
Subject: Fw: please review 32863
Message-ID: <20090713184300.4f09a124@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Rendell says OK, it must be, then.

a


Begin forwarded message:

Date: Mon, 13 Jul 2009 17:44:58 -0700
From: Rendell Fong <rendell.fong@onstor.com>
To: Andy Sharp <andy.sharp@onstor.com>
Subject: RE: please review 32863


It looks ok.  The hole memory areas are being skipped.  The small area
after the hole starting at 1f8000000 and 2f8000000 are setup at the
very end of virtual mem.


> -----Original Message-----
> From: Andy Sharp
> Sent: Monday, July 13, 2009 5:17 PM
> To: Rendell Fong
> Subject: Fw: please review 32863
> 
> Rendell,
> 
> Can you take a look at these new tlb changes in the one file?  I've
> already reviewed the rest of it, but they look pretty funky to me, but
> I know you've had to look at some of this in the past especially wrt
> to the memory hole [of death].
> 
> just this one file:
> 
> ... //depot/dev/prom/cg/code/sm-sb1480/tlb.c#8 edit
> 
> Thanks,
> 
> a
> 
> 
> 
> Begin forwarded message:
> 
> Date: Mon, 13 Jul 2009 11:51:08 -0700
> From: Brian Stark <brian.stark@onstor.com>
> To: Andy Sharp <andy.sharp@onstor.com>
> Subject: RE: please review 32863
> 
> 
> I already made the changes to use the "user" autoload variable and put
> them into a pending changelist that I have for a few other things.
> Can you just review changelist 32740?  I've tested these changes and
> know that it will work in the Ops mfg flow.
> 
> 
> 
> Change 32740 by brians@brians on 2009/06/24 15:32:44 *pending*
> 
>         Remove memory speed limitation in changelist 31667.  Add TLB
> and diag memory test support for 2GB modules.  Change autoload
> variable to (off on user) where 'on' maintains the serial autoloading
> from the SSC and 'user' loads the FP and TXRX using a Linux userspace
> program.
> 
>         Reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/prom/cg/code/prom-pmon/memtst.c#12 edit
> ... //depot/dev/prom/cg/code/prom-sibyte-init/bcm1480_draminit.c#6
> edit ... //depot/dev/prom/cg/code/sm-loader/load-auto.c#9 edit
> ... //depot/dev/prom/cg/code/sm-sb1480/tlb.c#8 edit
> ... //depot/dev/prom/cg/code/sm-seep/env.c#7 edit
> 
> 
> 
> -----Original Message-----
> From: Andy Sharp
> Sent: Monday, July 13, 2009 11:26 AM
> To: Brian Stark
> Subject: please review 32863
> 
> Hi Brian,
> 
> In these changes you can see the default value is set to "user" but
> I'm not totally sure about that one.  I don't know what default value
> means in the sense that is this was is programmed into the variable
> by ops, or is that independent of the so-called "default value"?
> 
> I'm having trouble with perforce right now, or I'd queue up all the
> change lists that need to be integrated from dev to rel402 and get the
> ball rolling on getting those approved by Ed.
> 
> 
> 
> Change 32863 by andys@ripper on 2009/07/13 10:17:52 *pending*
> 
> 	Change the third value of autoload PROM env variable to
> 	"user" instead of "old", and switch the logic to mean the old
> 	"prom-all-the-way" image loading method will be invoked when
> the variable is set to "on" and the new user-space loading method
> 	will be invoked when the variable is set to "user".
> 
> 	This gives us independence from any particular run-time
> version so PROMs can be upgraded w/o also having to upgrade the
> runtime, and vice versa.
> 
> 	Reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/prom/cg/code/sm-loader/load-auto.c#9 edit
> ... //depot/dev/prom/cg/code/sm-seep/env.c#7 edit

