AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090729105958.2b7d04c6@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AD708EDE8@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 29 Jul 2009 11:00:15 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Rendell Fong <rendell.fong@onstor.com>
Subject: Re: [Nightly] Failure in nightly build of dev branch
Message-ID: <20090729110015.4368f618@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AD708EDE8@exch1.onstor.net>
References: <20090729104929.32b81c2e@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB52AD708EDE8@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 29 Jul 2009 10:55:44 -0700 Rendell Fong
<rendell.fong@onstor.com> wrote:

> Ok, I figured out the culprit.  The crashdump_t structure needs the
> special redefinition for Bobcat as well.
> 
> linux-compile.onstor.net $ p4 diff crashdump.h
> ==== //depot/dev/nfx-tree/code/sm-except/crashdump.h#3
> - /homes/rendellf/devtest/nfx-tree/code/sm-except/crashdump.h ====
> 58c58 < #if defined(SSC) && defined(COUGAR)
> ---
> > #if defined(SSC) && (defined(COUGAR) || defined(BOBCAT))

Are you sure?  That makes regs u64 for both (which might be right, I
can't remember)  BTW, it should just be #ifdef SSC, there's only bobcat
and cougar now for some time ~:^)

> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Wednesday, July 29, 2009 10:49 AM
> > To: Rendell Fong
> > Cc: Larry Scheer
> > Subject: Re: [Nightly] Failure in nightly build of dev branch
> >
> > On Wed, 29 Jul 2009 10:36:11 -0700 Rendell Fong
> > <rendell.fong@onstor.com> wrote:
> >
> > > The values are the right size (wrt to the kernel).  The issue is
> > > that the user space app needs to handle these values when reading
> > > them from prom and writing them to the crash file.
> > >
> > > Note: You are right about the %p. Forgot about the extra "0x"
> > > that is added.
> > >
> > > Change 33015 by rendellf@rendellf-test on 2009/07/29 10:27:05
> > > *pending*
> > >
> > >         Fix compile error for Bobcat Linux.
> > >
> > > Affected files ...
> > >
> > > ... //depot/dev/nfx-tree/code/ssc-crashsave/linux.c#3 edit
> >
> > Err, uh, no, like I said before "%lx" should work on both since
> > sizeof(long) == sizeof(void *) on both platforms.
> >
> >
> > > > -----Original Message-----
> > > > From: Andy Sharp
> > > > Sent: Wednesday, July 29, 2009 10:30 AM
> > > > To: Rendell Fong
> > > > Cc: Larry Scheer
> > > > Subject: Re: [Nightly] Failure in nightly build of dev branch
> > > >
> > > > On Wed, 29 Jul 2009 10:09:22 -0700 Rendell Fong
> > > > <rendell.fong@onstor.com> wrote:
> > > >
> > > > > In cougar, are the pointers in user space 32-bits?
> > > > > I need to display the 64-bit value.
> > > > >
> > > > > The following works for Bobcat but not for Cougar.
> > > > >
> > > > > regs[xxx] array is defined as uint64.
> > > > >
> > > > > fprintf(fp, "BadVA : %p\n", (void
> > > > > *)cptr->regs[EF_CP0_BADVADDR]);
> > > >
> > > > %p will put "0x" on the front, which I don't think you are
> > > > doing.
> > > >
> > > > That array should be the proper size for the purpose, if it's
> > > > userspace VA then it should be 32 bits, and the printf should be
> > > > written properly for that.  Sounds like the array is not the
> > > > right type.
> > > >
> > > > > linux.c:128: warning: cast to pointer from integer of
> > > > > different size
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Andy Sharp
> > > > > > Sent: Wednesday, July 29, 2009 9:56 AM
> > > > > > To: Rendell Fong
> > > > > > Cc: Larry Scheer
> > > > > > Subject: Re: [Nightly] Failure in nightly build of dev
> > > > > > branch
> > > > > >
> > > > > > On Wed, 29 Jul 2009 09:52:48 -0700 Rendell Fong
> > > > > > <rendell.fong@onstor.com> wrote:
> > > > > >
> > > > > > > Ok, I'll fix it. Only problem is that Bobcat wants:
> > > > > > >    printk("%0*x", sizeof(void *), addr)
> > > > > > > and Cougar wants:
> > > > > > >    printk("%0*llx", sizeof(void *), addr)
> > > > > > >
> > > > > > > Looks like I'll need to use some ifdefs or not use the
> > > > > > > uint64 typedef.
> > > > > >
> > > > > > No, you shouldn't use that typedef.  But you can always
> > > > > > just do this:
> > > > > >
> > > > > >     printk("%0*lx", sizeof(void *), (void *)addr)
> > > > > >
> > > > > > >
> > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Andy Sharp
> > > > > > > > Sent: Wednesday, July 29, 2009 9:34 AM
> > > > > > > > To: Rendell Fong
> > > > > > > > Cc: Larry Scheer
> > > > > > > > Subject: Re: [Nightly] Failure in nightly build of dev
> > > > > > > > branch
> > > > > > > >
> > > > > > > > Yes.  Do it the same as Jan, except make the '16' part
> > > > > > > > variable based on the size of void *
> > > > > > > >
> > > > > > > > I think the printf format syntax is something like
> > > > > > > >
> > > > > > > > printk("%0*lx", sizeof(void *), addr)
> > > > > > > >
> > > > > > > > It should just be 'long' anyway, not 'long long', I
> > > > > > > > should have spotted that.
> > > > > > > >
> > > > > > > >
> > > > > > > > On Wed, 29 Jul 2009 09:02:39 -0700 Rendell Fong
> > > > > > > > <rendell.fong@onstor.com> wrote:
> > > > > > > >
> > > > > > > > > Larry,
> > > > > > > > >
> > > > > > > > > It appears that we are still building Bobcat Linux.
> > > > > > > > > Do I need to fix this?
> > > > > > > > >
> > > > > > > > > Rendell
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: Build User [mailto:build@compile3.onstor.net]
> > > > > > > > > Sent: Wednesday, July 29, 2009 5:59 AM
> > > > > > > > > To: Sandrine Boulanger; dl-Software
> > > > > > > > > Subject: [Nightly] Failure in nightly build of dev
> > > > > > > > > branch
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Failure in nightly build of dev branch
> > > > > > > > > while building Bobcat Linux opt build.
> > > > > > > > > ***** event PKG include file *****
> > > > > > > > > make[3]: Entering directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-event' make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libevent.d' is up to
> > > > > > > > > date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-event' *****
> > > > > > > > > acrypt PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-crypt' make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libacrypt.d' is up to
> > > > > > > > > date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-crypt' *****
> > > > > > > > > icudata PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-icu-data'
> > > > > > > > > make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libicudata.d' is up
> > > > > > > > > to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-icu-data' *****
> > > > > > > > > icucommon PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-icu-common'
> > > > > > > > > make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libicucommon.d' is up
> > > > > > > > > to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-icu-common'
> > > > > > > > > ***** nfxnis PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-nfxnis'
> > > > > > > > > make[3]: `../../Build/bl/opt/Depends/SSC/libnfxnis.d'
> > > > > > > > > is up to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-nfxnis' *****
> > > > > > > > > authen PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-authen-lib'
> > > > > > > > > make[3]: `../../Build/bl/opt/Depends/SSC/libauthen.d'
> > > > > > > > > is up to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-authen-lib'
> > > > > > > > > ***** rmc PKG include file ***** make[3]: Entering
> > > > > > > > > directory `/perforce/trees/dev/nfx-tree/code/ssc-rmc'
> > > > > > > > > make[3]: `../../Build/bl/opt/Depends/SSC/librmc.d' is
> > > > > > > > > up to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-rmc' ***** ncm
> > > > > > > > > PKG include file ***** make[3]: Entering directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-ncm-lib'
> > > > > > > > > make[3]: `../../Build/bl/opt/Depends/SSC/libncm.d' is
> > > > > > > > > up to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-ncm-lib' *****
> > > > > > > > > cluster PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-cluster'
> > > > > > > > > make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libcluster.d' is up
> > > > > > > > > to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-cluster'
> > > > > > > > > make[2]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-crashsave'
> > > > > > > > > make[2]: Entering directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-crashsave'
> > > > > > > > > ***** genlib PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-genlib'
> > > > > > > > > make[3]: `../../Build/bl/opt/Depends/SSC/libgenlib.d'
> > > > > > > > > is up to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-genlib' *****
> > > > > > > > > bsdcompat PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-bsdcompat'
> > > > > > > > > make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libbsdcompat.d' is up
> > > > > > > > > to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-bsdcompat'
> > > > > > > > > ***** event PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-event' make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libevent.d' is up to
> > > > > > > > > date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-event' *****
> > > > > > > > > acrypt PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-crypt' make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libacrypt.d' is up to
> > > > > > > > > date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-crypt' *****
> > > > > > > > > icudata PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-icu-data'
> > > > > > > > > make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libicudata.d' is up
> > > > > > > > > to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-icu-data' *****
> > > > > > > > > icucommon PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-icu-common'
> > > > > > > > > make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libicucommon.d' is up
> > > > > > > > > to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/sm-icu-common'
> > > > > > > > > ***** nfxnis PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-nfxnis'
> > > > > > > > > make[3]: `../../Build/bl/opt/Depends/SSC/libnfxnis.d'
> > > > > > > > > is up to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-nfxnis' *****
> > > > > > > > > authen PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-authen-lib'
> > > > > > > > > make[3]: `../../Build/bl/opt/Depends/SSC/libauthen.d'
> > > > > > > > > is up to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-authen-lib'
> > > > > > > > > ***** rmc PKG include file ***** make[3]: Entering
> > > > > > > > > directory `/perforce/trees/dev/nfx-tree/code/ssc-rmc'
> > > > > > > > > make[3]: `../../Build/bl/opt/Depends/SSC/librmc.d' is
> > > > > > > > > up to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-rmc' ***** ncm
> > > > > > > > > PKG include file ***** make[3]: Entering directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-ncm-lib'
> > > > > > > > > make[3]: `../../Build/bl/opt/Depends/SSC/libncm.d' is
> > > > > > > > > up to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-ncm-lib' *****
> > > > > > > > > cluster PKG include file ***** make[3]: Entering
> > > > > > > > > directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-cluster'
> > > > > > > > > make[3]:
> > > > > > > > > `../../Build/bl/opt/Depends/SSC/libcluster.d' is up
> > > > > > > > > to date. make[3]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-cluster'
> > /usr/bin/mipsel-
> > > > > > linux-
> > > > > > > > gnu-gcc-4.1
> > > > > > > > > -fPIC -fms-extensions -fno-reorder-blocks
> > > > > > > > > -Wno-pointer-sign -DBOBCAT
> > > > > > > > > -DDEFAULT_VENDOR_NAME=\"ONStor\"
> > > > > > > > > -DDEFAULT_PROD_NAME=\"BOBCAT\" -Wall
> > > > > > > > > -Wmissing-prototypes -DR4000 -Werror
> > > > > > > > > -DEXTENDED_SECURITY -DNFX_KERBEROS -DNETEEE_FRAGMENT
> > > > > > > > > -G 0  -DONSTOR_CHANGE -DLDAP_DEPRECATED
> > > > > > > > > -DOS_INCL=\"linux.h\" -I./linux
> > > > > > > > > -I../../Includes/bl/SSC -I../../Includes/bl
> > > > > > > > > -I../../Includes/linux -I../../Includes -I.
> > > > > > > > > -I../../Build/bl/opt -DLANGUAGE_C -DLINUX_TEST
> > > > > > > > > -DLANGUAGE_C -DSSC  -I./linux -I../../Includes/bl/SSC
> > > > > > > > > -I../../Includes/bl -I../../Includes/linux
> > > > > > > > > -I../../Includes -I. -I../../Build/bl/opt -g -DSSC
> > > > > > > > > -DSSC_mips -DNFX_MOD_SSC -c crashsave.c
> > > > > > > > > -o ../../Build/bl/opt/Objects/SSC/ssc-crashsave/crashsave.o
> > > > > > > > /usr/bin/mipsel-linux-gnu-gcc-4.1
> > > > > > > > > -fPIC -fms-extensions -fno-reorder-blocks
> > > > > > > > > -Wno-pointer-sign -DBOBCAT
> > > > > > > > > -DDEFAULT_VENDOR_NAME=\"ONStor\"
> > > > > > > > > -DDEFAULT_PROD_NAME=\"BOBCAT\" -Wall
> > > > > > > > > -Wmissing-prototypes -DR4000 -Werror
> > > > > > > > > -DEXTENDED_SECURITY -DNFX_KERBEROS -DNETEEE_FRAGMENT
> > > > > > > > > -G 0  -DONSTOR_CHANGE -DLDAP_DEPRECATED
> > > > > > > > > -DOS_INCL=\"linux.h\" -I./linux
> > > > > > > > > -I../../Includes/bl/SSC -I../../Includes/bl
> > > > > > > > > -I../../Includes/linux -I../../Includes -I.
> > > > > > > > > -I../../Build/bl/opt -DLANGUAGE_C -DLINUX_TEST
> > > > > > > > > -DLANGUAGE_C -DSSC  -I./linux -I../../Includes/bl/SSC
> > > > > > > > > -I../../Includes/bl -I../../Includes/linux
> > > > > > > > > -I../../Includes -I. -I../../Build/bl/opt -g -DSSC
> > > > > > > > > -DSSC_mips -DNFX_MOD_SSC -c linux.c
> > > > > > > > > -o ../../Build/bl/opt/Objects/SSC/ssc-crashsave/linux.o
> > > > > > > > > cc1: warnings being treated as errors linux.c: In
> > > > > > > > > function 'crashsave_copy_dump': linux.c:131: warning:
> > > > > > > > > format '%016llx' expects type 'long long unsigned
> > > > > > > > > int', but argument 4 has type 'unsigned int'
> > > > > > > > > linux.c:131: warning: format '%016llx' expects type
> > > > > > > > > 'long long unsigned int', but argument 5 has type
> > > > > > > > > 'unsigned int' linux.c:131: warning: format '%016llx'
> > > > > > > > > expects type 'long long unsigned int', but argument 6
> > > > > > > > > has type 'unsigned int' linux.c:131: warning: format
> > > > > > > > > '%016llx' expects type 'long long unsigned int', but
> > > > > > > > > argument 7 has type 'unsigned int' linux.c:135:
> > > > > > > > > warning: format '%016llx' expects type 'long long
> > > > > > > > > unsigned int', but argument 3 has type 'unsigned int'
> > > > > > > > > linux.c:136: warning: format '%016llx' expects type
> > > > > > > > > 'long long unsigned int', but argument 3 has type
> > > > > > > > > 'unsigned int' linux.c:141: warning: format '%016llx'
> > > > > > > > > expects type 'long long unsigned int', but argument 3
> > > > > > > > > has type 'unsigned int' linux.c:190: warning: format
> > > > > > > > > '%016llx' expects type 'long long unsigned int', but
> > > > > > > > > argument 3 has type 'unsigned int' linux.c:209:
> > > > > > > > > warning: format '%016llx' expects type 'long long
> > > > > > > > > unsigned int', but argument 4 has type 'unsigned int'
> > > > > > > > > make[2]: ***
> > > > > > > > > [../../Build/bl/opt/Objects/SSC/ssc-crashsave/linux.o]
> > > > > > > > > Error 1 make[2]: Leaving directory
> > > > > > > > > `/perforce/trees/dev/nfx-tree/code/ssc-crashsave'
> > > > > > > > > make[1]: *** [default] Error 1 make[1]: Leaving
> > > > > > > > > directory `/perforce/trees/dev/nfx-tree' make: ***
> > > > > > > > > [ssc] Error 2
> > > > > > > > >
> > > > > > > > >
