AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Yifeng.Liu@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	D36DB4126B506541A862C33BE1FB1488FE7CD1EA@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 19 Aug 2009 18:10:44 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Liu, Yifeng" <Yifeng.Liu@lsi.com>
Subject: Re: PERFORCE change 33165 for review
Message-ID: <20090819181044.30b381a0@ripper.onstor.net>
In-Reply-To: <D36DB4126B506541A862C33BE1FB1488FE7CD1EA@cosmail03.lsi.com>
References: <WEBMAILM2DmSRY3ZK2u0001a929@mail.onstor.com>
	<20090819133556.5b862971@ripper.onstor.net>
	<D36DB4126B506541A862C33BE1FB1488FE7CD1EA@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 19 Aug 2009 15:13:06 -0600 "Liu, Yifeng" <Yifeng.Liu@lsi.com>
wrote:

> Thanks for the reminder. All noted.
> 
> Not sure if it is still possible to add the comments.

Not important for just one change.  More important over large period of
time and many changes.

Thanks,

a


> yifeng
> ________________________________________
> From: Andrew Sharp [andy.sharp@lsi.com]
> Sent: Wednesday, August 19, 2009 1:35 PM
> To: Yifeng Liu
> Subject: Re: PERFORCE change 33165 for review
> 
> On Tue, 18 Aug 2009 19:00:01 -0600 Yifeng Liu <yifeng.liu@onstor.com>
> wrote:
> 
> > Change 33165 by yliu@yliu-r403rel-ssc-support on 2009/08/18 17:58:26
> >
> >       Integrate r333rel changeset 32666.
> >       Reviewed by edk.
> >
> > Affected files ...
> >
> > ... //depot/r403rel/nfx-tree/code/ssc-support/support.sh#3 integrate
> >
> >
> > http://liszt:1818/@md=d&cd=//depot/$c=G35@/33165?ac=10
> 
> Hi Yifeng,
> 
> Just a note to let you know some of our checkin comment conventions:
> 
> When doing an integrate like this, please say what the change is
> about.  Most people just cut and paste the original comment from the
> original checkin.  For example, if it fixes a bug, include the
> clearquest bug number and some description of what the bug was, as
> well as what the change/fix was.  The original comment should have
> all that information, which is why people often just quote or
> cut-n-paste that in.
> 
> Thanks,
> 
> a
