AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ed.Kwan@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	8194F90CDF4194468A47F48BF8632B38010D31554D@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 21 Aug 2009 12:34:52 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kwan, Ed" <Ed.Kwan@lsi.com>
Subject: Re: please review code change for TED 27287 [13170 - Veristor] CLI
 help feature (?) can fail with a valid command
Message-ID: <20090821123452.5a385175@ripper.onstor.net>
In-Reply-To: <8194F90CDF4194468A47F48BF8632B38010D31554D@cosmail03.lsi.com>
References: <8194F90CDF4194468A47F48BF8632B38010D1753E4@cosmail03.lsi.com>
	<20090821113228.40e58454@ripper.onstor.net>
	<8194F90CDF4194468A47F48BF8632B38010D31554D@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit



= Change 33185 by edk@edk-dev on 2009/08/21 11:50:32
= 
= 	Workaround for TED 27287 [13170 - Veristor] CLI help 
= 	feature (?) can fail with a valid command
= 	Reviewed by AndyS.

Some of this stuff

> > I think the problem is in the readline library which I don't think
> > is worth the effort to troubleshoot.  This is a workaround with
> > little to no risk.

should go into the checkin comment.

Try <slap> to get into the habit <slap> of not putting a name in <slap>
BEFORE <slap> that person has reviewed it <slap> thank you!




nfx-tree/code/ssc-nfxsh/vtysh.c


     d00d, you need to fix up the comments more.  instead of the TED
     number, put the problem, and why/how this works around it.  'cuz
     neither I, nor anyone else coming along later, can tell what's the
     dillio.



On Fri, 21 Aug 2009 12:53:00 -0600 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:

> The change number is 33185.  I just submitted it accidently!  Crap.
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Friday, August 21, 2009 11:32 AM
> To: Kwan, Ed
> Subject: Re: please review code change for TED 27287 [13170 -
> Veristor] CLI help feature (?) can fail with a valid command
> 
> I know it's in here somewhere, but I just can't seem to find the
> changelist #.  BTW, all this info is available from the changelist #,
> so that's all a body really needs to send...I should write a wiki page
> or something.  Yeah.
> 
> Hey, aren't you supposed to be out of the office?  Yes, you are.  So I
> don't really have to worry about this until Monday ~:^)
> 
> On Thu, 20 Aug 2009 19:42:49 -0600 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:
> 
> > I think the problem is in the readline library which I don't think
> > is worth the effort to troubleshoot.  This is a workaround with
> > little to no risk.
> > 
> > [edk@edk-linux ssc-nfxsh]$ p4 info
> > User name: edk
> > Client name: edk-dev
> > Client host: edk-linux.onstor.net
> > Client root: /homes/edk/p4/dev
> > Current directory: /homes/edk/p4/dev/nfx-tree/code/ssc-nfxsh
> > Client address: 10.0.0.137:58593
> > Server address: liszt.onstor.net:1717
> > Server root: /p4data/p4root
> > Server date: 2009/08/20 18:39:32 -0700 PDT
> > Server version: P4D/LINUX26X86_64/2007.2/122958 (2007/05/23)
> > Server license: ONStor 40 users (support expired 2009/05/20)
> > [edk@edk-linux ssc-nfxsh]$ p4 diff -dc ...
> > ==== //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh.c#11
> > - /homes/edk/p4/dev/nfx-tree/code/ssc-nfxsh/vtysh.c ====
> > *************** *** 431,436 ****
> > --- 431,440 ----
> >     int width;
> >     struct desc *desc;
> >     int isOptional = FALSE;
> > +   int unused;
> > +
> > +   /* workaround for TED 27287 */
> > +   unused = 0;
> > 
> >     vline = cmd_make_strvec(rl_line_buffer);
