AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>,<Bill.Fisher@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1251396723.23744.70.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 27 Aug 2009 13:19:56 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Cc: "Fisher, Bill" <Bill.Fisher@lsi.com>
Subject: Re: merge of kernel git tree updates to perforce tuxrx branch
Message-ID: <20090827131956.512d692c@ripper.onstor.net>
In-Reply-To: <1251396723.23744.70.camel@rendellf>
References: <1251331545.23744.57.camel@rendellf>
	<20090826175432.78d20470@ripper.onstor.net>
	<1251335931.23744.63.camel@rendellf>
	<20090826182247.61e8009d@ripper.onstor.net>
	<1251396723.23744.70.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Looks ok to me.  Hey, it's not my fault our code does the el-suck-o.

Let me know if you think you're ready for me to review the changelist.

Cheers,

a

On Thu, 27 Aug 2009 12:12:03 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> The module now builds but there's tons of warnings.  The following is
> just a small sampling.
>=20
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.h:29: warning:
> function declaration isn=E2=80=99t a prototype
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.h:30: warning:
> function declaration isn=E2=80=99t a prototype
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.h:31: warning:
> function declaration isn=E2=80=99t a prototype
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.h:38: warning:
> function declaration isn=E2=80=99t a prototype
> In file included
> from /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash- api.c:23:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.h:29: warning:
> function declaration isn=E2=80=99t a prototype
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.h:30: warning:
> function declaration isn=E2=80=99t a prototype
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.h:31: warning:
> function declaration isn=E2=80=99t a prototype
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.h:38: warning:
> function declaration isn=E2=80=99t a prototype
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash-api.c: In function
> =E2=80=98hash_create=E2=80=99:/homes/rendellf/tuxrx/nfx-tree/code/sm-hash=
/hash-api.c:60:
> warning: return makes integer from pointer without a cast
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash-api.c:66: warning:
> return makes integer from pointer without a cast
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.c:47: warning:
> function declaration isn=E2=80=99t a prototype
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.c: In function
> =E2=80=98hash_display=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-hash/hash.c:91: warning:
> implicit declaration of function =E2=80=98printf=E2=80=99
>=20
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-verify.c: In
> function =E2=80=98sbm_verifyPktInTXRXPool=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-verify.c:320:
> warning: unused variable =E2=80=98bd=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-verify.c:319:
> warning: unused variable =E2=80=98i=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-verify.c:319:
> warning: unused variable =E2=80=98num_bufs=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-verify.c: In
> function =E2=80=98__sbm_verifyIsPktOk=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-verify.c:391:
> warning: ISO C90 forbids mixed declarations and code
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-verify.c:396:
> warning: passing argument 3 of =E2=80=98eee_buf_valid=E2=80=99 makes inte=
ger from
> pointer without a cast
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-verify.c:405:
> warning: implicit declaration of function =E2=80=98printf=E2=80=99
>=20
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c: In
> function =E2=80=98sbm_testDisplayCod=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:93:
> warning: implicit declaration of function =E2=80=98printf=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:57:
> warning: unused variable =E2=80=98i=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:57:
> warning: unused variable =E2=80=98num_bufs=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:56:
> warning: unused variable =E2=80=98attr3=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:56:
> warning: unused variable =E2=80=98attr2=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:56:
> warning: unused variable =E2=80=98attr1=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:56:
> warning: unused variable =E2=80=98attr0=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:55:
> warning: unused variable =E2=80=98bd=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:54:
> warning: unused variable =E2=80=98edesc=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c: In
> function =E2=80=98sbm_testDisplayPkt=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:114:
> warning: unused variable =E2=80=98i=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:114:
> warning: unused variable =E2=80=98num_bufs=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:113:
> warning: unused variable =E2=80=98attr3=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:113:
> warning: unused variable =E2=80=98attr2=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:113:
> warning: unused variable =E2=80=98attr1=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:113:
> warning: unused variable =E2=80=98attr0=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:112:
> warning: unused variable =E2=80=98bd=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c: In
> function =E2=80=98sbm_testDisplayStats=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c:237:
> warning: implicit declaration of function =E2=80=98eee_getAvailableNbrOfB=
ufs=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-mgmt.c: In
> function =E2=80=98sbm_make_same_buf_cod=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-mgmt.c:156:
> warning: ISO C90 forbids mixed declarations and code
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-mgmt.c:168:
> warning: ISO C90 forbids mixed declarations and code
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-mgmt.c: In
> function =E2=80=98sbm_freeCOD=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-mgmt.c:367:
> warning: ISO C90 forbids mixed declarations and code
>=20
> /homes/rendellf/tuxrx/nfx-tree/code/sm-icu-common/ucnv_bld.c:53:5:
> warning: "UCONFIG_NO_LEGACY_CONVERSION" is not defined
> /homes/rendellf/tuxrx/nfx-tree/code/sm-icu-common/ucnv_bld.c:63:5:
> warning: "UCONFIG_NO_LEGACY_CONVERSION" is not defined
> /homes/rendellf/tuxrx/nfx-tree/code/sm-icu-common/ucnv_bld.c:77:5:
> warning: "UCONFIG_NO_LEGACY_CONVERSION" is not defined
> /homes/rendellf/tuxrx/nfx-tree/code/sm-icu-common/ucnv_bld.c:97:6:
> warning: "UCONFIG_NO_LEGACY_CONVERSION" is not defined
> /homes/rendellf/tuxrx/nfx-tree/code/sm-icu-common/ucnv_bld.c:104:6:
> warning: "UCONFIG_NO_LEGACY_CONVERSION" is not defined
>=20
> /homes/rendellf/tuxrx/nfx-tree/code/sm-stats/kpi-api.c:699: warning:
> function declaration isn=E2=80=99t a prototype
> /homes/rendellf/tuxrx/nfx-tree/code/sm-stats/kpi-api.c: In function
> =E2=80=98kpi_init_module=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-stats/kpi-api.c:709: warning:
> implicit declaration of function =E2=80=98get_busclock=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-stats/kpi-api.c: In function
> =E2=80=98req_stats_cmd_rcv=E2=80=99:
> /homes/rendellf/tuxrx/nfx-tree/code/sm-stats/kpi-api.c:988: warning:
> implicit declaration of function =E2=80=98eee_sendMessage=E2=80=99
> /homes/rendellf/tuxrx/nfx-tree/code/sm-stats/kpi-api.c:993: warning:
> implicit declaration of function =E2=80=98printf=E2=80=99
>=20
>=20
> On Wed, 2009-08-26 at 19:22 -0600, Andrew Sharp wrote:
> > On Wed, 26 Aug 2009 19:18:51 -0600 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> >=20
> > > Actually, only 1 error with the build of your module.  I had to
> > > comment out "struct skb_pkt_desc" in nfx-tree/code/tpl/pkt.h since
> > > its already defined elsewhere.  I'm still not seeing anything
> > > compiling for your module.  The kernels build so its ready.
> >=20
> > This paragraph seems to contradict itself.
> >=20
> > > On Wed, 2009-08-26 at 18:54 -0600, Andrew Sharp wrote:
> > > > On Wed, 26 Aug 2009 18:05:45 -0600 Rendell Fong
> > > > <Rendell.Fong@lsi.com> wrote:
> > > >=20
> > > > > I have completed merging the latest linux kernel updates from
> > > > > the git trees (~andys/src/tuxrx/linux/kernel/linux-mips-2.6
> > > > > and ~bfisher/work/fisher-W1-git/ripper-git) to the tuxrx
> > > > > perforce branch. The linux kernel has been built and verified
> > > > > for both ssc and tuxrx. pinging between ssc and tuxrx works
> > > > > as well as rcon shell from the ssc. So it's ready to be
> > > > > checked in. (change #33224)
> > > > >=20
> > > > > However, I haven't been able to build the tuxrx module.  I'm
> > > > > getting numerous compile errors.=20
> > > >=20
> > > > Well, don't keep secrets, what are the compile errors?  Doesn't
> > > > sound like it's ready to check in to me ~:^)
> > >=20
>=20
