AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ed.Kwan@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	8194F90CDF4194468A47F48BF8632B38010D3163B0@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 28 Aug 2009 10:53:14 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kwan, Ed" <Ed.Kwan@lsi.com>
Subject: Re: please review code change for TED 26832 CLI: domain add with
 name 64 chars or more should return with more meaningful error message
Message-ID: <20090828105314.7e1f740c@ripper.onstor.net>
In-Reply-To: <8194F90CDF4194468A47F48BF8632B38010D3163B0@cosmail03.lsi.com>
References: <8194F90CDF4194468A47F48BF8632B38010D3163B0@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Ah, very good, you're learning!  ~:^)  Shoot me now or shoot me later.

Looks good, check 'er in!


On Fri, 28 Aug 2009 11:45:06 -0600 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:

> [edk@edk-linux ssc-nfxsh]$ p4 describe 33240
> Change 33240 by edk@edk-dev on 2009/08/28 10:42:26 *pending*
> 
>         For TED 26832 CLI: domain add with name 64 chars or more
> should return with more meaningful error message
>         In the error message, print the maximum number of characters
> allowed. Reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_domain.c#20 edit
> 
> [edk@edk-linux ssc-nfxsh]$ p4 info
> User name: edk
> Client name: edk-dev
> Client host: edk-linux.onstor.net
> Client root: /homes/edk/p4/dev
> Current directory: /homes/edk/p4/dev/nfx-tree/code/ssc-nfxsh
> Client address: 10.0.0.137:54138
> Server address: liszt.onstor.net:1717
> Server root: /p4data/p4root
> Server date: 2009/08/28 10:43:47 -0700 PDT
> Server version: P4D/LINUX26X86_64/2007.2/122958 (2007/05/23)
> Server license: ONStor 40 users (support expired 2009/05/20)
> 
> [edk@edk-linux ssc-nfxsh]$ p4 diff -dc ...
> ==== //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_domain.c#20
> - /homes/edk/p4/dev/nfx-tree/code/ssc-nfxsh/cmd_domain.c ====
> *************** *** 121,127 ****
>               *status = STATUS_SUCCESS;
>               break;
>           case STATUS_NAME_TOO_LONG:
> !             printf("Domain name too long. Name = '%s'\n",
> domainName); break;
>           case STATUS_INVALID_LEVEL:
>               printf("Invalid Security level.\
> --- 121,128 ----
>               *status = STATUS_SUCCESS;
>               break;
>           case STATUS_NAME_TOO_LONG:
> !             printf("Domain name too long (max %d characters). Name
> = '%s'\n", !                    SEC_DOMAIN_MAX - 1, domainName);
>               break;
>           case STATUS_INVALID_LEVEL:
>               printf("Invalid Security level.\
> ***************
> *** 741,747 ****
>           case STATUS_SUCCESS:
>               break;
>           case STATUS_NAME_TOO_LONG:
> !             printf("Domain name too long. Name = '%s'\n",
> domainName); break;
>           case STATUS_DOMAIN_EXISTS:
>               printf("Domain %s already exists\n", domainName);
> --- 742,749 ----
>           case STATUS_SUCCESS:
>               break;
>           case STATUS_NAME_TOO_LONG:
> !             printf("Domain name too long (max %d characters). Name
> = '%s'\n", !                    SEC_DOMAIN_MAX - 1, domainName);
>               break;
>           case STATUS_DOMAIN_EXISTS:
>               printf("Domain %s already exists\n", domainName);
> 
