AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755E250CE9E@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 28 Aug 2009 17:16:32 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: Please review Makefile change 33182
Message-ID: <20090828171632.3e2577ac@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755E250CE9E@cosmail02.lsi.com>
References: <DEC609CD0E54B2448DAF023C89AE9755E250CE9E@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 25 Aug 2009 19:17:03 -0600 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> Andy,
>     Please review this change. I know you are not happy when I do
> this but... these changes are in a workspace that is local to linux
> compile in /home/larrys/src/dev/nfx-tree. However I have this
> directory mounted on ripper in the same path so it shouldn't cause
> you any trouble reviewing the change list with the review script.
> 
> These are changes I wanted to make for a while now. Besides cleaning
> up the very weedy defs.mk file it also should make things a bit
> easier when (if) we need to build both tuxstor and eee code from the
> same branch.
> 
> Thanks,
> 
> Larry
> 
> Change 33182 by larrys@linux-compile-larrys on 2009/08/20 17:17:17
> *pending*
> 
>         Update init-local.mk
>         - Change default PROD to cg (cougar build)
>         - Add CPU macro based on TARGET (i. e. NFP_TXRX == txrx)
> 
>         Major rework of defs.mk to make it less confusing.
>         - Move macros unique to a processor type to the
> init-$(CPU).mk files
>         - Definitions for CC, CFLAGS, CPPFLAGS, DEBUG, etc are now in
> the init-$(CPU).mk files.
>         - Remove ancient references to prom macros and other obsolete
> stuff
>         - Reformatted spacing so it is easier to follow conditional
> code.
> 
>         Other changes spanning multiple files:
>         - Removed reference to NewBuildSystem
>         - Removed obsolete macros 
>         - Deleted obsolete files
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/Tools/defs.mk#25 edit
> ... //depot/dev/nfx-tree/Tools/depend.mk#1 delete
> ... //depot/dev/nfx-tree/Tools/export.mk#1 delete
> ... //depot/dev/nfx-tree/Tools/init-fc.mk#1 edit
> ... //depot/dev/nfx-tree/Tools/init-fp.mk#1 edit
> ... //depot/dev/nfx-tree/Tools/init-local.mk#3 edit
> ... //depot/dev/nfx-tree/Tools/init-mgmt.mk#1 edit
> ... //depot/dev/nfx-tree/Tools/init-ssc.mk#3 edit
> ... //depot/dev/nfx-tree/Tools/init-txrx.mk#2 edit
> ... //depot/dev/nfx-tree/Tools/lib.mk#1 delete
> ... //depot/dev/nfx-tree/Tools/module.mk#2 delete
> ... //depot/dev/nfx-tree/Tools/prog.mk#1 delete
> ... //depot/dev/nfx-tree/Tools/suffix.mk#9 edit
> ... //depot/dev/nfx-tree/target.mk#1 delete




= Change 33182 by larrys@linux-compile-larrys on 2009/08/20 17:17:17 *pending*
= 
= 	Update init-local.mk
= 	- Change default PROD to cg (cougar build)
= 	- Add CPU macro based on TARGET (i. e. NFP_TXRX == txrx)
= 	
= 	Major rework of defs.mk to make it less confusing.
= 	- Move macros unique to a processor type to the init-$(CPU).mk files
= 	- Definitions for CC, CFLAGS, CPPFLAGS, DEBUG, etc are now in the
= 	  init-$(CPU).mk files.
= 	- Remove ancient references to prom macros and other obsolete stuff
= 	- Reformatted spacing so it is easier to follow conditional code.
= 	
= 	Other changes spanning multiple files:
= 	- Removed reference to NewBuildSystem
= 	- Removed obsolete macros   <== trailing WS!
= 	- Deleted obsolete files


very cool, i like it.


nfx-tree/Tools/defs.mk

     line 74, actually, all and everything is little endian, so the
     ifeq's can go away.  i doubt we'll ever build this on a sparc.

     line 90, is there really a SSC_x86 in use?  i seriously doubt it.
     axe away.

     line 144 looks wrong to me.  why would we ever be monkeying with
     the size of long?  a recipe for disaster.  i don't see where this
     came from.

     line 152 cheetah is ancient history.  remove it from the file.
     it'll still be in the file's history.

     line 256, this is cheetah specific, so you can axe it too.
     something like

     DEBUG_FLAGS = -g

     ifneq (${TARGET}, SSC)
     	# DEBUG_FLAGS	= -g -fno-omit-frame-pointer
     	-mno-sched-prolog DEBUG_FLAGS	  = -g -fno-reorder-blocks
     	LD_DEBUG_FLAGS = -g
     endif

     line 320, more cheetah to remove

     line 471, something strange musta happened to this line...should
     just be deleted i think

nfx-tree/Tools/depend.mk


     >>delete nfx-tree/Tools/depend.mk

     sure


nfx-tree/Tools/export.mk


     >>delete nfx-tree/Tools/export.mk

     sure


nfx-tree/Tools/init-fc.mk

     looks good

nfx-tree/Tools/init-fp.mk

     looks good

nfx-tree/Tools/init-local.mk

     line 95, this is cheetah talk.  delete!

nfx-tree/Tools/init-mgmt.mk

     this file should be deleted

nfx-tree/Tools/init-ssc.mk

     looks good

nfx-tree/Tools/init-txrx.mk

     looks good

nfx-tree/Tools/lib.mk


     >>delete nfx-tree/Tools/lib.mk

     shor-nuff



nfx-tree/Tools/module.mk


     >>delete nfx-tree/Tools/module.mk

     what the?  oh, yeah, sure.



nfx-tree/Tools/prog.mk


     >>delete nfx-tree/Tools/prog.mk

     always hated this one


nfx-tree/Tools/suffix.mk

     looks good

nfx-tree/target.mk


     >>delete nfx-tree/target.mk

     always hated this one too


