AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1251846711.23744.133.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 1 Sep 2009 16:24:41 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review - 33248
Message-ID: <20090901162441.11adc29c@ripper.onstor.net>
In-Reply-To: <1251846711.23744.133.camel@rendellf>
References: <1251507960.23744.111.camel@rendellf>
	<20090831120151.27abf6b8@ripper.onstor.net>
	<1251753661.23744.123.camel@rendellf>
	<20090831174027.35dba0e1@ripper.onstor.net>
	<1251820678.23744.124.camel@rendellf>
	<20090901134922.3660af88@ripper.onstor.net>
	<1251846711.23744.133.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

looks good.  thanks.

On Tue, 1 Sep 2009 17:11:51 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> Reformatted neteee.c as explained below.
> 
> 
> On Tue, 2009-09-01 at 14:49 -0600, Andrew Sharp wrote:
> > On Tue, 1 Sep 2009 09:57:58 -0600 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> > 
> > > Yes, but I want to check in 33236 first after you review it.
> > 
> > Hmm, I can't find a review request for 33236 in my mailbox.
> > 
> > Anyway, here it goes.  Note the note at the beginning.
> > 
> > 
> > 
> > 
> > = Change 33236 by rendellf@rendellf-test on 2009/08/27 15:51:03
> > *pending* = 
> > = 	Update 1480 specific code based on recent patches already
> > in git, sibyte = 	mm file, and git files for tuxrx.  Clean
> > up old mgmt bus driver makefiles. = 
> > 
> > 
> > Since it looks like you're checking in code for both me and Billie,
> > feel free to go ahead and review it yourself as well.  Feel free to
> > pass back to Bill any necessary work to get his code into shape.
> > Specifically I'm thinking of the neteee.c file.
> > 
> > 
> > linux/kernel/linux-mips-2.6/.git/index
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/.git/info/refs
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/.git/objects/info/packs
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-2.6.22
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/arch/mips/configs/ip27_defconfig
> > 
> >      why are you changing the ip27_defconfig? that's kinda weird?
> > 
> > linux/kernel/linux-mips-2.6/arch/mips/kernel/head.S
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/arch/mips/lib/memcpy-inatomic.S
> > 
> >      oh yeah, now i remember why i modified ip27_defconfig  ~:^)
> > 
> > linux/kernel/linux-mips-2.6/arch/mips/lib/memcpy.S
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/arch/mips/mm/c-sb1.c
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/arch/mips/onstor/cougar/prom.c
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/arch/mips/pci/pci-bcm1480.c
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/arch/mips/sibyte/bcm1480/setup.c
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/drivers/Kconfig
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/drivers/Makefile
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/include/asm-mips/mach-cougar/cougar.h
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/include/asm-mips/sibyte/bcm1480_l2c.h
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/include/asm-mips/sibyte/bcm1480_regs.h
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/include/asm-mips/sibyte/sb1250_scd.h
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/include/asm/mach-tuxrx/cpu-feature-overrides.h
> > 
> >      >>add
> >      linux/kernel/linux-mips-2.6/include/asm/mach-tuxrx/cpu-feature-overrides.h
> > 
> > linux/kernel/linux-mips-2.6/include/asm/mach-tuxrx/tuxrx.h
> > 
> >      >>add
> >      >>linux/kernel/linux-mips-2.6/include/asm/mach-tuxrx/tuxrx.h
> > 
> > linux/kernel/linux-mips-2.6/include/linux/pci_ids.h
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/include/net/neteee/edesc.h
> > 
> >      looks good
> > 
> > linux/kernel/linux-mips-2.6/net/neteee/neteee.c
> > 
> >      line 361, this is apparently a broken and unneeded change to
> >      these 2 lines
> > 
> Removed use of tabs.
> 
> >      line 467-9 broken indenting
> Removed use of tabs.
> 
> > 
> >      line 577 this is debugging crap, not production crap
> > 
> Changed to NETEEE_PRINTK.
> 
> >      line 858, wth is this NETEEE_PRINTK stuff?  please use a proper
> >      macro, thank you.  ditto for all the other places it's used.
> Redefined NETEEE_PRINTK macro.
> 
> > 
> >      line 1237 broken indenting on 3 printk's
> Removed use of tabs.
> > 
> 
> >      line 1320 broken indenting
> Removed use of tabs.
> 
> > 
> >      line 1344 this would seem not to be related to sibyte-ness,
> > but to something else.  or it's TXRX or SSC, so please use
> > appropriate config variables for those guys, because otherwise this
> > just becomes another place that has to be modified yet again when we
> >      go to x86, merged SSC, etc.
> 
> Changed to CONFIG_ONSTOR_TUXRX
> 
> > 
> >      line 1427 ditto
> Changed to CONFIG_ONSTOR_TUXRX
> 
> > 
> >      line 1625 ditto
> Changed to CONFIG_ONSTOR_TUXRX
> 
> > 
> >      line 1497 broken indenting
> Removed use of tabs.
> 
> > 
> >      line 1556-7 broken indenting
> Removed use of tabs.
> > 
> >      line 1567-70 broken indenting
> Removed use of tabs.
> > 
> >      line 1584-7 broken indenting
> Removed use of tabs.
> > 
> > 
> > 
> 
