AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1252002431.23744.135.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 8 Sep 2009 11:41:59 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review - 33283
Message-ID: <20090908114159.3ff9746b@ripper.onstor.net>
In-Reply-To: <1252002431.23744.135.camel@rendellf>
References: <1252002431.23744.135.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


= Change 33283 by rendellf@rendellf-test on 2009/09/03 09:58:45 *pending*
= 
= 	Resolved many compiler warnings in nfs source files for linux.
= 	Added vs api to kernel module build.


nfx-tree/Includes/linux/typalooza.h

     this file is included in every single file.  contents have
     to be fairly universal, and this one is pretty confined to a
     small subset of files.

nfx-tree/code/Makefile.acpu

     can i get a reason why we would do this?

nfx-tree/code/sm-file/file-buf-api.c

     line 1429 i think i'd rather have this warning in there, because
     the line commented out below it has to be dealt with at some
     point, so the warning would serve as a bit of a flag for that.
     i'm not seeing right off why 1330 and 1429 are commented out in
     the first place...but i must have had some reason, which may no
     longer be true.

nfx-tree/code/sm-ipmd-lib/ipmd-lib.c

     why'z these commented out?  not immediately obvious to me.

nfx-tree/code/sm-ipmd-lib/ipmd-lib.h

     ditto

nfx-tree/code/sm-nfs/ncp-api.c

     line 1090, please, no boolean in the kernel.  booleans are for
     knuckle dragging application programmers.

nfx-tree/code/sm-nfs/nfs-audit-api.c

     looks good

nfx-tree/code/sm-nfs/nfs-conn.c

     line 1953, dang, that's weird.  good job.

nfx-tree/code/sm-nfs/nfs-dupcache.c

     looks good

nfx-tree/code/sm-nfs/nfs-module.c

     looks good

nfx-tree/code/sm-nfs/nfs-monitor-api.c

     looks good

nfx-tree/code/sm-nfs/nfs-notify-api.c

     looks good

nfx-tree/code/sm-nfs/nfs-open.c

     looks good

nfx-tree/code/sm-nfs/nfs-parse.c

     looks good

nfx-tree/code/sm-nfs/nfs-parse.h

     looks good

nfx-tree/code/sm-nfs/nfs-proc.c

     line 2285 take this lovely opportunity to eradicate another
     evil boolean

nfx-tree/code/sm-nfs/nfs-reply.c

     looks good

nfx-tree/code/sm-nfs/nfs-req-api.c

     looks good

nfx-tree/code/sm-nfs/nfs-req-api.h

     looks good

nfx-tree/code/sm-nfs/nfs-stats.c

     looks good

nfx-tree/code/sm-nfs/nfs-stats.h

     line 57, uh, ?  since when?  these need to be defined for TXRX.
     unless i'm missing something.

     line 88, again, why are these commented out?  i believe they
     are needed.  somewhere.  are they not?

nfx-tree/code/sm-nfs/nfs-string.c

     looks good

nfx-tree/code/sm-nfs/ns-api.c

     looks good

nfx-tree/code/sm-nfs/rpc.c

     looks good

nfx-tree/code/sm-open/open-api.c

     looks good

nfx-tree/code/sm-req-queue/req-test.c

     looks good

nfx-tree/code/sm-stats/kpi-api.c

     looks good

nfx-tree/code/sm-vscan/vscan-api.c

     already covered in another comment  we need to find the right
     header file for this.

nfx-tree/code/sm-vsvr/vs-api.c

     anything you change by hand from printf to printk you should make
     a proper printk, but in general, probably should just leave them.
     i believe bill has written a routine or macro for converting
     printf's to printk's, so we should just let that handle it.

     line 2139, dang, what's all this?  looks pretty fancy...what did
     you have in mind?  don't like req_execute, i take it ~:^)

     seems like you have something in mind here, so i'll just be on
     my way...not interfering or asking questions i shouldn't be...

nfx-tree/code/sm-vsvr/vs-api.h

     what. ev.  er.

nfx-tree/code/smoo-linux/bsd-dorf.c

     ok, if you say so

nfx-tree/code/smoo-linux/linux-stubs.c

     you don't have to keep this crap if you've got a better plan
     in mind.  just kill it.  no need for a macro or anything.
     unless it doesn't work for Bill or something.

nfx-tree/code/ssc-vsd/vs-ipm.h

     un, ok, sure i guess





On Thu, 3 Sep 2009 12:27:10 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> Change 33283 by rendellf@rendellf-test on 2009/09/03 09:58:45
> *pending*
> 
>         Resolved many compiler warnings in nfs source files for linux.
>         Added vs api to kernel module build.
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/Includes/linux/typalooza.h#1 edit
> ... //depot/tuxrx/nfx-tree/code/Makefile.acpu#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-file/file-buf-api.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ipmd-lib/ipmd-lib.c#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-ipmd-lib/ipmd-lib.h#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/ncp-api.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-audit-api.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-conn.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-dupcache.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-module.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-monitor-api.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-notify-api.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-open.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-parse.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-parse.h#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-proc.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-reply.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-req-api.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-req-api.h#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-stats.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-stats.h#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-string.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/ns-api.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-nfs/rpc.c#2 edit
> ... //depot/tuxrx/nfx-tree/code/sm-open/open-api.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-req-queue/req-test.c#1 edit
> ... //depot/tuxrx/nfx-tree/code/sm-stats/kpi-api.c#4 edit
> ... //depot/tuxrx/nfx-tree/code/sm-vscan/vscan-api.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-vsvr/vs-api.c#3 edit
> ... //depot/tuxrx/nfx-tree/code/sm-vsvr/vs-api.h#2 edit
> ... //depot/tuxrx/nfx-tree/code/smoo-linux/bsd-dorf.c#1 edit
> ... //depot/tuxrx/nfx-tree/code/smoo-linux/linux-stubs.c#1 edit
> ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-ipm.h#1 edit
> 
> 
> 
