AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<larry.scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 8 Sep 2009 13:56:33 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Larry Scheer <larry.scheer@lsi.com>
Subject: review of 33182
Message-ID: <20090908135633.7fcd9c9a@ripper.onstor.net>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


= Change 33182 by larrys@linux-compile-larrys on 2009/08/20 17:17:17 *pending*
= 
= 	Update init-local.mk
= 	- Change default PROD to cg (cougar build)
= 	- Add CPU macro based on TARGET (i. e. NFP_TXRX == txrx)
= 	- Remove reference to Cheetah... no longer building this product
= 	
= 	Major rework of defs.mk to make it less confusing.
= 	- Move macros unique to a processor type to the init-$(CPU).mk files
= 	- Definitions for CC, CFLAGS, CPPFLAGS, DEBUG, etc are now in the
= 	  init-$(CPU).mk files.
= 	- Remove ancient references to prom macros and other obsolete stuff
= 	- Reformatted spacing so it is easier to follow conditional code.
= 	- Remove reference to Cheetah... no longer building this product
= 	
= 	Other changes spanning multiple files:
= 	- Removed reference to NewBuildSystem
= 	- Removed Use of HOST_PLATFORM set (or not) to EVAL_BOARD
= 	- Removed Use of HOST_PLATFORM set (or not) to LINUX_TEST
= 	- Removed obsolete macros 
= 	- Deleted obsolete files
= 	- Removed Cheetah files and references
= 	
= 	Due to code changes, Cheeath product no longer builds in the dev branch
= 	so might as well eliminate references to this product line from the
= 	global definitions. Local and top level Makefiles still have references
= 	to PROD = ch. That clean up will happen later.
= 	
= 	Reviewed by: AndyS
= 

nfx-tree/Makefile.fc

     looks good

nfx-tree/Makefile.fp

     looks good

nfx-tree/Makefile.shmem

     >>delete nfx-tree/Makefile.shmem

     i never liked this file


nfx-tree/Makefile.ssc_mgmt

     >>delete nfx-tree/Makefile.ssc_mgmt

     good ridence

nfx-tree/Makefile.tmfc

     >>delete nfx-tree/Makefile.tmfc

     off with her head!


nfx-tree/Tools/defs.mk


     I'm not able to check the logic, so hopefully you've tested this
     and at least smoke-tested the resulting builds, or some useful
     subset of them.  It looks pretty good from a high level view.

nfx-tree/Tools/depend.mk



     >>delete nfx-tree/Tools/depend.mk

     sure



nfx-tree/Tools/export.mk



     >>delete nfx-tree/Tools/export.mk

     sure



nfx-tree/Tools/init-fc.mk


     looks good


nfx-tree/Tools/init-fp.mk


     looks good


nfx-tree/Tools/init-local.mk


     lookin good


nfx-tree/Tools/init-mgmt.mk





nfx-tree/Tools/init-ssc.mk


     looks good


nfx-tree/Tools/init-txrx.mk


     looks good


nfx-tree/Tools/lib.mk



     >>delete nfx-tree/Tools/lib.mk

     shor-nuff




nfx-tree/Tools/module.mk



     >>delete nfx-tree/Tools/module.mk

     what the?  oh, yeah, sure.




nfx-tree/Tools/prog.mk



     >>delete nfx-tree/Tools/prog.mk

     always hated this one



nfx-tree/Tools/suffix.mk


     looks good


nfx-tree/Tools/version-ch

     >>delete nfx-tree/Tools/version-ch

     this file always was a bastard

nfx-tree/code/sm-jmptbl/Makefile

     looks good

nfx-tree/code/sm-libc/Makefile

     looks good

nfx-tree/target.mk



     >>delete nfx-tree/target.mk

     deletion is too nice for this file!



