AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755E250CEAA@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 8 Sep 2009 14:22:48 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: please review tuxstor Makefile change 33272
Message-ID: <20090908142248.2d5eb1a8@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755E250CEAA@cosmail02.lsi.com>
References: <DEC609CD0E54B2448DAF023C89AE9755E250CEAA@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


= Change 33272 by larrys@larrys on 2009/09/01 19:05:21 *pending*
= 
= 	Add rule to create kernel .config file; this functionality was
= 	missing and needed in order to get a build to work in a brand-new
= 	workspace.
= 	
= 	Add a default VARIANT and the use of the VARIANT macro for selecting
= 	between tuxrx-debug-config and tuxrx-config.
= 	
= 	Change `pwd` to $(CURDIR) this is gnu make's built-in macro that 
= 	does the same thing but without execing a shell every time it
= 	is used.
= 	
= 	Add a more thorough clean step to return the kernel directory to
= 	an unconfigured state.
= 	
= 	Reviewed by: AndyS
= 



nfx-tree/Makefile.tuxstor

     line 30 rather than doing this, i'd just like to copy the relevant
     config file to .config.  platform should be tuxstor, not tuxrx.

     line 35 i'd rather not do a clean in there from here




On Tue, 1 Sep 2009 20:14:21 -0600 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> This one is in my Mightydog
> workspace: /homes/larrys/src/tuxrx/nfx-tree
> 
> Change 33272 by larrys@larrys on 2009/09/01 19:05:21 *pending*
> 
>         Add rule to create kernel .config file; this functionality was
>         missing and needed in order to get a build to work in a
> brand-new workspace.
> 
>         Add a default VARIANT and the use of the VARIANT macro for
> selecting between tuxrx-debug-config and tuxrx-config.
> 
>         Change `pwd` to $(CURDIR) this is gnu make's built-in macro
> that does the same thing but without execing a shell every time it
>         is used.
> 
>         Add a more thorough clean step to return the kernel directory
> to an unconfigured state.
> 
>         Reviewed by: AndyS
> 
> Affected files ...
> 
> ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#1 edit
