AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755E250CEB5@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 8 Sep 2009 16:13:22 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: please review tuxstor Makefile change 33272
Message-ID: <20090908161322.49a4dd63@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755E250CEB5@cosmail02.lsi.com>
References: <DEC609CD0E54B2448DAF023C89AE9755E250CEAA@cosmail02.lsi.com>
	<20090908142248.2d5eb1a8@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755E250CEB5@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 8 Sep 2009 16:17:55 -0600 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> My comments in line below...

> 
> nfx-tree/Makefile.tuxstor
> 
>      line 30 rather than doing this, i'd just like to copy the
> relevant config file to .config.  platform should be tuxstor, not
> tuxrx.
> >> Platform can't be set to tuxstor because no tuxstor-config or
> >> tuxstor-debug-config exits, yet. There is only tuxrx-config and
> >> tuxrx-debug-config in the kernel directory. Do you or Bill have a
> >> tuxstor-config and tuxstor-debug-config that just needs to be
> >> checked in?

nevermind then, it will be fixed by someone in a later checkin


> 
>      line 35 i'd rather not do a clean in there from here
> >> A better clean is needed than what is provided by this file. If
> >> you don't like it here I will need to provide it in some other
> >> high level Makefile.

hmm, maybe we should talk about this.  some related issues have just
floated into my mind.

can we not add this line for the sake of submitting this checkin,
and address this(these) issues with a later checkin?


> On Tue, 1 Sep 2009 20:14:21 -0600 "Scheer, Larry"
> <Larry.Scheer@lsi.com> wrote:
> 
> > This one is in my Mightydog
> > workspace: /homes/larrys/src/tuxrx/nfx-tree
> >
> > Change 33272 by larrys@larrys on 2009/09/01 19:05:21 *pending*
> >
> >         Add rule to create kernel .config file; this functionality
> > was missing and needed in order to get a build to work in a
> > brand-new workspace.
> >
> >         Add a default VARIANT and the use of the VARIANT macro for
> > selecting between tuxrx-debug-config and tuxrx-config.
> >
> >         Change `pwd` to $(CURDIR) this is gnu make's built-in macro
> > that does the same thing but without execing a shell every time it
> >         is used.
> >
> >         Add a more thorough clean step to return the kernel
> > directory to an unconfigured state.
> >
> >         Reviewed by: AndyS
> >
> > Affected files ...
> >
> > ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#1 edit
