AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755E250CEB9@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 9 Sep 2009 14:35:36 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: please review 33299
Message-ID: <20090909143536.54b96ed5@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755E250CEB9@cosmail02.lsi.com>
References: <20090908184715.09dc7965@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755E250CEB7@cosmail02.lsi.com>
	<20090909110229.76d906eb@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755E250CEB9@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 9 Sep 2009 13:40:47 -0600 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> = Change 33299 by andys@ripper on 2009/09/08 18:46:38 *pending*
> = 
> =       Integrate recent prom changes from dev branch into tuxrx
> branch. = 
> =       Reviewed by
> = 
> 
> Mention this was an integrate of all of prom
> tree //depot/prom/...@<TOP_CHANGE> I have 32907 as TOP_CHANGE in  my
> workspace.

?

> prom/cg/code/prom-pmon/memtst.c
> 
>      looks good
> 
> prom/cg/code/prom-sibyte-init/bcm1480_draminit.c
> 
>      looks good
> 
> prom/cg/code/sm-loader/load-auto.c
> 
>      looks good
> 
> prom/cg/code/sm-pmonext2fs/badblocks.c
> 
>      looks good
> 
> prom/cg/code/sm-pmonext2fs/dosio.c
> 
>      I know this is an integrate but I see that strcmp and strcpy
>      are used when strncmp and strncpy should be used instead. The
>      use of strncmp and strncpy is not consistent. I will list the
>      line numbers I see from the integrated code. Maybe this should
>      be cleaned up in the future...
> 
>      line 226 a strncmp was used one line 215 but a strcmp is used
>      here
>          line 286 strcpy used when strncpy should be used?

Yes, it's an integrate, so I would have to change it in dev first, then
integrate it to tuxrx.  But as far as I can tell by looking at the
diff, the use of strncmp v. strcmp is exactly the way I want it.  The
two aren't synonymous.

> prom/cg/code/sm-pmonext2fs/ext2fs.c
> 
>      looks good
> 
> prom/cg/code/sm-pmonext2fs/ext2fs.h
> 
>      looks good
> 
> prom/cg/code/sm-pmonext2fs/pcmcia.c
> 
>      looks good
> 
> prom/cg/code/sm-pmonext2fs/pcmciavar.h
> 
>      looks good
> 
> prom/cg/code/sm-sb1480/tlb.c
> 
>      looks good
> 
> prom/cg/code/sm-seep/env.c
> 
>      looks good
> 
> 
> ________________________________________
> From: Andrew Sharp [andy.sharp@lsi.com]
> Sent: Wednesday, September 09, 2009 11:02 AM
> To: Scheer, Larry
> Subject: Re: please review 33299
> 
> On Wed, 9 Sep 2009 11:45:51 -0600 "Scheer, Larry"
> <Larry.Scheer@lsi.com> wrote:
> 
> > What is/are the changelist being integrated from dev?
> 
> Don't have one.  Just syncing the prom tree in tuxrx with the one in
> dev.  Brian made a checkin or two to the prom directory lately, but I
> don't have an exact correlation.  cl#32907,31667.  Possibly some
> changes done by Rendell as well.
> 
> > ________________________________________
> > From: Andrew Sharp [andy.sharp@lsi.com]
> > Sent: Tuesday, September 08, 2009 6:47 PM
> > To: Scheer, Larry
> > Subject: please review 33299
> >
> > Change 33299 by andys@ripper on 2009/09/08 18:46:38 *pending*
> >
> >         Integrate recent prom changes from dev branch into tuxrx
> > branch.
> >
> >         Reviewed by
> >
> > Affected files ...
> >
> > ... //depot/tuxrx/prom/cg/code/prom-pmon/memtst.c#3 integrate
> > ... //depot/tuxrx/prom/cg/code/prom-sibyte-init/bcm1480_draminit.c#1
> > integrate ... //depot/tuxrx/prom/cg/code/sm-loader/load-auto.c#3
> > integrate ... //depot/tuxrx/prom/cg/code/sm-pmonext2fs/badblocks.c#1
> > integrate ... //depot/tuxrx/prom/cg/code/sm-pmonext2fs/dosio.c#2
> > integrate ... //depot/tuxrx/prom/cg/code/sm-pmonext2fs/ext2fs.c#2
> > integrate ... //depot/tuxrx/prom/cg/code/sm-pmonext2fs/ext2fs.h#2
> > integrate ... //depot/tuxrx/prom/cg/code/sm-pmonext2fs/pcmcia.c#2
> > integrate ... //depot/tuxrx/prom/cg/code/sm-pmonext2fs/pcmciavar.h#1
> > integrate ... //depot/tuxrx/prom/cg/code/sm-sb1480/tlb.c#2 integrate
> > ... //depot/tuxrx/prom/cg/code/sm-seep/env.c#3 integrate
> >
