AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ed.Kwan@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	8194F90CDF4194468A47F48BF8632B38010D423442@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 10 Sep 2009 16:29:07 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kwan, Ed" <Ed.Kwan@lsi.com>
Subject: Re: please review code change for TED 27280 NCM - vsvr edit page
 appears with 'autocreate vol ID'
Message-ID: <20090910162907.19630dc3@ripper.onstor.net>
In-Reply-To: <8194F90CDF4194468A47F48BF8632B38010D423442@cosmail03.lsi.com>
References: <8194F90CDF4194468A47F48BF8632B38010D422F3C@cosmail03.lsi.com>
	<20090910155239.5676ad4c@ripper.onstor.net>
	<8194F90CDF4194468A47F48BF8632B38010D423442@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

kewl

On Thu, 10 Sep 2009 17:21:01 -0600 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:

> Autocreate_vol is initialized in line 281, from the CLI output:
> 
>     277             else if(string.has(vsvr_info[i], "AutoCreate
> Vol"))
> 
>     278             {
> 
>     279                 vsvr_info[i] =
> string.trim_multi_space(vsvr_info[i]);
> 
>     280                 vsvr_info[i] = vsvr_info[i].split(": ");
> 
>     281                 var autocreate_vol = vsvr_info[i][1];
> 
>     282             }
> 
> 
> 
> AutoCreate Path and AutoCreate VolID are both "-Not-Set-" by default:
> 
> seng236 diag> vsvr show eng236vs1
> 
> Virtual Server
> 
> ==============
> 
> ID                : 2 (protected)
> 
> NAS Gateway name  : eng236
> 
> Status            : Enabled
> 
> Name              : ENG236VS1
> 
> NetBIOS name      : ENG236VS1
> 
> Pri. WinSrvr IP   : 0.0.0.0
> 
> Sec. WinSrvr IP   : 0.0.0.0
> 
> IP address 1      : 10.3.236.100/255.255.0.0
> 
> Windows domain    : MATRIX
> 
> Unix domain       : --Not-Set--
> 
> LDAP domain       : openauthdom
> 
> AutoCreate Path   : --Not-Set--
> 
> AutoCreate VolID  : --Not-Set--
> 
> Volumes owned     : edvol1
> 
> Volumes mounted   : edvol1
> 
> Read responses fragmentation  : default
> 
> UDP checksum enabled          : yes
> 
> Maximum mpx count             : 78
> 
> Strict name checking          : Enabled
> 
> 
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com]
> Sent: Thursday, September 10, 2009 3:53 PM
> To: Kwan, Ed
> Subject: Re: please review code change for TED 27280 NCM - vsvr edit
> page appears with 'autocreate vol ID'
> 
> 
> 
> 
> 
> = Change 33303 by edk@edk-dev on 2009/09/09 10:43:55 *pending*
> 
> =
> 
> =     For TED 27280 NCM - vsvr edit page appears with 'autocreate vol
> ID'
> 
> =     drop down filled in
> 
> =     Add ""--Not-Set--" in the "Autocreate Vol ID" pull down menu.
> 
> =     It will be the default if "Autocreate Path" is "--Not-Set--".
> 
> =     Reviewed by ??
> 
> =
> 
> 
> 
> nfx-tree/code/ssc-webui/js/vsvr/edit.js
> 
> 
> 
>      line 344 keep in mind, i have no idea, but how does
> autocreate_vol
> 
>      get set to "--Not-set--" in the first place for this test to
> 
>      succeed?
> 
> 
> 
> 
> 
> 
> 
> 
> 
> On Wed, 9 Sep 2009 11:45:27 -0600 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:
> 
> 
> 
> > [edk@edk-linux vsvr]$ p4 info
> 
> > User name: edk
> 
> > Client name: edk-dev
> 
> > Client host: edk-linux.onstor.net
> 
> > Client root: /homes/edk/p4/dev
> 
> > Current directory: /homes/edk/p4/dev/nfx-tree/code/ssc-webui/js/vsvr
> 
> > Client address: 10.0.0.137:40560
> 
> > Server address: liszt.onstor.net:1717
> 
> > Server root: /p4data/p4root
> 
> > Server date: 2009/09/09 10:44:50 -0700 PDT
> 
> > Server version: P4D/LINUX26X86_64/2007.2/122958 (2007/05/23)
> 
> > Server license: ONStor 40 users (support expired 2009/05/20)
> 
> >
> 
> >
> 
> > [edk@edk-linux vsvr]$ p4 describe 33303
> 
> > Change 33303 by edk@edk-dev on 2009/09/09 10:43:55 *pending*
> 
> >
> 
> >         For TED 27280 NCM - vsvr edit page appears with 'autocreate
> 
> > vol ID' drop down filled in
> 
> >         Add ""--Not-Set--" in the "Autocreate Vol ID" pull down
> > menu.
> 
> >         It will be the default if "Autocreate Path" is
> > "--Not-Set--".
> 
> >         Reviewed by ??
> 
> >
> 
> > Affected files ...
> 
> >
> 
> > ... //depot/dev/nfx-tree/code/ssc-webui/js/vsvr/edit.js#14 edit
> 
> >
> 
> >
> 
> > [edk@edk-linux vsvr]$ p4 diff ...
> 
> > ==== //depot/dev/nfx-tree/code/ssc-webui/js/vsvr/edit.js#14
> 
> > - /homes/edk/p4/dev/nfx-tree/code/ssc-webui/js/vsvr/edit.js ====
> 
> > 239a240
> 
> > >         var nvols = 0;
> 
> > 323a325
> 
> > >                 nvols = j - 3;
> 
> > 340a343,356
> 
> > >         } else {
> 
> > >             if (autocreate_vol == "--Not-Set--") {
> 
> > >                 vol_ids[nvols+2] =
> 
> > > {option:{jsonattr:{selected:"selected", "value":"- Select -",
> 
> > >                                                       "title":"--Not-Set--",
> 
> > >                                                       "style":"width:120px;"},
> 
> > >                                             jsontext:"--Not-Set--"}};
> 
> > >             } else {
> 
> > >                 vol_ids[nvols+2] = {option:{jsonattr:{
> 
> > >                                                       "value":"-
> 
> > > Select -", "title":"--Not-Set--",
> 
> > >                                                       "style":"width:120px;"},
> 
> > >                                             jsontext:"--Not-Set--"}};
> 
> > >             }
