AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1252956190.23744.163.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 14 Sep 2009 13:44:40 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review 33315
Message-ID: <20090914134440.6eec1c71@ripper.onstor.net>
In-Reply-To: <1252956190.23744.163.camel@rendellf>
References: <20090911112930.08064c84@ripper.onstor.net>
	<1252720000.23744.157.camel@rendellf>
	<20090914102038.5fe91a3a@ripper.onstor.net>
	<1252956190.23744.163.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 14 Sep 2009 13:23:10 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> Oh, you want me to review the changes.
> 
> ... //depot/dev/nfx-tree/code/sm-prom-upgrade/from-ui.c#2 edit
> 166: update comments

fixed

> ... //depot/dev/nfx-tree/code/sm-seep/env.c#15 edit
> ok
> 
> WRT your question:
> > One question, does this code work properly with the old PROM ?
> 
> I don't know, I assume you have tested it.

Aaaahahahahahahahaha; man, that was funny.

I wouldn't even have the slightest idea.  I've got severe doubts that
this code (sm-prom-upgrade/from-ui.c) is even compiled into the product
anywhere.  And the chassis program, well, I don't have the old prom, I
don't have our current product (ssc, txrx, fp) installed or runnable
anywhere as my setup is tuxrx/stor specific nowadays.  I'm happy to do
the testing if you know of a system I can use.  Maybe I'll ask Larry.
Yeah, he must have a system I can try it on.  I'll ask Larry.


> On Mon, 2009-09-14 at 11:20 -0600, Andrew Sharp wrote:
> > On Fri, 11 Sep 2009 19:46:40 -0600 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> > 
> > > Yes, its just that the new autoload name that is displayed doesn't
> > > match.
> > 
> > Er, uh, no, or something.  What I meant was THIS code, ie, the code
> > that you are also reviewing.  You know, in this code review?
> > 
> > 
> > > On Fri, 2009-09-11 at 12:29 -0600, Andrew Sharp wrote:
> > > > Hi Rendell,
> > > > 
> > > > One question, does this code work properly with the old
> > > > PROM?
> > > > 
> > > > 
> > > > 
> > > > Change 33315 by andys@ripper on 2009/09/10 14:50:43 *pending*
> > > > 
> > > > 	TED00027241 - chassis view env with version 2. prom
> > > > displays incorrect autoload setting
> > > > 	
> > > > 	Third value changed it's name from old to user.  Fix it.
> > > > 	
> > > > 	reviewed by
> > > > 
> > > > Affected files ...
> > > > 
> > > > ... //depot/dev/nfx-tree/code/sm-prom-upgrade/from-ui.c#2 edit
> > > > ... //depot/dev/nfx-tree/code/sm-seep/env.c#15 edit
> > > 
> 
