AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	5135	1253057141.23744.181.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 15 Sep 2009 18:15:42 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: Please review fix for kernel module build, change # 33342
Message-ID: <20090915181542.7fdbc90e@ripper.onstor.net>
In-Reply-To: <1253057141.23744.181.camel@rendellf>
References: <DEC609CD0E54B2448DAF023C89AE9755E250CED0@cosmail02.lsi.com>
 <20090915155026.3e9256ca@ripper.onstor.net>
 <1253057141.23744.181.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

In that case I'll just tell Larry to submit his changelist, because he
did it the right way.  Heh.  I kid.  Check your default changelist, I
think you'll find you already did a p4 delete on the files in
asm/mach-tuxrx, which is why it seems they aren't there ~:^)

On Tue, 15 Sep 2009 17:25:41 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> I checked out the 2 asm-mips/mach-tuxrx include files from the git
> tree. They are missing in perforce.  So this change is to add them in.
> No git changes required since it is up to date.
> 
> 
> Change 33343 by rendellf@rendellf-test on 2009/09/15 16:05:57
> *pending*
> 
>         Add some missing asm-mips include files for tuxrx.
> 
> Affected files ...
> 
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-
> tuxrx/cpu-feature-overrides.h#1 add
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-
> tuxrx/tuxrx.h#1 add
> 
> 
> On Tue, 2009-09-15 at 16:50 -0600, Andrew Sharp wrote:
> > Actually, let's throw this over to Rendell since the git repository
> > also has to be fixed.  Rendell, if this was my mistake, throw it
> > back over to me.
> > 
> > Thanks,
> > 
> > a
> > 
> > 
> > On Tue, 15 Sep 2009 16:31:58 -0600 "Scheer, Larry"
> > <Larry.Scheer@lsi.com> wrote:
> > 
> > > Change 33342 updated.
> > > [lscheer@larrys kernel]$ p4 describe -s 33342
> > > Change 33342 by larrys@larrys on 2009/09/15 15:27:07 *pending*
> > > 
> > >         Fix kernel module build problem: CALL
> > > scripts/checksyscalls.sh failed. asm headers files are missing. 
> > > 
> > >         Move tuxrx.h and cpu-feature-overrides.h from:
> > >         include/asm/mach-tuxrx
> > >         to:
> > >         include/asm-mips/mach-tuxrx
> > > 
> > >         The include/asm directory is supposed to be a link
> > > created by the kernel build.
> > >         Reviewed by: AndyS
> > > 
> > > Affected files ...
> > > 
> > > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxrx/cpu-feature-overrides.h#1
> > > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxrx/tuxrx.h#1
> > > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm/mach-tuxrx/cpu-feature-overrides.h#1
> > > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm/mach-tuxrx/tuxrx.h#1
> > > delete
> 
