AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ed.Kwan@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	8194F90CDF4194468A47F48BF8632B38010D518E94@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 23 Sep 2009 12:05:46 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kwan, Ed" <Ed.Kwan@lsi.com>
Subject: Re: please review code change for TED 27446 incorrect error message
 when trying to delete an invalid vscan server
Message-ID: <20090923120546.4e6e3647@ripper.onstor.net>
In-Reply-To: <8194F90CDF4194468A47F48BF8632B38010D518E94@cosmail03.lsi.com>
References: <8194F90CDF4194468A47F48BF8632B38010D518E94@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 22 Sep 2009 17:19:23 -0600 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:

> Change 33385



= Change 33385 by edk@edk-dev on 2009/09/22 16:19:08 *pending*
= 
= 	For TED 27446 incorrect error message when trying to delete an invalid vscan server
= 	Check if we have a ClusterDB record of a vscan scan server that 
= 	matches the IP address specified in the command line.  If not,
= 	print an error message.
= 	Reviewed by  ??
= 

nfx-tree/code/ssc-nfxsh/cmd_vscan.c

     line 333: style: operators should always be surrounded by a space,
     so i=0 should be i = 0;

     line 1554, i'm not sure this nfxauth_resolvName() stuff is valid,
     but that's the way it was before, so nevermind.



nfx-tree/test/t/all/features/vscan/003_delete.t

     >>add nfx-tree/test/t/all/features/vscan/003_delete.t

     line 31, 37 tw

     i hope this is OK, since my perl SUCKS.  if you have any doubts,
     run it by jan.

