AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1255460232.20354.26.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 13 Oct 2009 13:15:47 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review - 33341
Message-ID: <20091013131547.551446a7@ripper.onstor.net>
In-Reply-To: <1255460232.20354.26.camel@rendellf>
References: <1254339658.14287.90.camel@rendellf>
	<20091012170109.4e7b8a73@ripper.onstor.net>
	<1255460232.20354.26.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 13 Oct 2009 12:57:12 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> On Mon, 2009-10-12 at 18:01 -0600, Andrew Sharp wrote:
> > On Wed, 30 Sep 2009 13:40:58 -0600 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> >
> > > Change 33341 by rendellf@rendellf-test on 2009/09/15 15:19:30
> > > *pending*
> > >
> > >         Fixed kernel module compile warnings for tuxrx.
> > >
> > > Affected files ...
> > >
> > > ... //depot/tuxrx/nfx-tree/code/neteee2/eee-timer-api.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/neteee2/eee-timer-api.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-appids/onstor.apps#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-audit/audit.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-authorization/auth-rpc-cmd.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-authorization/author-cifs.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-authorization/author-cmd.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-authorization/author-sec.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-authorization/author-ssc.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-authorization/author-stats.h#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-authorization/author.c#4
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-authorization/author.h#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs-rpc/cifs-pipe-ssc.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs-rpc/cifs-rpc-ed-srvsvc.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs-rpc/cifs-rpc-srvsvc.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs-rpc/cifs-rpc-winreg.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs-rpc/cifs-rpc.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs-rpc/pipe-api.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-brlock.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-conn.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-csn.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-ctc.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-delete.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-echo.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-find-close2.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-flush.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-ioctl.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-kerb.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-logoff.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-negotiate.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-nt-notify-change.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-read-write.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-req.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-search.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-security.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-seek.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-sess-setup.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-smb-attributes.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-smb-common.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-smb-linkrename.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-smb-ntcancel.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-smb-open.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-tcon.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-tdcon.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-trans-common.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-trans-rap.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-trans-util.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-transact-nmpipe.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-cifs/cs-api.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cs-msg.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-api.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-commit.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-display.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-hash.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-inlines.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-invalidate.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-read.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-readahead.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-rx.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-search.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-util.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dp-proxy/dp-proxy.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-event/event-mgr.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-file/file-lib.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-rpc-api.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-gns/gns-api.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-hash/hash-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-hash/hash.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-hash/hash.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-lock/lock-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-lock/lock-debug.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-lock/lock-mem.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-lock/lock.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-netbios/nb-ns.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-netbios/nb-ss.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-netbios/nb-util.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-notify/notify-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-open/fcb-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-open/fns-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-open/ofh-api.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-open/ofh-api.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-open/symlink.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-open/vcb-api.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-oplock/oplock-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-oplock/oplock-cmd.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-queue/queue.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-req-queue/make-req-tbl.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-req-queue/req-queue-api.h#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-req-queue/req-utils-api.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-mgmt.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-test.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-txrx.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sbm-rev2/sbm-verify.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-search/search-api.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-stats/kpi-lib.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-stats/stats-txrx.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-stats/stats.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ui/commands.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-utils/fs-rpc-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-utils/txrx-utils-api.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-utils/utils-fs.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-daemon.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-msg.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-util.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-x86-tests/deleteautocreatetest.c#3
> > > edit
> >
> >
> >
> > = Change 33341 by rendellf@rendellf-test on 2009/09/15 15:19:30
> > *pending* =
> > =       Fixed kernel module compile warnings for tuxrx.
> > =
> >
> >
> >
> > nfx-tree/code/neteee2/eee-timer-api.c
> >
> >      line 29, well, if it should be const, should it be static too?
> >
> done
> 
> >      line 459, why do we need humandate?, line 486 too
> >
> >      This appears to only be needed for crashdump, can't we just
> >      write the binary date value in the crash dump and figure it out
> >      in userspace?  Where there are library routines for this that
> >      don't suck?
> >
> >      i notice that eee_humandate is used in a lot of code.  but it
> >      should be eliminated, as printk will add and log the proper
> > time, with timezone computed for extra clarity.
> >
> >      well, there are a few places in the fs-code, which we don't
> > care about.  otherwise the only important users are this crashdump
> >      used routine.
> >
> Ok, removed it. Also, changed eee_rtcStr refs in sm-lock/lock-debug.c
> 
> 
> > nfx-tree/code/neteee2/eee-timer-api.h
> >
> >      line 74 why isn't this generic if it has to be defined in both
> >      user space and kernel space?  put another way, it should be
> >      defined in some general place, maybe nfx-types.h or something
> >      horrible like that.
> done
> 
> >
> >      line 573 we seriously have to get rid of humandate.  we don't
> >      need it in the kernel, and a C library routine, like
> > localtime() or something should be used.
> >
> done
> >
> >
> > nfx-tree/code/sm-appids/onstor.apps
> >
> >      looks good
> >
> > nfx-tree/code/sm-audit/audit.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-authorization/auth-rpc-cmd.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-authorization/author-cifs.c
> >
> >      line 3834, ok, i have to ask, what is ACCESS_ALLOWED_ACE?
> >      besides about 100 different coding violations? ~:^)
> >
> Looks like a data struct defined in a Microsoft header file.
> My guess is it was never redefined based on our coding stds.
> 
> >
> >
> > nfx-tree/code/sm-authorization/author-cmd.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-authorization/author-sec.c
> >
> >      line 883 normally wouldn't put a space after (void) unless
> > there was one there already
> >
> removed the space.
> 
> >      line 2806 ditto
> ditto
> 
> >
> > nfx-tree/code/sm-authorization/author-ssc.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-authorization/author-stats.h
> >
> >      good job with a (*&^*&%#*&* situation
> >
> > nfx-tree/code/sm-authorization/author.c
> >
> >      line 4452, is that tws?
> removed it.
> 
> >
> > nfx-tree/code/sm-authorization/author.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs-rpc/cifs-pipe-ssc.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs-rpc/cifs-rpc-ed-srvsvc.c
> >
> >      line 820, that's quite possibly the dumbest piece of code i've
> >      ever seen.  i'm just sayin'
> >
> Yep, I don't even want to think about it.
> 
> >
> >
> > nfx-tree/code/sm-cifs-rpc/cifs-rpc-srvsvc.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs-rpc/cifs-rpc-winreg.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs-rpc/cifs-rpc.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs-rpc/pipe-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-brlock.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-conn.c
> >
> >      line 725, actually should just leave this, as the inet_ntoa is
> >      a shitty hack that will be the death of us all.
> >
> ok, if you say so.  Use of signed char/int values may be a problem
> here.
> 
> > nfx-tree/code/sm-cifs/cifs-csn.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-ctc.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-delete.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-echo.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-find-close2.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-flush.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-ioctl.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-kerb.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-logoff.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-negotiate.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-nt-notify-change.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-read-write.c
> >
> >      line 2591 looks like we can get rid of even one more paren set
> >
> done
> 
> > nfx-tree/code/sm-cifs/cifs-req.c
> >
> >      line 88-93 get rid of it, it just pollutes searches
> >
> >      line 1415 - 1426 ditto
> >
> >      line 2314 - 2320 ditto
> >
> >      line 2343 - 2347 ditto
> >
> >      line 2369 - 2379 ditto
> >
> done
> 
> > nfx-tree/code/sm-cifs/cifs-search.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-security.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-seek.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-sess-setup.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-smb-attributes.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-smb-common.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-smb-linkrename.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-smb-ntcancel.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-smb-open.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-tcon.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-tdcon.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-trans-common.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-trans-rap.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-trans-util.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-transact-nmpipe.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cs-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cs-msg.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-dcache/dcache-api.c
> >
> >      line 2684 this has to be resolved. leave it a warning if need
> > be. is the problem sbm_cod_valid()?
> 
> No, it's eee_desc_rele. eee_desc_rele may be going away. This api
> doesn't exist right now.

I'm worried that we will lose track of this.  Whatever.

> > nfx-tree/code/sm-dcache/dcache-commit.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-dcache/dcache-display.c
> >
> >      line 438 what's the problem leaving this in?
> 
> You ifdef'd out the only code that used to reference these routines.
> So warnings are generated about the code being defined but not used.
> No harm in also ifdef'ing them out as well because its as good as
> dead.

Never mind then.

> >
> > nfx-tree/code/sm-dcache/dcache-hash.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-dcache/dcache-inlines.h
> >
> >      line 184 again with the ifdef LATER.  what's that about?
> 
> eee_desc_rele may be going away.  This api doesn't exist right now.
> 
> >
> > nfx-tree/code/sm-dcache/dcache-invalidate.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-dcache/dcache-read.c
> >
> >      line 143 i'm not seeing the necessity of this, eee_desc_rele
> >      should be defined somewhere, even if it's defined as a nop
> >
> eee_desc_rele may be going away.  This api doesn't exist right now.
> 
> >
> >
> > nfx-tree/code/sm-dcache/dcache-readahead.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-dcache/dcache-rx.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-dcache/dcache-search.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-dcache/dcache-util.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-dp-proxy/dp-proxy.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-event/event-mgr.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-fs/fs-rpc-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-gns/gns-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-hash/hash-api.c
> >
> >      line 60, 66 it should return the correct type, rather than
> >      casting NULL.  return 0 or something.
> >
> I disagree.  It's being cast like the last non-null return value at
> the end.  It is more consistent this way.

But the function returns address_t which is an unsigned int of some
size, so you should return a 0.  You have to cast htp when returning it
because it's a real address.

> > nfx-tree/code/sm-hash/hash.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-hash/hash.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/unicode/icu_wrappers.h
> >
> >      line 16, this shouldn't be necessary.  perhaps just #include
> >      <stdlib.h> or whatever
> malloc-api.h is needed for declaration of eee_ramAlloc and
> eee_ramDealloc.  stdlib.h doesn't cut it.

What I meant was can we macro-ize the eeeramalloc to be just a call to
malloc and whatnot?  I think in userspace that's all it's doing anyway,
if I'm not mistaken.  Nevermind, just leave it.

> > nfx-tree/code/sm-lock/lock-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-lock/lock-debug.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-lock/lock-mem.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-lock/lock.c
> >
> >      line 237 put an ifdef TIMER_TIC_MS ... endif around the undef
> >
> done
> 
> > nfx-tree/code/sm-netbios/nb-ns.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-netbios/nb-ss.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-netbios/nb-util.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-notify/notify-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-open/fcb-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-open/fns-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-open/ofh-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-open/ofh-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-open/symlink.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-open/vcb-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-oplock/oplock-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-oplock/oplock-cmd.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-queue/queue.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-req-queue/make-req-tbl.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-req-queue/req-queue-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-req-queue/req-utils-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sbm-rev2/sbm-mgmt.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sbm-rev2/sbm-test.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sbm-rev2/sbm-txrx.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sbm-rev2/sbm-verify.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-search/search-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-stats/kpi-lib.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-stats/stats-txrx.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-stats/stats.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-ui/commands.c
> >
> >      line 2687 axe the humandatefromhell call
> 
> The do_gmttime commands has been ifdef'd out.
> Corresponding changes made in cmdtable.c and uihdr.h.
> 
> >
> > nfx-tree/code/sm-utils/fs-rpc-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-utils/txrx-utils-api.c
> >
> >      line 5682 what's wrong with this code?
> >
> The code is ifdef'd the same way the only ref to it was ifdef'd out in
> your change #33154.

well ok then ~:^)

> > nfx-tree/code/sm-utils/utils-fs.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vsd/vs-daemon.c
> >
> >      line 3138 this looks a little fishy
> >
> >      line 3321 ditto
> 
> This is temporarily until the module can be tested which means we need
> to be able to load the module.  It will also be eventually replaced by
> rpdb api code.

OK, that makes sense.  I just didn't quite get what was going on there.

> >
> > nfx-tree/code/ssc-vsd/vs-msg.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vsd/vs-util.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-x86-tests/deleteautocreatetest.c
> >
> >      looks good
> >
> 
