AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<bill.fisher@lsi.com>,<Maxim.Kozlovsky@lsi.com>,<Rendell.Fong@lsi.com>,<brian.stark@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	4ACFDBE1.2020509@lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 19 Oct 2009 19:51:15 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: William Fisher <bill.fisher@lsi.com>
Cc: "Kozlovsky, Maxim" <Maxim.Kozlovsky@lsi.com>, "Fong, Rendell"
 <Rendell.Fong@lsi.com>
Bcc: Brian Stark <brian.stark@lsi.com>
Subject: Re: Notice Prior to Adding tpl, netee2 and neteee-ui back to kernel
Message-ID: <20091019195115.47968beb@ripper.onstor.net>
In-Reply-To: <4ACFDBE1.2020509@lsi.com>
References: <4ACFDBE1.2020509@lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Review comments at the end.

On Fri, 9 Oct 2009 18:57:05 -0600 William Fisher <bill.fisher@lsi.com>
wrote:

> 
> bfisher-linux: 828>p4 change
> Change 33512 created with 76 open file(s).
> bfisher-linux: 829>echo $P4CLIENT
> fisher-tuxstor
> 
> Below is the code which supports the tpl, neteee2 (EEE os API)
> and the rcon shell neteee-ui directories back to the kernel
> perforce tree.
> 
>   Complain now or it get's submitted monday.
> 
> -- Bill
> 
> 
> bfisher-linux: 826>p4 opened ...
> //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/mm/c-sb1.c#1 -
> edit //depot/tuxrx/linux/kernel/linux-mips-2.6/include/net/neteee/edesc.h#1
> - edit default change (xtext)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/include/net/sock.h#2 - edit 
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/Kconfig#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/Makefile#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/argvize.c#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/cli.c#2 - add 
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/cmdtable.c#2
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/commands.c#2
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/eee-simple-test.c#2 
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/eee-simple-test.h#2 
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/eee-test-both.c#2 
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/eraline.c#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/getword.c#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/help.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/hist.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/more.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/pmon-ui.h#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/queue-api.c#2
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/queue-api.h#2
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/queue-error.h#2 
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/queue.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/queue.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/rcon-shell.c#2
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/rcon-shell.h#2
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/sbm-commands.c#2 
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/strlib.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/strlib.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/strlibc.h#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee-ui/uihdr.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/Kconfig#2 - add 
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/Makefile#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-api.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-app.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-app.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-debug.c#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-desc.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-drv.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-drv.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-error.h#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-fwd-test.c#2
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-fwd.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-fwd.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-ipc.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-ipc.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-mem.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-mem.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-msg.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-platform.c#2
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-platform.h#2
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-queue.c#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-queue.h#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-rcon.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-test.c#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-test.h#2 -
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-timer-api-test.c#2 
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-timer-api.c#2 
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-timer-api.h#2 
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.h#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee-utils.c#2 - 
> add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/eee.h#2 - add 
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee2/req-queue-struct.h#2 
> - add default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/Makefile#1 - edit 
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/pkt-queue-api.c#1 - 
> edit default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/pkt-queue-api.h#1 - 
> edit default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/pkt.c#1 - edit
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/tpl-api.h#1 - edit 
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/tpl-ipc.c#1 - edit 
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/tpl-msg.c#1 - edit 
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/tpl-rcv.c#1 - edit 
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/tpl-utils.c#1 -
> edit default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/tpl.c#1 - edit
> default change (text)
> //depot/tuxrx/linux/kernel/linux-mips-2.6/net/tpl/tpl.h#1 - edit
> default change (text)

OK, there's some big stuff in here, which we can sit down and talk
about, and you can fix the little stuff and get some of the changes
needed from the nfx-tree versions of files, and that's enough to get
you going for the moment.  You'll notice the "placeholder" comment in a
couple of places, that's because I haven't had a chance to look at
these files yet because that's a little less important.


= Change 33512 by bfisher@fisher-tuxstor on 2009/10/09 17:53:24 *pending*
= 
= 	Add to the kernel's net directory the following new ones; tpl, neteee2 and neteee-ui
= 
	Some comments, not too much, on the tpl stuff might be appropriate.


Please read the individual comments per file.

You will need to do a p4 delete on files in the nfx-tree that files in
this changelist replace, as the module needs to build[-ish] as well
as the kernel.  By build-ish I would say 95% or more.  More is better.

linux/kernel/linux-mips-2.6/include/net/neteee/edesc.h

     placeholder

linux/kernel/linux-mips-2.6/net/neteee-ui/Kconfig

     placeholder

linux/kernel/linux-mips-2.6/net/neteee-ui/Makefile

     placeholder

linux/kernel/linux-mips-2.6/net/neteee-ui/argvize.c

     line 13, we really need to do something with this broken include
     style.  I think we can make that a follow on changelist, but it has
     to be immediate follow on, or in this changelist.  there exists an
     onstor directory in the kernel standard include path so just use
     that as needed.  ask me if have a question on how we should do it.

     line 28, 30 please don't use char8 in the kernel, it's idiotic
     anyway, chars are always 8 unless otherwise declared.  just use
     plain old char.  this code is not going to be compatible with
     eee compilation ever anyway....

linux/kernel/linux-mips-2.6/net/neteee-ui/cli.c

     looks ok

linux/kernel/linux-mips-2.6/net/neteee-ui/cmdtable.c

     looks ok

linux/kernel/linux-mips-2.6/net/neteee-ui/commands.c

     line 13, you don't need even half these header files,
     i'm guessing.  please include only the bare minimum and
     let the others get pulled in by the ones you do include.
     i believe there's a helper program in scripts/ directory
     for weeding out/in header files.

linux/kernel/linux-mips-2.6/net/neteee-ui/eee-simple-test.c

     line 57 tws (trailing white space)

linux/kernel/linux-mips-2.6/net/neteee-ui/eee-simple-test.h

     looks good

linux/kernel/linux-mips-2.6/net/neteee-ui/eee-test-both.c

     placeholder

linux/kernel/linux-mips-2.6/net/neteee-ui/eraline.c

     line 7 please cut down on the redundant header files included
     in all these files.  kernel.h pulls in types.h, you couldn't
     possibly need socket.h, and so forth.  i don't think you need
     any of these for this file.  i can't see anything that needs an
     external header file except `char8', which you are going to fix.

linux/kernel/linux-mips-2.6/net/neteee-ui/getword.c

     both types.h and kernel.h never need to both be in the same file

linux/kernel/linux-mips-2.6/net/neteee-ui/help.c

     except for the char8, look ok-ish

linux/kernel/linux-mips-2.6/net/neteee-ui/hist.c

     char8, etc.

linux/kernel/linux-mips-2.6/net/neteee-ui/more.c

     char8, etc.

linux/kernel/linux-mips-2.6/net/neteee-ui/pmon-ui.h

     ditto

linux/kernel/linux-mips-2.6/net/neteee-ui/queue-api.c

     these next four queue files totally do not belong here,
     you know that.  these should be left in nfx-tree/sm-queue

linux/kernel/linux-mips-2.6/net/neteee-ui/queue-api.h

     ditto

linux/kernel/linux-mips-2.6/net/neteee-ui/queue-error.h

     ditto

linux/kernel/linux-mips-2.6/net/neteee-ui/queue.c

     ditto

linux/kernel/linux-mips-2.6/net/neteee-ui/queue.h

     ditto

linux/kernel/linux-mips-2.6/net/neteee-ui/rcon-shell.c

     char8

     about 1/3 of these header includes are necessary, please pare
     them down

     line 81, this is an extern, defined elsewhere in the module, please
     do not define it here, sorry.  see rcon-shell.c in the nfx-tree.

linux/kernel/linux-mips-2.6/net/neteee-ui/rcon-shell.h

     ok

linux/kernel/linux-mips-2.6/net/neteee-ui/sbm-commands.c

     placeholder

linux/kernel/linux-mips-2.6/net/neteee-ui/strlib.c

     line 952, remove strtol function, there is one in the kernel,
     use xlation macro ala the nfx-tree module build

linux/kernel/linux-mips-2.6/net/neteee-ui/strlib.h

     headers, char8

linux/kernel/linux-mips-2.6/net/neteee-ui/strlibc.h

     placeholder

linux/kernel/linux-mips-2.6/net/neteee-ui/uihdr.h

     line 10, get rid of the unused__ crap, please.  thanks.  yes,
     i know you didn't put it in there.

linux/kernel/linux-mips-2.6/net/neteee2/eee-api.h

     looks doubtful.  half the frigging nfx-tree needs this file. at
     least, that's the way i remember it.

linux/kernel/linux-mips-2.6/net/neteee2/eee-app.c

     the usual header spam, slab.h pulls in gfp.h, for crying out load.

     line 200 and 211, please pull in the changes from nfx-tree version
     of this file

     line 234, et al,  ditto

     in general, please include the changes from the file in
     nfx-tree, as I've said you must do.  you can either do an 'p4
     integrate/delete' to move them over, then edit them, or do it
     by hand.  i would do the integrate/delete, as that would probably
     be easiest.

linux/kernel/linux-mips-2.6/net/neteee2/eee-app.h

     ok

linux/kernel/linux-mips-2.6/net/neteee2/eee-desc.c

     please pick up the changes from the nfx-tree

linux/kernel/linux-mips-2.6/net/neteee2/eee-drv.c

     there's no reason to be including this file, we need nothing in it.
     that's why it's not in the nfx-tree compile.

linux/kernel/linux-mips-2.6/net/neteee2/eee-drv.h

     a) there's no reason to change this file from the unchanged one
     in nfx-tree b) i'm pretty positive that mucho files in nfx-tree
     need this header - possibly some of the #defines can be moved to
     some other header where they can get them, but then you have the
     sharing problem.

linux/kernel/linux-mips-2.6/net/neteee2/eee-error.h

     again, there's no reason for any of these changes.  and it's
     needed by many nfx-tree files.  i don't see how this can live here.

linux/kernel/linux-mips-2.6/net/neteee2/eee-fwd.c

     placeholder

linux/kernel/linux-mips-2.6/net/neteee2/eee-fwd.h

     ok

linux/kernel/linux-mips-2.6/net/neteee2/eee-init.c

     again, i don't see how this should be here, it needs to be in
     the module.  it's not relevant to the protocols or any of that.

linux/kernel/linux-mips-2.6/net/neteee2/eee-ipc.c

     please pick up the printk fixes from the nfx-tree version

linux/kernel/linux-mips-2.6/net/neteee2/eee-ipc.h

     looks good

linux/kernel/linux-mips-2.6/net/neteee2/eee-mem.c

     there's absolutely no point in this, it contains nothing.

linux/kernel/linux-mips-2.6/net/neteee2/eee-mem.h

     looks good

linux/kernel/linux-mips-2.6/net/neteee2/eee-msg.c

     looks good

linux/kernel/linux-mips-2.6/net/neteee2/eee-platform.c

     also no point in this file, we're not taking anything in here.

linux/kernel/linux-mips-2.6/net/neteee2/eee-platform.h

     looks ok

linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.c

     eee-poll doesn't belong in the kernel, it belongs in the individual
     modules.  it doesn't have anything to do with these protocols.

     line 56 nope, NFX_SMP should not be defined for TXRX.  in general,
     this will have to be a separate function for FP and TXRX, so
     leave it in nfx-tree.

linux/kernel/linux-mips-2.6/net/neteee2/eee-poll.h

     i don't see a reason for this to be here.  and no booleans in
     the kernel.  check the nfx-tree version.

linux/kernel/linux-mips-2.6/net/neteee2/eee-queue.c

     i'm pretty sure this shouldn't be here, but if it does, you will
     need to pick up the changes from the nfx-tree version.

linux/kernel/linux-mips-2.6/net/neteee2/eee-queue.h

     re-diff, as needs to be diffed against sm-eee/eee-queue.h

linux/kernel/linux-mips-2.6/net/neteee2/eee-test.c

     i have no idea what to tell you about this.  probably follows
     all the other eee-code

linux/kernel/linux-mips-2.6/net/neteee2/eee-test.h

     i don't see any reason for any of these changes, plus it probably
     doesn't belong here anyway

linux/kernel/linux-mips-2.6/net/neteee2/eee-timer-api-test.c

     not sure why this and a couple of other files didn't get checked
     in in my changelist way back.  especially since I have it in my
     working director in nfx-tree/code/neteee2/eee-timer-api-test.c;
     possibly i had some reason or possibly i fucked up.

     anyway this probably ends up wherever the eee code ends up.

linux/kernel/linux-mips-2.6/net/neteee2/eee-timer-api.c

     this needs to pick up all my changes in the nfx-tree version.
     it doesn't look like you have any deltas after that anyway.
     and it probably belongs there anyway as well.

linux/kernel/linux-mips-2.6/net/neteee2/eee-timer-api.h

     ditto as with eee-timer-api.c

linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.c

     ditto as with eee-timer-api.[ch]

linux/kernel/linux-mips-2.6/net/neteee2/eee-timer.h

     ditto as with eee-timer-api.[ch]

linux/kernel/linux-mips-2.6/net/neteee2/eee-utils.c

     ok

linux/kernel/linux-mips-2.6/net/neteee2/eee.h

     again, you shouldn't need this.  i had to define eee_stack_pool
     in the nfx-tree one, fyi.  maybe that can somehow go away.  yeah,
     i'm sure it has to.

linux/kernel/linux-mips-2.6/net/neteee2/req-queue-struct.h

     this file is generated in sm-req-queue, no way around that,
     so it can't go here.  this one may be an exception if it's
     absolutely needed by the tpl and neteee protocol code, and by
     that i mean this header file might be the one exception to the
     rule that kernel code can't include from the nfx-tree.  how we
     will accomplish it is another matter, and i'm of the mind that
     we try hard not to need to.

linux/kernel/linux-mips-2.6/net/onstor/acpu.c

     lines 48, 49, 50, 62, there's no way this stuff should
     be in here, these need to be in some routine farther down.
     nfx_shell_init(), rcon_init_polling() should all be in eee_init().
     nfx_shell_prompt() should be in eee_poll().

     i would say don't mess with this because i have it covered in a
     changelist i have only a day or two away, so leave it and don't
     worry about kernel link issues for that short time period.

linux/kernel/linux-mips-2.6/net/tpl/pkt-queue-api.c

     you need to merge a large number of changes from the nfx-tree
     version of this file.

     and remove the #ifdef LATER from several places.  i think that
     #ifdef LATER being in the nfx-tree version of this file is some
     kind of merge error on my part, because i went to some trouble
     to get it that code to compile.

linux/kernel/linux-mips-2.6/net/tpl/pkt-queue-api.h

     there are a number of clean-up type changes you need to get from
     the nfx-tree version.  also, in that version, i was able to use
     the original type for functions rather than the void* thing.
     not sure if that would be true for your version of the code or
     not, just mentioning it; like line 574, i have any_request_ptr_t
     rather than void*

linux/kernel/linux-mips-2.6/net/tpl/pkt.c

     line 77, these two should be inlines in a header file, rather
     than having to declare them external in some header or C file
     (at least that's what you did for alignptr, which actually i
     think i converted to a proper kernel function for such things,
     instead of the assinine ispower2 thing.

     line 247, why change it if it's ifdef'd LATER?

     line 359, so, if all these functions are ifdefed LATER then where
     are they handled?


linux/kernel/linux-mips-2.6/net/tpl/tpl-api.h

     looks ok

linux/kernel/linux-mips-2.6/net/tpl/tpl-ipc.c

     line 8-28, jesus, mary and josef, pare down this egregious
     header list.  you're not paid by the header, you know.  i kid.
     actually you are paid by the header.


linux/kernel/linux-mips-2.6/net/tpl/tpl-msg.c

     header diarrhea

     line 68 i notice that you failed to get the current definition
     of E_LOG.  you need that. also, i have a program that converts C
     files over to the new definition, if you're interested in saving
     a few hand edits.

     line 178 atrocious programming style, please use curlies or at the
     very least put the second part of the if indented on a new line.

     line 200 bindRsp = NULL; -- broken indenting, use a tab

     line 415, tws

     line 453, executes on NPCU?  you added that?  or maybe i deleted
     it, since there's no NCPU anymore.  please pick up the relevant
     changes from nfx-tree version of the file.


linux/kernel/linux-mips-2.6/net/tpl/tpl-rcv.c

     this is another one which is mysteriously
     missing from the nfx-tree, even though it's in
     /homes/andys/src/tuxrx/nfx-tree/code/tpl/tpl-rcv.c.  not sure i
     know why it wouldn't have been checked in by me or maybe i felt
     it wasn't ready yet, but then i would have included it but just
     commented it out of the makefile, but it's not in the makefile.
     i'm baffled.

linux/kernel/linux-mips-2.6/net/tpl/tpl-utils.c

     more header diarrhea

     line 301, please pick up relevant changes from nfx-tree version,
     although there aren't many it seems.  but no ushort16 type.  no.
     ok, this is the only relevant change from the nfx-tree version
     of this file i can see.

linux/kernel/linux-mips-2.6/net/tpl/tpl.c

     header damn burst

     this should provide some interenting test writing for someone ~:^)

linux/kernel/linux-mips-2.6/net/tpl/tpl.h

     line 16 wtf


