AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ed.Kwan@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	2B044E14371DA244B71F8BF2514563F503F47D30@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 21 Oct 2009 16:08:01 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kwan, Ed" <Ed.Kwan@lsi.com>
Subject: Re: please review code change for TED 27586 Add the "find" command
 to vscan, ndmp and fs quota logs.
Message-ID: <20091021160801.41f4c43b@ripper.onstor.net>
In-Reply-To: <2B044E14371DA244B71F8BF2514563F503F47D30@cosmail03.lsi.com>
References: <2B044E14371DA244B71F8BF2514563F503F47D30@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 19 Oct 2009 15:51:04 -0600 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:

> Change 33579
> 
> I'll do WebUI change separately.



= Change 33579 by edk@edk-dev on 2009/10/19 14:46:24 *pending*
= 
= 	For TED 27586 Add the "find" command to vscan, ndmp and fs
quota logs. = 	Add the "ndmp find", "vscan log find" and
"filesystem quota log find" commands. = 		Update various
help text files. = 	Reviewed by
= 


Please describe what TED27586 is.


nfx-tree/code/ssc-nfxsh/agile-man/help_filesystem_quota_log.txt

     looks good

nfx-tree/code/ssc-nfxsh/agile-man/help_filesystem_quota_log_find.txt

     >>add
     nfx-tree/code/ssc-nfxsh/agile-man/help_filesystem_quota_log_find.txt

     please fix the whitespace violations: trailing whitespace,
     blank lines with whitespace...

     what about `.'  -  as in 'any character'; hard to construct an
     re without that





nfx-tree/code/ssc-nfxsh/agile-man/help_ndmp.txt

     looks good

nfx-tree/code/ssc-nfxsh/agile-man/help_ndmp_find.txt

     >>add nfx-tree/code/ssc-nfxsh/agile-man/help_ndmp_find.txt

     again with the evil, evil whitespace violations

     do these help files have to be duplicated like this?  Can't one
     be created for re's and they both reference it?

nfx-tree/code/ssc-nfxsh/agile-man/help_vscan_log.txt

     looks good

nfx-tree/code/ssc-nfxsh/agile-man/help_vscan_log_find.txt

     >>add nfx-tree/code/ssc-nfxsh/agile-man/help_vscan_log_find.txt

     same comments as the other help files

nfx-tree/code/ssc-nfxsh/cmd_elog.c

     line 950 you probably have to handle the corner cases, like what
     if they type in a `'', `"', or `\' and like that, or a bunch of
     trailing or leading spaces or tabs,

nfx-tree/code/ssc-nfxsh/cmd_ndmp.c

     looks good

