AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>,<Andy.Sharp@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1256331967.20354.197.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 23 Oct 2009 14:30:04 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Cc: "Sharp, Andy" <Andy.Sharp@lsi.com>
Subject: Re: please review 33334
Message-ID: <20091023143004.22b0b1c4@ripper.onstor.net>
In-Reply-To: <1256331967.20354.197.camel@rendellf>
References: <20091022172108.51f46b80@ripper.onstor.net>
	<1256319596.20354.195.camel@rendellf>
	<20091023120403.05077bcf@ripper.onstor.net>
	<1256331967.20354.197.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 23 Oct 2009 15:06:07 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> On Fri, 2009-10-23 at 13:04 -0600, Andrew Sharp wrote:
> > On Fri, 23 Oct 2009 11:39:56 -0600 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> > 
> > > Ok, except as noted.
> > > 
> > > 
> > > On Thu, 2009-10-22 at 18:21 -0600, Andrew Sharp wrote:
> > > > Hi guys,
> > > > 
> > > > Larry need only look at the makefile changes.
> > > > 
> > > > The tuxstor build doesn't quite work because I need to follow up
> > > > this changelist with another one to fix the TUXRX references the
> > > > newly created tuxstor files.
> > > > 
> > > > Change 33334 by andys@ripper on 2009/09/14 17:48:04 *pending*
> > > > 
> > > > 	Changes for switching to new tuxstor project from old
> > > > tuxrx project.
> > > > 
> > > > 	Minor cleanup of linux/Makefile and
> > > > linux/kernel/Makefile.
> > > > 
> > > > 	Add external symbol declarations for small number of
> > > > symbols needed by the acpu module.
> > > > 
> > > > 	Clean up comments and some of the macros in mgmtbus
> > > > driver code, plus reorganize some of the code to eliminate
> > > > large ifdef blocks and other infelicities.  Bring the recent
> > > > changes to the code in the dev tree over as well.
> > > > 
> > > > 	Move linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx
> > > > 	to ...tuxstor.
> > > > 
> > > > 	Micro cleanup of the mgmtbus-aware code in sb1250-mac.c
> > > > (sibyte ethernet driver).
> > > > 
> > > > 	reviewed by
> > > > 
> > > > Affected files ...
> > > > 
> > > > ... //depot/tuxrx/linux/Makefile#1 edit
> > > > ... //depot/tuxrx/linux/kernel/Makefile#2 edit
> > > > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/HEAD#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/refs/heads/onstor-2.6.22#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Kconfig#3
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Makefile#3
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/head.S#2
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/stacktrace.c#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/Kconfig#3
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/common/ons_crashdump.c#2
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/dbg_io.c#1
> > > > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/setup.c#1
> > > > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/Makefile#1
> > > > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/dbg_io.c#1
> > > > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/prom.c#1
> > > > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/setup.c#1
> > > > branch
> > > 60: Does this string need to be updated?
> > 
> > Yes, I will fixup the files in arch/mips/onstor/tuxstor in a
> > follow-on changelist.  I forgot to mention that, sorry.
> > 
> > > > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/time.c#1
> > > > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/Makefile#2
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxrx.c#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxstor.c#1
> > > > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-config#4
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-debug-config#3
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Kconfig#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Makefile#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/cougar_mgmt_bus.c#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.c#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.h#1
> > > > edit
> > > 284: typo
> > 
> > fixed
> > 
> > 
> > > > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.c#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.h#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/tuxrx_mgmt_bus.c#1
> > > > edit
> > > 419/425: arg name mismatch
> > 
> > looks ok to me: mailbox is a pointer; %p is for pointers?
> 
> Arg name in comments is "dev", but actual arg name is "dev_id".

Sorry, I was looking in the wrong file somehow.  Fixed.


> > > > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#2
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/bootinfo.h#2
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/cpu-feature-overrides.h#1
> > > > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/tuxstor.h#1
> > > > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/ons_crashdump.h#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/slab_def.h#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/net/sock.h#3
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/stacktrace.c#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time.c#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time/timekeeping.c#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Kconfig#3
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Makefile#3
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#2
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Kconfig#1
> > > > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Makefile#1
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/acpu.c#2
> > > > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-config#2
> > > > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-debug-config#2
> > > > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#1
> > > > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-debug-config#1
> > > > branch ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#3 edit
> > > > 
> > > 
> 
