AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070426162109.75c3c0ed@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0221576E@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 26 Apr 2007 16:21:36 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: need your review of some improvements for flash_install.sh
Message-ID: <20070426162136.5bfa19c3@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221576E@onstor-exch02.onstor.net>
References: <20070426112343.69f6eaf6@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0221576E@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 26 Apr 2007 15:48:33 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> File: Tools/flash_install.sh
> Line 34: foo="`df / | tail -1`"
> 
> Just a comment for your consideration, I've gotten out of the habit of
> using tail -1 with df and started using fgrep /dev (or variants using
> grep) mainly because of Linux and ext3 file systems the df can span 3
> lines and the device is the middle line. The tail -1 works for now,
> and may continue to work for the foreseeable future, but it may not
> always.

fixed

> It is up to you if you want to change it or leave it because line 35
> will need to change when we switch to an ext2/3 file system anyway.
> 
> Line 298: echo "I can't file the software distribution in '$sdir'."
>                         ^^^^  You mean "find" correct?

fixed

 
> File: etc/rc
> Line 157: if grep /usr will also match /usr/local/agile and
> /usr/local/agile/conf
> 
> Line 164: if grep /usr/local/agile will also
> match /usr/local/agile/conf

both fixed - take a look and see what you think
 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, April 26, 2007 11:24 AM
> To: Larry Scheer
> Subject: need your review of some improvements for flash_install.sh
> 
> perforce cl 23729
> client ripper
> branch FB-DELOREAN
> 
> 
> Some improvements to flash_install:
>         
>         Improve the interactivity:
>          - let's you try again if you give a bogus answer
>          - instead of asking you an obvious question, it
>            automatically selects the secondary CF card
>            to format if your root filesystem is on a CF card.
>         
>         Better command argument checking
>         
>         Added some additional sanity checking
>         
>         Fixed up the error paths to exit more gracefully
