AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1256664568.23053.73.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 27 Oct 2009 13:17:40 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review - 33343
Message-ID: <20091027131740.2b907084@ripper.onstor.net>
In-Reply-To: <1256664568.23053.73.camel@rendellf>
References: <1255972002.20354.107.camel@rendellf>
	<20091026173941.5a1e971d@ripper.onstor.net>
	<1256664568.23053.73.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 27 Oct 2009 11:29:28 -0600 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> Comments inline.
> 
> On Mon, 2009-10-26 at 18:39 -0600, Andrew Sharp wrote:
> > On Mon, 19 Oct 2009 11:06:42 -0600 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> >
> > > Are you still reviewing this change?
> >
> > As of this second, no ~:^)  I probably should have boiled out just
> > the files that I commented on, but I'm too lazy.
> >
> > I didn't test compile it.  I can if you think I should.
> >
> > >
> > > -------- Forwarded Message --------
> > > From: Rendell Fong <Rendell.Fong@lsi.com>
> > > To: Andrew Sharp <andy.sharp@lsi.com>
> > > Subject: please review - 33343, 33341
> > > Date: Wed, 30 Sep 2009 12:40:58 -0700
> > >
> > > Change 33343 by rendellf@rendellf-test on 2009/09/15 16:05:57
> > > *pending*
> > >
> > >         Fixed ssc build for tuxrx branch.
> > >         Converted E_LOG to accept variable args like kernel
> > > module.
> > >
> > > Affected files ...
> > >
> > > ... //depot/tuxrx/nfx-tree/Includes/cg/nfx-defs.h#4 edit
> > > ... //depot/tuxrx/nfx-tree/Includes/nfx-defs.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/Includes/nfx-types.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/Tools/defs.mk#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/neteee2/eee.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/samba/nfx/reply_nfx.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-anpssc/anpssc-api.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-anpssc/anpssc-eee.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-anpssc/anpssc-nfx.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-authorization/author-api.h#3
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-bsd-netinet/vstack.h#1
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-bsd-snmpd/agent/agent_trap.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/asiEvm.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/asiFibreChannel.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/csiDevErr.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsCifs.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsCifsIo.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsCifsShare.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsCluster.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsCommon.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsCommon.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsContext.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsDevTxrx.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsDomain.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsEthernet.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsFilesystem.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsLun.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsMirror.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsNfs.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsNfsIo.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsNfsMnt.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsNfsNlm.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsNfsNsm.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsNfsShare.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsNfsV2.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsNfsV3.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsNfsVscan.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsPortLdStat.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsProduct.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsSnapshot.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsSysStat.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsVolume.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/agile/onsVsvr.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/mibII/interfaces.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-bsd-
> > > snmpd/agent/mibgroup/mibII/system_mib.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-chassis/chassisd-cg.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-chassis/chassisd-msg.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-chassis/chassisd.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/cifs-stats.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/ntifs.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-cifs/win-compat.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-crypt/crypt.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-crypt/crypt.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dcache/dcache-stats.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-debug/debug.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-debug/debug.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-dp-proxy/dp-proxy.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ea/ea-cfgd-rx.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ea/ea-cfgd.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ea/ea-cfgd.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ea/ea-evm.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ea/ea-fs.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ea/ea-nis.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ea/ea-util.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ea/ea-util.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-eee/eee-inlines.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-elog/elog-api.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-esm/esm-api.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-event/asd.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-event/emrs-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-event/event-api.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-event/event-api.h#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-event/event-as-linux.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-event/event-as.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-event/event.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-api.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-cfgd-rx.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-cfgd.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-com-defs.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-db.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-diag.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-events.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-fp-func.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-sdm.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-spm.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-srvr-api.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-util.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm-util.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-evm/evm.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/Makefile#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-api.h#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-global.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-includes.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-lock.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-proto.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/fs-shell.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/fsdb-read-block.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-fs/fsdb.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/cmemory.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/cstring.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/cstring.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/icu_onstor.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/icu_wrappers.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-icu-common/putil.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/ucnv.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/ucnv2022.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/ucnv_io.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/ucnv_lmb.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/ucnvhz.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/ucnvmbcs.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/udata.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/uhash.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/uhash.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/uloc.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-icu-common/unicode/platform.h#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-icu-common/unicode/putil.h#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-icu-common/unicode/ustring.h#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-icu-common/uresbund.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-icu-common/ustring.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-icu-common/ustrtrns.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/sm-ipm/ipm-util.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ipm/ipm.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ipmd/ipmd.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-libc/libc.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-libc/linux-strlcat.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-libc/linux-strlcpy.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-malloc/malloc-api.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-ndmp/ndmp.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-cmd-api.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-cmd-shell.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-nfs/nfs-defs.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-req-queue/Makefile#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-rmc/rmc_common.h#5 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-scsi/scsi-api.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-scsi/scsi-msg.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sct/ioprocessor.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sct/ioprocessor.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sct/sct-ccc-ssl.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sct/sct-http.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sct/sct.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sct/sfmclient.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sct/taskmgr.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/sdm-conf.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/sdm-init-changer.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/sdm-init-devcap.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/sdm-init-disk.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/sdm-init.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/sdm-main.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/sdm-msg.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/sdm-verify.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/sdm.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-sdm/storage.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-seep/env.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-spm/spm-lun.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-spm/spm-msg.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-spm/spm-nfx.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-spm/spm-poll.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-spm/spm-pool.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-spm/spm-reg.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-spm/spm-util.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-spm/spm.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-stats/kpi.h#5 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-stats/stats-client.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-tape/tape-debug.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-tape/tape-device.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-tape/tape-discovery.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-tape/tape-main.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-tape/tape-msg.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-tape/tape-rmc.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-tape/tape-sm.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-tape/tape-utils.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-tape/tape-utils.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-trace/trace.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-trace/trace.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-utils/Makefile#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-utils/cmd-utils.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-utils/cmd-utils.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-utils/sys-utils.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-utils/utils-fs-api.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/sm-vsvr/vs-struct.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-authen-lib/admin-session.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-authen-lib/authen-lib-api.h#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-authen-lib/authen-lib.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-authen-lib/authen-localaccounts-
> > > api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-authen-lib/authen-localaccounts-
> > > api.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-authen-lib/dom-cfg.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-authen-lib/idmap-cfg.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-authen-lib/privs-cfg.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-authentication/auth-agent.c#4
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-authentication/auth-agent.h#3
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-authentication/auth-cifs.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-authentication/auth-idmap.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-authentication/auth-nis.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-authentication/auth-privs.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-authentication/authen-struct.h#3
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/clusdb-alloc.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/clusdb-api.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/clusdb-hash.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/clusdb-rec-r122.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/clusdb-tools.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/clusdb-upgrade-common.c#3
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/clusdb-utils.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-autosupport-api.c#2
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-cifs-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-cifssrvr-api.c#1
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-contrl-cache.c#1
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-contrl-rpc.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-coredump-api.c#1
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-dcache-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-domain-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-dump-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-elog-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-emrs-api.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-filer-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-fsrcc-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-gns-api.c#3
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-grp-api.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-idmap-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-ip-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-lmhost-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-localaccounts-
> > > api.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-mirror-api.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-mountedvol-api.c#1
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-mountedvol-api.h#2
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-ndmpauth-api.c#1
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-ndmpcfg-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-priv-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-relay.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-rmc.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-route-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-sdm-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-securityObj-api.c#1
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-securityObj-api.h#1
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-server-rpc.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-server.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-share-api.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-snap-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-tape-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-tape-map.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-test.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-util.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-util.h#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-vintf-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-vintf-api.h#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-vlink-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-vol-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-vol-api.h#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-vsvr-api.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-vsvr-api.h#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-cluster/cluster-wins-api.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-crashsave/crashsave.c#2
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-crashsave/linux.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-fs-lib/fs-remote-snappin-api.c#1
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-genlib/cm-util-cg.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-genlib/fs.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-genlib/genlib.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-initial-config/initial-config-
> > > linux.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-initial-config/initial-config.c#2
> > > edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ncm-lib/ncm-api.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ncm/ncm.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-config.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-connect.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-data.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-debug.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-info.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-linux.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-main.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-mover.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-scsi.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-snap.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-srvr-ui.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-ssc-util.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-tape-rmc.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-tape.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-trace-msg.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-ndmp/ndmp-ui.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/cfg_nfxnis.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxauth.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxdns-api.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxdns-linux.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxdns.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxldap-lib.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxldap-lib.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxldap-query.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxldap-vs.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxldap.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis-api.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis-dns.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis-lib.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis-lib.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis-nis.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis-res.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis-rpc.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis-yp.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/nfxnis.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/test/ldaptest.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxnis/test/nistest.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/Makefile#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_arp.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_audit.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_cifssrvr.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_cluster.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_cshare.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_domain.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_elog.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_filesystem.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_fsutil.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_gns.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_idmap.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_interface.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_localmap.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_localuseraccounts.c#1
> > > edit ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_lvol.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_ndmp.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_nfs.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_port.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_quota.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_route.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_sanm.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_snapshot.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_spool.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_stats.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_system.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_vif.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_vol.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_vscan.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/cmd_vsvr.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/command.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/kpi-ui.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/menu.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/nfxsh.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/vtysh.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-nfxsh/vtysh_main.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-openafs-ubik/beacon.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-openafs-ubik/disk.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-openafs-ubik/recovery.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-openafs-ubik/remote.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-openafs-ubik/ubik.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-openafs-ubik/ubik.p.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-openafs-ubik/vote.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-rmc/rmc.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-rmc/rmc_client.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-rmc/rmc_rpc_api.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sanm/sanm-api.h#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sanm/sanm-cron.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sanm/sanm-main.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sanm/sanm-msg.c#3 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sanm/sanm-util.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sshd-kb5/auth-passwd.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sshd-kb5/auth2-passwd.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sshd-kb5/auth2-pubkey.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sshd-kb5/auth2.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-sshd-kb5/sshlogin.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-tests/anpssctest.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-tests/ncmtest-linux.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-tests/nfxdnstest.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-tests/pmtest.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-tests/rmctest-linux.c#4 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-tests/vscantest.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-timekeeper/ntp_utils.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-timekeeper/timekeeper.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-volread/volread.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/Makefile#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-cifssrvr.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-ipm.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-nisfile.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-nisfile.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-ssc-inline.h#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vsd/vs-util.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vtm/vtm-common.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vtm/vtm-failover.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vtm/vtm-move.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vtm/vtm-msg.c#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vtm/vtm-util.c#1 edit
> > > ... //depot/tuxrx/nfx-tree/code/ssc-vtm/vtm.h#2 edit
> > > ... //depot/tuxrx/nfx-tree/code/ui/acpu.c#1 add
> > > ... //depot/tuxrx/nfx-tree/code/ui/commands.c#1 edit
> >
> >
> >
> > = Change 33343 by rendellf@rendellf-test on 2009/09/15 16:05:57
> > *pending* =
> > =       Fixed ssc build for tuxrx branch.
> > =       Converted E_LOG to accept variable args like kernel module.
> > =
> >
> > nice get on the sendAgile -> utils_send conversions.
> >
> > the "reliable logging" setting for the cluster code needs to not be
> > broken by this.
> 
> > i don't why it would be, but just take a quick look at that, or
> > remind me to.
> 
> > it's in one of the cluster header files nearby where the cluster
> > code defines it's ELOG macro clones.
> >
> 
> The reliable logging setting enables logging to a log file as well as
> issuing an E_LOG.  All user apps are using e_log() via E_LOG which
> uses sendAgileMsg in ssc-libelog/elog-ssc.c.  Are you saying you want
> me to change it to use utils_send instead?  If so, it ought to be
> done in a separate change since its not a one liner.

No, you|me just needs to make sure that reliable-logging isn't broken by
any of this.  Chris uses it during debug work because the old elog
looses so many messages.  I guess she just sets the macro to define
reliable-logging, and then recompiles so that all the places that say
ifdef reliable-logging get compiled, etc.

> >
> >
> > nfx-tree/Includes/cg/nfx-defs.h
> >
> >      line 24, uh, what's wrong with the angle brackets?  this file
> >      could get moved one day...tomorrow ~:^)
> 
> It doesn't work due to include dir list ordering in make.
> Of course, you would know that unless attempting to build the apps.
> I've reverted it back to what it was originally.

The problem is that this refers to the C file being compiled, not the
directory this header file is in.  So you are saying the include dir
list order is different for the userspace build than the kernel/eee
build?  If so, then can that be fixed?  Or are we just screwed?

> > nfx-tree/Includes/nfx-defs.h
> >
> >      looks good
> >
> > nfx-tree/Includes/nfx-types.h
> >
> >      line 24, the differences here probably need to be addressed in
> >      the code, ie., the code needs to be fixed up to comply with the
> >      new world order
> 
> It don't feel like changing all the code over.  Seems like a low
> priority issue.

I guess it stays for now.  Which means for all time.

> > nfx-tree/Tools/init-ssc.mk
> >
> >      looks good
> >
> > nfx-tree/code/neteee2/eee.h
> >
> >      ok
> >
> > nfx-tree/code/samba/nfx/reply_nfx.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-anpssc/anpssc-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-anpssc/anpssc-eee.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-anpssc/anpssc-nfx.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-authorization/author-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-netinet/vstack.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/agent_trap.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/asiEvm.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/asiFibreChannel.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/csiDevErr.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsCifs.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsCifsIo.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsCifsShare.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsCluster.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsCommon.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsCommon.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsContext.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsDevTxrx.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsDomain.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsEthernet.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsFilesystem.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsLun.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsMirror.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsNfs.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsNfsIo.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsNfsMnt.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsNfsNlm.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsNfsNsm.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsNfsShare.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsNfsV2.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsNfsV3.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsNfsVscan.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsPortLdStat.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsProduct.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsSnapshot.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsSysStat.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsVolume.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsVsvr.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/mibII/interfaces.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/mibII/system_mib.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-chassis/chassisd-cg.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-chassis/chassisd-msg.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-chassis/chassisd.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-cifs/cifs-stats.h
> >
> >      that's brutal
> >
> > nfx-tree/code/sm-cifs/ntifs.h
> >
> >      line 24 definitely not khosher inside a header file.  the angle
> >      brackets should work fine in the userspace.  isn't the makefile
> >      been changed to fix that?
> >
> ok. I removed it.  I probably had to change it before the makefile was
> changed.
> 
> >
> >
> > nfx-tree/code/sm-cifs/win-compat.h
> >
> >      looks horrible but who cares
> >
> 
> This was a pain in the !#%!.
> 
> > nfx-tree/code/sm-crypt/crypt.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-crypt/crypt.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-dcache/dcache-stats.h
> >
> >      holy crapoly
> >
> > nfx-tree/code/sm-debug/debug.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-debug/debug.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-dp-proxy/dp-proxy.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-ea/ea-cfgd-rx.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-ea/ea-cfgd.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-ea/ea-cfgd.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-ea/ea-evm.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-ea/ea-fs.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-ea/ea-nis.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-ea/ea-util.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-ea/ea-util.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-eee/eee-inlines.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-elog/elog-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-esm/esm-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-event/asd.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-event/emrs-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-event/event-api.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-event/event-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-event/event-as-linux.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-event/event-as.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-event/event.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-cfgd-rx.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-cfgd.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-com-defs.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-db.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-diag.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-events.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-fp-func.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-sdm.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-spm.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-srvr-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-util.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm-util.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-evm/evm.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-file/file-lib.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-fs/Makefile
> >
> >      line 22 why did this need to change?
> >
> >      line 128 ditto, why is this necessary?
> >
> >      these all look suspect to my untrained eye.
> 
> Can't recall why. It's been too long ago.
> Things still build using the original makefile so I've reverted it.
> 
> >
> > nfx-tree/code/sm-fs/fs-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-fs/fs-global.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-fs/fs-includes.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-fs/fs-lock.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-fs/fs-proto.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-fs/fs-shell.c
> >
> >      line 6045 don't leave these commented out lines in there...
> >
> >      line 6089 ditto
> >
> ok, removed.
> 
> >
> >
> > nfx-tree/code/sm-fs/fsdb-read-block.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-fs/fsdb.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/cmemory.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/cstring.c
> >
> >      line 58, isn't this a routine i wrote myself somewhere?  we
> > should just make it universally available
> 
> Reverted it. Changed sm-netbios/nb-str-utils.c instead.

OK, but that doesn't seem to be in your changelist.  Should it be?

> > nfx-tree/code/sm-icu-common/cstring.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/icu_onstor.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/icu_wrappers.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/putil.c
> >
> >      line 174 ooh, highly questionable for sure, probably breaks
> > half the world
> 
> It has to be defined.  Notice that where it is referenced they are
> doing an #if instead of #ifdef.  Compiler don't like it when #if is
> used without it being defined.
> 
> linux-compile.onstor.net $ pwd
> /homes/rendellf/tuxrx/nfx-tree/code/sm-icu-common
> linux-compile.onstor.net $ grep -r U_POSIX_LOCALE *
> putil.c:#define U_POSIX_LOCALE 0
> putil.c://#   undef U_POSIX_LOCALE
> putil.c:#   define U_POSIX_LOCALE    0
> putil.c:#   define U_POSIX_LOCALE    1
> putil.c:#if U_POSIX_LOCALE
> putil.c:#if U_POSIX_LOCALE
> putil.c:#if U_POSIX_LOCALE
> putil.c:#if U_POSIX_LOCALE
> putil.c:#elif U_POSIX_LOCALE
> 
> 
> > nfx-tree/code/sm-icu-common/ucnv.c
> >
> >      line 22 if string.h shouldn't be included, then delete that
> > line, since i added it
> ok
> 
> >
> > nfx-tree/code/sm-icu-common/ucnv2022.c
> >
> >      line 31 same, get rid of string.h include line
> >
> ok
> 
> > nfx-tree/code/sm-icu-common/ucnv_bld.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/ucnv_io.c
> >
> >      line 30 again, axe the newly added line if it shouldn't be
> > there
> >
> ok
> 
> > nfx-tree/code/sm-icu-common/ucnv_lmb.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/ucnvhz.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/ucnvisci.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/ucnvmbcs.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/udata.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/uhash.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/uhash.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/uloc.c
> >
> >      line 29 axe this
> ok
> 
> >
> > nfx-tree/code/sm-icu-common/unicode/platform.h
> >
> >      ew
> >
> > nfx-tree/code/sm-icu-common/unicode/putil.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/unicode/ustring.h
> >
> >      line 16 delete line
> ok
> 
> >
> > nfx-tree/code/sm-icu-common/uresbund.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/uresdata.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-icu-common/ustring.c
> >
> >      line 31 delete me
> ok
> 
> >
> > nfx-tree/code/sm-icu-common/ustrtrns.c
> >
> >      line 25 delete me
> ok
> 
> >
> > nfx-tree/code/sm-ipm/ipm-util.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-ipm/ipm.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-ipmd/ipmd.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-libc/libc.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-libc/linux-strlcat.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-libc/linux-strlcpy.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-malloc/malloc-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-ndmp/ndmp.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-nfs/nfs-cmd-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-nfs/nfs-cmd-shell.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-nfs/nfs-defs.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-req-queue/Makefile
> >
> >      looks good
> >
> > nfx-tree/code/sm-rmc/rmc_common.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-scsi/scsi-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-scsi/scsi-msg.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-sct/ioprocessor.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sct/ioprocessor.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-sct/sct-ccc-ssl.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sct/sct-http.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sct/sct.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sct/sfmclient.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sct/taskmgr.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/sdm-conf.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/sdm-init-changer.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/sdm-init-devcap.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/sdm-init-disk.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/sdm-init.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/sdm-main.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/sdm-msg.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/sdm-verify.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/sdm.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-sdm/storage.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-seep/env.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-spm/spm-lun.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-spm/spm-msg.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-spm/spm-nfx.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-spm/spm-poll.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-spm/spm-pool.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-spm/spm-reg.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-spm/spm-util.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-spm/spm.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-stats/kpi.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-stats/stats-client.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-tape/tape-debug.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-tape/tape-device.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-tape/tape-discovery.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-tape/tape-main.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-tape/tape-msg.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-tape/tape-rmc.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-tape/tape-sm.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-tape/tape-utils.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-tape/tape-utils.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-trace/trace.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-trace/trace.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-utils/Makefile
> >
> >      line 26 that looks wrong, how could it be needed now when it
> >      wasn't before?
> 
> It's now needed in the lib because you moved fs_TimeCompare from
> the .h to .c file.  fsdb won't link without it.
> 
> >
> > nfx-tree/code/sm-utils/cmd-utils.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-utils/cmd-utils.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-utils/sys-utils.c
> >
> >      looks good
> >
> > nfx-tree/code/sm-utils/utils-fs-api.h
> >
> >      looks good
> >
> > nfx-tree/code/sm-vsvr/vs-struct.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authen-lib/admin-session.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authen-lib/authen-lib-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authen-lib/authen-lib.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authen-lib/authen-localaccounts-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authen-lib/authen-localaccounts-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authen-lib/dom-cfg.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authen-lib/idmap-cfg.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authen-lib/privs-cfg.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authentication/auth-agent.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authentication/auth-agent.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authentication/auth-cifs.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authentication/auth-idmap.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authentication/auth-nis.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authentication/auth-privs.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-authentication/authen-struct.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/clusdb-alloc.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/clusdb-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/clusdb-hash.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/clusdb-rec-r122.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/clusdb-tools.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/clusdb-upgrade-common.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/clusdb-utils.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-autosupport-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-cifs-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-cifssrvr-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-contrl-cache.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-contrl-rpc.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-coredump-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-dcache-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-domain-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-dump-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-elog-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-emrs-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-filer-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-fsrcc-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-gns-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-grp-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-idmap-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-ip-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-lmhost-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-localaccounts-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-mirror-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-mountedvol-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-mountedvol-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-ndmpauth-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-ndmpcfg-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-priv-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-relay.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-rmc.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-route-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-sdm-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-securityObj-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-securityObj-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-server-rpc.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-server.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-share-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-snap-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-tape-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-tape-map.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-test.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-util.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-util.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-vintf-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-vintf-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-vlink-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-vol-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-vol-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-vsvr-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-vsvr-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-cluster/cluster-wins-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-crashsave/crashsave.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-crashsave/linux.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-elog/elog.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-fs-lib/fs-remote-snappin-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-genlib/cm-util-cg.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-genlib/fs.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-genlib/genlib.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-initial-config/initial-config-linux.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-initial-config/initial-config.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ncm-lib/ncm-api.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ncm/ncm.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-config.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-connect.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-data.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-debug.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-info.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-linux.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-main.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-mover.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-scsi.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-snap.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-srvr-ui.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-ssc-util.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-tape-rmc.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-tape.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-trace-msg.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-ndmp/ndmp-ui.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/cfg_nfxnis.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxauth.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxdns-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxdns-linux.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxdns.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxldap-lib.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxldap-lib.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxldap-query.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxldap-vs.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxldap.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxnis-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxnis-dns.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxnis-lib.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxnis-lib.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxnis-nis.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxnis-res.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxnis-rpc.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxnis-yp.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/nfxnis.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/test/ldaptest.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxnis/test/nistest.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/Makefile
> >
> >      why is gns in there when it wasn't before?  your changelist
> >      shouldn't be adding it
> 
> Look again. It's been removed not added.
> 
> >
> > nfx-tree/code/ssc-nfxsh/cmd_arp.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_audit.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_autosupport.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_cifssrvr.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_cluster.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_cshare.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_domain.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_elog.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_filesystem.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_fsutil.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_gns.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_idmap.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_interface.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_localmap.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_localuseraccounts.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_lvol.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_ndmp.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_nfs.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_port.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_quota.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_route.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_sanm.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_snapshot.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_spool.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_stats.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_system.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_vif.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_vol.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_vscan.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/cmd_vsvr.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/command.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/kpi-ui.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/menu.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/nfxsh.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/vtysh.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-nfxsh/vtysh_main.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-openafs-ubik/beacon.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-openafs-ubik/disk.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-openafs-ubik/recovery.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-openafs-ubik/remote.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-openafs-ubik/ubik.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-openafs-ubik/ubik.p.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-openafs-ubik/vote.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-rmc/rmc.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-rmc/rmc_client.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-rmc/rmc_rpc_api.h
> >
> >      shouldn't rmc_lock_t just define to the right thing in the
> > right places?  the ifdef here is pretty ugly.
> >
> 
> rmc_lock_t used to be defined in sm-rmc/rmc-eee.h as nfx_spinlock_t in
> the txrx case.  However, you removed it.  The ifdef is needed here
> since it is different for ssc and txrx.

If it would get rid of the ifdef, then put the rmc_lock_t back in that
I removed.  Or make me do it.  I think you said it only was in one
place.


> > nfx-tree/code/ssc-sanm/sanm-api.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-sanm/sanm-cron.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-sanm/sanm-main.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-sanm/sanm-msg.c
> >
> >      line 539, you don't want to change this to a utils_send()?
> 
> done
> 
> >
> > nfx-tree/code/ssc-sanm/sanm-util.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-sshd-kb5/auth-passwd.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-sshd-kb5/auth2-passwd.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-sshd-kb5/auth2-pubkey.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-sshd-kb5/auth2.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-sshd-kb5/sshlogin.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-tests/anpssctest.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-tests/ncmtest-linux.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-tests/nfxdnstest.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-tests/pmtest.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-tests/rmctest-linux.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-tests/vscantest.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-timekeeper/ntp_utils.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-timekeeper/timekeeper.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-volread/volread.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vsd/Makefile
> >
> >      line 43, again, why are -you- adding gns to the mix?
> 
> You've got it backwards.  It's been removed.

doh

> >
> > nfx-tree/code/ssc-vsd/vs-cifssrvr.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vsd/vs-ipm.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vsd/vs-nisfile.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vsd/vs-nisfile.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vsd/vs-ssc-inline.h
> >
> >      uh, don't need the unmount message anymore, do we?
> 
> It's still needed.  The code used to be in sm-anpssc/anpssc-eee.c but
> it is not a good place for it.  Its been added here since it seems
> more appropriate in this file.

this is another one where my brain was put in backwards yesterday, i
thought you were deleting it.

> >
> > nfx-tree/code/ssc-vsd/vs-util.h
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vtm/vtm-common.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vtm/vtm-failover.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vtm/vtm-move.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vtm/vtm-msg.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vtm/vtm-util.c
> >
> >      looks good
> >
> > nfx-tree/code/ssc-vtm/vtm.h
> >
> >      looks good
> >
> > nfx-tree/code/ui/commands.c
> >
> >      looks good
> >
> 
