AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>,<Bill.Fisher@lsi.com>,<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755E9275A51@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 28 Oct 2009 13:50:59 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Cc: "Fisher, Bill" <Bill.Fisher@lsi.com>, "Fong, Rendell"
 <Rendell.Fong@lsi.com>
Subject: Re: please review 33334
Message-ID: <20091028135059.15beb003@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755E9275A51@cosmail02.lsi.com>
References: <20091022172108.51f46b80@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755E9275A51@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 28 Oct 2009 13:20:57 -0600 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> = Change 33334 by andys@ripper on 2009/09/14 17:48:04 *pending*
> = 
> =       Changes for switching to new tuxstor project from old tuxrx
> =       project.
> = 
> =       Minor cleanup of linux/Makefile and linux/kernel/Makefile.
> 
> >> No need to change linux/Makefile
> 
> = 
> =       Add external symbol declarations for small number of symbols
> =       needed by the acpu module.
> = 
> =       Clean up comments and some of the macros in mgmtbus driver
> code, =       plus reorganize some of the code to eliminate large
> ifdef blocks =       and other infelicities.  Bring the recent
> changes to the code =       in the dev tree over as well.
> = 
> =       Move linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx
> =       to ...tuxstor.
> = 
> =       Micro cleanup of the mgmtbus-aware code in sb1250-mac.c
> (sibyte =       ethernet driver).
> = 
> =       reviewed by
> = 
> 
> linux/Makefile
> 
>      No. There is no reason to make this change. Revert this file

What's wrong with this?  Should we not use the variable that is defined
for exactly this purpose?  Otherwise, there's no need for the variable
to even be defined in this Makefile.  So, I should either delete the
variable definition or change this line?

> linux/kernel/Makefile
>
>      looks good
> 
> linux/kernel/linux-mips-2.6/arch/mips/Kconfig
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/arch/mips/Makefile
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/arch/mips/onstor/Kconfig
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/Makefile
> 
>      >>branch
>      linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/Makefile
> 
> linux/kernel/linux-mips-2.6/arch/mips/pci/Makefile
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/cougar-config
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/cougar-debug-config
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Kconfig
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Makefile
> 
>      Line 6: Ok as is however, I recommend renaming
>      tuxrx_mgmt_bus.* to tuxstor_mgmt_bus.o. Just to make filenames
>      consistent with platform setting.
> 
>      It is up to you.

I left them the way it is because I didn't feel like doing the work
and because the only future use of this driver is to let us run tuxstor
on legacy cougar hardware, so it's almost more of a tuxrx thing than a
tuxstor thing.  Anyway.

> linux/kernel/linux-mips-2.6/net/Kconfig
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/net/Makefile
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/net/onstor/Kconfig
> 
>      >>delete linux/kernel/linux-mips-2.6/net/onstor/Kconfig
> 
> linux/kernel/linux-mips-2.6/net/onstor/Makefile
> 
>      looks good
> 
> nfx-tree/Makefile.tuxstor
> 
>      looks good
> 
> ________________________________________
> From: Andrew Sharp [andy.sharp@lsi.com]
> Sent: Thursday, October 22, 2009 5:21 PM
> To: Fisher, Bill
> Cc: Fong, Rendell; Scheer, Larry
> Subject: please review 33334
> 
> Hi guys,
> 
> Larry need only look at the makefile changes.
> 
> The tuxstor build doesn't quite work because I need to follow up this
> changelist with another one to fix the TUXRX references the newly
> created tuxstor files.
> 
> Change 33334 by andys@ripper on 2009/09/14 17:48:04 *pending*
> 
>         Changes for switching to new tuxstor project from old tuxrx
>         project.
> 
>         Minor cleanup of linux/Makefile and linux/kernel/Makefile.
> 
>         Add external symbol declarations for small number of symbols
>         needed by the acpu module.
> 
>         Clean up comments and some of the macros in mgmtbus driver
> code, plus reorganize some of the code to eliminate large ifdef blocks
>         and other infelicities.  Bring the recent changes to the code
>         in the dev tree over as well.
> 
>         Move linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx
>         to ...tuxstor.
> 
>         Micro cleanup of the mgmtbus-aware code in sb1250-mac.c
> (sibyte ethernet driver).
> 
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/tuxrx/linux/Makefile#1 edit
> ... //depot/tuxrx/linux/kernel/Makefile#2 edit
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/HEAD#1 edit
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/refs/heads/onstor-2.6.22#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Kconfig#3
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Makefile#3
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/head.S#2
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/stacktrace.c#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/Kconfig#3
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/common/ons_crashdump.c#2
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/dbg_io.c#1
> delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/setup.c#1
> delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/Makefile#1
> branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/dbg_io.c#1
> branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/prom.c#1
> branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/setup.c#1
> branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/time.c#1
> branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/Makefile#2
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxrx.c#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxstor.c#1
> add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-config#4 edit
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-debug-config#3
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Kconfig#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Makefile#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/cougar_mgmt_bus.c#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.c#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.h#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.c#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.h#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/tuxrx_mgmt_bus.c#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#2
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/bootinfo.h#2
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/cpu-feature-overrides.h#1
> branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/tuxstor.h#1
> branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/ons_crashdump.h#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/slab_def.h#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/net/sock.h#3
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/stacktrace.c#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time.c#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time/timekeeping.c#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Kconfig#3 edit
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Makefile#3 edit
> ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#2
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Kconfig#1
> delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Makefile#1
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/acpu.c#2
> edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-config#2
> delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-debug-config#2
> delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#1
> branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-debug-config#1
> branch ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#3 edit
> 
