AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Bill.Fisher@lsi.com>,<Brian.Stark@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	7723	4AE84E62.2050404@lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 28 Oct 2009 14:40:06 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Fisher, Bill" <Bill.Fisher@lsi.com>
Cc: "Stark, Brian" <Brian.Stark@lsi.com>
Subject: Re: please review 33334
Message-ID: <20091028144006.58574000@ripper.onstor.net>
In-Reply-To: <4AE84E62.2050404@lsi.com>
References: <20091022172108.51f46b80@ripper.onstor.net>
 <4AE84E62.2050404@lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 28 Oct 2009 08:00:02 -0600 William Fisher <bill.fisher@lsi.com>
wrote:

> Andrew Sharp wrote:
> > Hi guys,
> >
> > Larry need only look at the makefile changes.
> >
> > The tuxstor build doesn't quite work because I need to follow up
> > this changelist with another one to fix the TUXRX references the
> > newly created tuxstor files.
> >
> > Change 33334 by andys@ripper on 2009/09/14 17:48:04 *pending*
> >
> > 	Changes for switching to new tuxstor project from old tuxrx
> > 	project.
> >
> > 	Minor cleanup of linux/Makefile and linux/kernel/Makefile.
> >
> > 	Add external symbol declarations for small number of symbols
> > 	needed by the acpu module.
> >
> > 	Clean up comments and some of the macros in mgmtbus driver
> > code, plus reorganize some of the code to eliminate large ifdef
> > blocks and other infelicities.  Bring the recent changes to the code
> > 	in the dev tree over as well.
> >
> > 	Move linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx
> > 	to ...tuxstor.
> >
> > 	Micro cleanup of the mgmtbus-aware code in sb1250-mac.c
> > (sibyte ethernet driver).
> >
> > 	reviewed by
> >
> > Affected files ...
> >
> > ... //depot/tuxrx/linux/Makefile#1 edit
> > ... //depot/tuxrx/linux/kernel/Makefile#2 edit
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/HEAD#1 edit
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/.git/logs/refs/heads/onstor-2.6.22#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Kconfig#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/Makefile#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/head.S#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/kernel/stacktrace.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/Kconfig#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/common/ons_crashdump.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/dbg_io.c#1
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxrx/setup.c#1
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/Makefile#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/dbg_io.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/prom.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/setup.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/onstor/tuxstor/time.c#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/Makefile#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxrx.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/pci/fixup-tuxstor.c#1
> > add ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-config#4
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/cougar-debug-config#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Kconfig#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Makefile#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/cougar_mgmt_bus.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/mgmt-bus.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/rcon.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/mgmt-bus/tuxrx_mgmt_bus.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/bootinfo.h#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/cpu-feature-overrides.h#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/asm-mips/mach-tuxstor/tuxstor.h#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/onstor/ons_crashdump.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/linux/slab_def.h#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/include/net/sock.h#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/stacktrace.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/kernel/time/timekeeping.c#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Kconfig#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/Makefile#3
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Kconfig#1
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/Makefile#1
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/net/onstor/acpu.c#2
> > edit ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-config#2
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxrx-debug-config#2
> > delete ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#1
> > branch ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-debug-config#1
> > branch ... //depot/tuxrx/nfx-tree/Makefile.tuxstor#3 edit
> >
> >   
> I apologize for ripping you a new one with respect to these changes.
> 
> Since you and I have been working on the code for almost a year,
> I feel strongly about how the schedule is slipping and we
> are not finishing the items we "promised" Brian when
> we created the group schedule. Hopefully going
> forward, we can recover some ground with better
> coordination/communication of the things we are
> all working on.
> 
> I still feel this fix is not really required, and the least should
> bereworked to not edit comments in the headers
> and other code file; Just change the minimum
> number of files to effect your intent.
> 
> Leave the acpu code as it today, since I have the
> tpl and neteee2 files ready for examination upon
> our return froim Kansas. These changes get the
> old rcon shell ack to working and require
> the old acpu.c file. In addition, it moves
> the kernel header files to the include/linux/onstor
> directories.
> 
> I will rework the txrx module next to use
> these header files next wee. Hence this
> is a two step scheme.
> 
> I will also get the "module" to load
> next week along with resolving the
> EXPORT_SYMBOL(XXX)
> directives in the kernel tpl and
> neteee2 module.

It would be one thing if even one thing you said was correct and not an
assinine reaction to someone touching "your code."

It would be one thing if it was your place to presume to tell me what a
good use of my time is.

It would be one thing if you were even coming close to pulling your
weight on this project or doing 10% of what you would like us to
believe you're doing.

And dare I point out that most everything in this changelist is taking
care of stuff that you roundly criticise eee for never doing?

The reason I sent it to you was to try and demonstrate to you what a
real changelist looks like and what it must accomplish, and what goes on
in a proper code review, which engineers at Onstor take very
seriously.  It's a very important part of the way we make progress on a
project.

Instead I get the usual Bill blowup/attack reaction that isn't just
unprofessional, it's highly counter productive, but of course, that's
the point.  I realize it's your defense mechanism for all kinds of
scenarios, including trying to distract everyone from realizing that
you're spending about 2.5 hours a week on coding, but that doesn't make
it acceptable.

I hope you take this in the right way.  What I want and what I need is
a productive member of the team, not a constanly exploding blow-hard
who produces not even a trickle.  If you can find your way back to that
guy who did TCP/IP over the mgmtbus, then you are welcome on the team.

You can start by doing a proper code review of the changelist.  If
you're not sure what that entails, just ask me.
