AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755E9275A50@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 28 Oct 2009 16:50:20 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: Please review change 33652 Makefile fixes for build problem
 with make test
Message-ID: <20091028165020.44300926@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755E9275A50@cosmail02.lsi.com>
References: <DEC609CD0E54B2448DAF023C89AE9755E9275A50@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 27 Oct 2009 19:25:56 -0600 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> Hi Andy,
>    Please review this change. 
> 
> It is in my client hosted by Mightydog: ~larrys/src/dev/nfx-tree
> 
> Thanks,
> 
> Larry
> 
> P.S. I will review you Makefile changes first thing in the AM.
> 
> Change 33652 by larrys@larrys on 2009/10/27 18:00:28 *pending*
> 
>         Occasionally make test would fail while building building
> rmc_client. The problem was actually the sm-utils Makefile. There was
> no dependency to remake the library depend file: libutils.d, when it
> was out of date. The sm-utils/Makefile was missing the target for
> libutils.d. The library depend files are included by the makefiles of
> applications that use libraries the local Makefile needs to have the
> default target depend on this file.
> 
>         Cleaned up out of date and incorrect code in both
> ssc-rmc/Makefile and sm-utils/Makefile.
> 
>         Minor fixes to Makefile.ssc
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/Makefile.ssc#18 edit
> ... //depot/dev/nfx-tree/code/sm-utils/Makefile#6 edit
> ... //depot/dev/nfx-tree/code/ssc-rmc/Makefile#6 edit


= Change 33652 by larrys@larrys on 2009/10/27 18:00:28 *pending*
= 
= 	Occasionally make test would fail while building building rmc_client.
                                                     ^^^^^^^^
= 	The problem was actually the sm-utils Makefile. There was no dependency
= 	to remake the library depend file: libutils.d, when it was out of date. 
= 	The sm-utils/Makefile was missing the target for libutils.d. The
= 	library depend files are included by the makefiles of applications that
= 	use libraries the local Makefile needs to have the default target
= 	depend on this file.
= 	
= 	Cleaned up out of date and incorrect code in both ssc-rmc/Makefile and
= 	sm-utils/Makefile.
= 	
= 	Minor fixes to Makefile.ssc
= 

nfx-tree/Makefile.ssc

     looks good

nfx-tree/code/sm-utils/Makefile

     looks good

nfx-tree/code/ssc-rmc/Makefile

     looks goody


