AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070426180817.7167925a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0221576F@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 26 Apr 2007 18:08:46 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Code review request
Message-ID: <20070426180846.1b278f27@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221576F@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0221576F@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I'm wondering why we are doing this, Larry.  We agreed
that if we went with your idea to execute the verify_install.sh from
the tarball, that we would not support upgrading from submittal to
submittal.  Therefore this bug is a WAD and there is no need for this
change.


On Thu, 26 Apr 2007 17:48:02 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> This change is to fix defect 18379 system compare failing to compare
> recent Delorean installation (anything after submittal 11) with older
> distributions (anything previous to Delorean sun 10.)
> 
> The changes are simple:
> 
> ==== //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/verify_install.sh#12
> - /home/larrys/perforce/trees/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/verify_i
> nstall.sh ====
> @@ -604,7 +604,7 @@
>         while read ftype sum_sym size pname ; do
>                 # if reading an older BOM file reset variables to
> match its format
>                 case $BUILD in
> -                       *[A-Z-]2.2*)
> +                       *[A-Z-][12][.]*)
>                                 if [ "$pname" = "" ] ; then
>                                         pname=$size
>                                         size=$sum_sym
> 
> ==== //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#15 -
> /home/larrys/perforce/trees/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgr
> ade.c ====
> @@ -2515,7 +2515,7 @@
>      dv = read_descriptor(descriptor_file);
>      if (dv != NULL) {
>          printf("done\n");
> -        rc = do_system("/mnt/usr/local/agile/bin/verify_install.sh -f
> %s %s",
> +        rc = do_system("/usr/local/agile/bin/verify_install.sh -f %s
> %s",
>                           patch_location, compare_secondary ? "-s" :
> "-p") ;
>          vector_free_all(dv);
>                 if (sys_upgrade) {
