AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<John.Keiffer@lsi.com>,<Jan.Seidel@lsi.com>,<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	85A1D09038E3C1438820EF7A7FAFDD300107B309F0@cosmail01.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 30 Oct 2009 16:07:03 -0700
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Keiffer, John" <John.Keiffer@lsi.com>
Cc: "Seidel, Jan" <Jan.Seidel@lsi.com>, "Scheer, Larry"
 <Larry.Scheer@lsi.com>
Subject: Re: PERFORCE change 33700 for review
Message-ID: <20091030160703.0a456d19@ripper.onstor.net>
In-Reply-To: <85A1D09038E3C1438820EF7A7FAFDD300107B309F0@cosmail01.lsi.com>
References: <WEBMAILvBlfuGHM6AQ40008fb29@mail.onstor.com>
	<20091030152310.2c3368f2@ripper.onstor.net>
	<D41A5B864986B546A595D85C4701A9C00400C2B5@cosmail03.lsi.com>
	<85A1D09038E3C1438820EF7A7FAFDD300107B309F0@cosmail01.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Yeah, yeah, I shoulda known ~:^)  OK, try to make it a tad more obvious
to my tired old eyes, I don't know, maybe on a separate line like the
review tag.  Pfft, whatever.  I'll just go soke my head now.  Sorry for
the noise.

On Fri, 30 Oct 2009 16:33:11 -0600 "Keiffer, John"
<John.Keiffer@lsi.com> wrote:

> Yeah Andy, what's wrong with that? You already said I could do it
> like that. ;-)
> 
> Thanks,
> John
> 408-376-3106
> 
> -----Original Message-----
> From: Seidel, Jan 
> Sent: Friday, October 30, 2009 3:31 PM
> To: Sharp, Andy
> Cc: Keiffer, John; Scheer, Larry
> Subject: RE: PERFORCE change 33700 for review
> 
> Hi Andy,
> 
> I see what you're saying, but please have a look at the checkin
> comment: It says "written by jkeiffer".
> 
> Regards,
> Jan
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Friday, October 30, 2009 3:23 PM
> To: Seidel, Jan
> Cc: Keiffer, John; Scheer, Larry
> Subject: Re: PERFORCE change 33700 for review
> 
> Jan,
> 
> If you are really reviewing these, then you are supposed to be
> reviewing the checkin comment as well, and I just sent a notice out a
> few days ago about not checkin in unattributed changes.  So this is on
> you as well to require the person to identify themself either in the
> comments or the client name or *something*.
> 
> On Fri, 30 Oct 2009 13:50:00 -0600 Generic Perforce Account
> <perforce@milmhbs0.lsil.com> wrote:
> 
> > Change 33700 by perforce@c16r34-rhel4 on 2009/10/30 12:45:23
> > 
> > 	   increased wait time for client_ssh connect from 10 to 60
> > - written by jkeiffer Reviewed by: jans
> > 
> > Affected files ...
> > 
> > ... //depot/dev/nfx-tree/test/t/all/features/pm/testcases/000_setup_config.t#5
> > edit
> > 
> > 
> > http://liszt.onstor.net:1818/@md=d&cd=//depot/$c=G35@/33700?ac=10
