AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ed.Kwan@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	2B044E14371DA244B71F8BF2514563F50410E54A@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 12 Nov 2009 19:53:44 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kwan, Ed" <Ed.Kwan@lsi.com>
Subject: Re: please review webui code change for TED 27735 WebUI: edit GNS
 root with multi-line comment gives error Unterminated " string
Message-ID: <20091112195344.5b6dd79d@ripper.onstor.net>
In-Reply-To: <2B044E14371DA244B71F8BF2514563F50410E54A@cosmail03.lsi.com>
References: <2B044E14371DA244B71F8BF2514563F50410E526@cosmail03.lsi.com>
	<20091112153103.2588b8fd@ripper.onstor.net>
	<2B044E14371DA244B71F8BF2514563F50410E530@cosmail03.lsi.com>
	<20091112154643.2e24aacf@ripper.onstor.net>
	<2B044E14371DA244B71F8BF2514563F50410E54A@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

looks good

On Thu, 12 Nov 2009 17:33:46 -0700 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:

> Please review one more time.
> Change 33801.
> Removed an extra "," to make Internet Explorer happy (Firefox doesn't
> care).
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Thursday, November 12, 2009 3:47 PM
> To: Kwan, Ed
> Subject: Re: please review webui code change for TED 27735 WebUI:
> edit GNS root with multi-line comment gives error Unterminated "
> string
> 
> Maybe that's it.
> 
> Perforce showed a diff on that line and a tiny little grey rectangle
> at the end; it must have been trying to say that there was a new
> newline.
> 
> On Thu, 12 Nov 2009 16:41:23 -0700 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:
> 
> > There's no trailing white space in my copy of add.js line 812.
> > I believe the original file doesn't have a newline at the end of the
> > file, and vi puts one there, if that's what you're referring to.
> > 
> > -----Original Message-----
> > From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> > Sent: Thursday, November 12, 2009 3:31 PM
> > To: Kwan, Ed
> > Subject: Re: please review webui code change for TED 27735 WebUI:
> > edit GNS root with multi-line comment gives error Unterminated "
> > string
> > 
> > On Thu, 12 Nov 2009 16:07:48 -0700 "Kwan, Ed" <Ed.Kwan@lsi.com>
> > wrote:
> > 
> > > Change 33799
> > 
> > 
> > = Change 33799 by edk@edk-dev on 2009/11/12 15:05:36 *pending*
> > = 
> > = 	For TED00027735 WebUI: edit GNS root with multi-line
> > comment gives = 	error Unterminated " string
> > = 	1.  Don't use a box for the "comments" in the GNS edit
> > page, = 	2.  Trim the leading white space when displaying the
> > comments. = 	Reviewed by
> > = 
> > 
> > nfx-tree/code/ssc-webui/js/gns/add.js
> > 
> >      line 812, did you add trailing white space?  naughty-naughty.
> > 
> > nfx-tree/code/ssc-webui/js/gns/view.js
> > 
> >      looks good
> > 
