AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070430165943.448af675@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>,<tim.gardner@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAILjdlkmKfzTDz600000593@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 30 Apr 2007 17:00:08 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>, Tim Gardner
 <tim.gardner@onstor.com>
Subject: Re: PERFORCE change 23778 for review
Message-ID: <20070430170008.1bf26a46@ripper.onstor.net>
In-Reply-To: <WEBMAILjdlkmKfzTDz600000593@mail.onstor.com>
References: <WEBMAILjdlkmKfzTDz600000593@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I rejected this change because upgrading between submittals in Delorean
we all agreed isn't supported, and also because it's very broken.  You
have _system compare_ running one script, and _system upgrade_ running
another, exactly the kind of thing you should not, and I believe, can
not, do.

a

On 30 Apr 2007 15:41:49 -0700 Larry Scheer <larry.scheer@onstor.com>
wrote:

> Change 23778 by larrys@larrys-r14-dmip on 2007/04/30 14:31:52
> 
> 	Fix for defect 18379 system compare aborting prematurely.
> 	Reviewed by: timg
> 
> Affected files ...
> 
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#16 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/verify_install.sh#13
> edit
> 
