AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1258417931.1793.36.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 16 Nov 2009 17:12:40 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review - 33818
Message-ID: <20091116171240.59e3adc1@ripper.onstor.net>
In-Reply-To: <1258417931.1793.36.camel@rendellf>
References: <1258410672.1793.32.camel@rendellf>
	<20091116155936.650bf07d@ripper.onstor.net>
	<1258417931.1793.36.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Extra-super-duper.

Thanks,

a

On Mon, 16 Nov 2009 17:32:11 -0700 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> Good enough?
> 
> Change 33818 by rendellf@rendellf-test on 2009/11/16 09:25:07
> *pending*
> 
>  Set state of compact flash LEDs based on the compact flash that
>  actually gets mounted during bootup for Cougar.  The block:sda or
>  block:sdb link is located within one of the /sys/devices/pci0000:00
>  subdirectories.  The directory path and link combination verifies
>  which CF is being accessed when mounting sda1 or sdb1.
>  Reviewed by: AndyS
> 
> 
> On Mon, 2009-11-16 at 16:59 -0700, Andrew Sharp wrote:
> > On Mon, 16 Nov 2009 15:31:12 -0700 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> > 
> > > Change 33818 by rendellf@rendellf-test on 2009/11/16 09:25:07
> > > *pending*
> > > 
> > >         Set state of compact flash LEDs based on the compact flash
> > > that actually gets mounted during bootup for Cougar.
> > > 
> > > Affected files ...
> > > 
> > > ... //depot/dev/nfx-tree/code/sm-chassis/chassisd-bc.c#18 edit
> > > ... //depot/dev/nfx-tree/code/sm-chassis/chassisd-cg.c#17 edit
> > > ... //depot/dev/nfx-tree/code/sm-chassis/chassisd.c#8 edit
> > > ... //depot/dev/nfx-tree/code/sm-chassis/cm.h#3 edit
> > > ... //depot/dev/nfx-tree/code/ssc-genlib/cm-util-cg.c#1 edit
> > 
> > 
> > 
> > = Change 33818 by rendellf@rendellf-test on 2009/11/16 09:25:07
> > *pending* = 
> > = 	Set state of compact flash LEDs based on the compact
> > flash that = 	actually gets mounted during bootup for Cougar.
> > 
> > 
> > Say something about how it determines which slot actually is
> > mounted, like "...actually gets mounted by checking the /sys
> > filesystem ..."
> > 
> > 
> > 
> > nfx-tree/code/sm-chassis/chassisd-bc.c
> > 
> >      looks good
> > 
> > nfx-tree/code/sm-chassis/chassisd-cg.c
> > 
> >      looks good
> > 
> > nfx-tree/code/sm-chassis/chassisd.c
> > 
> >      looks good
> > 
> > nfx-tree/code/sm-chassis/cm.h
> > 
> >      looks good
> > 
> > nfx-tree/code/ssc-genlib/cm-util-cg.c
> > 
> >      looks good
> > 
> 
