AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ed.Kwan@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	2B044E14371DA244B71F8BF2514563F50410E9C9@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 16 Nov 2009 18:14:50 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kwan, Ed" <Ed.Kwan@lsi.com>
Subject: Re: please review code change for TED 22151 Interface creation
 using Network address is successful
Message-ID: <20091116181450.72fc9579@ripper.onstor.net>
In-Reply-To: <2B044E14371DA244B71F8BF2514563F50410E9C9@cosmail03.lsi.com>
References: <2B044E14371DA244B71F8BF2514563F50410E9C9@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 16 Nov 2009 12:01:32 -0700 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:

> Change 33820


= Change 33820 by edk@edk-dev on 2009/11/16 11:00:39 *pending*
= 
= 	For TED 22151 Interface creation using Network address is successful
= 	Check the host portion of the address is not all 0's or 1's.

That check was already being done, yes?  The check added was that it
wasn't all zeroes or ones outside the mask.

= 	Reivewed by 
= 

nfx-tree/code/ssc-nfxsh/cmd_interface.c

     i can't believe this got escalated

     technically, can't a mask be all zeroes?  i don't think it
     hurts anything to not allow it, i'm just asking if you know
     off hand.
