AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ed.Kwan@lsi.com>,<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	2B044E14371DA244B71F8BF2514563F50410ECB7@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 17 Nov 2009 10:35:37 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kwan, Ed" <Ed.Kwan@lsi.com>
Cc: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: please review code change for TED 17769 "system copy all"
 copies NFS mounts
Message-ID: <20091117103537.7ab545de@ripper.onstor.net>
In-Reply-To: <2B044E14371DA244B71F8BF2514563F50410ECB7@cosmail03.lsi.com>
References: <2B044E14371DA244B71F8BF2514563F50410E6CD@cosmail03.lsi.com>
	<20091116182010.25d4946b@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755E9275A9B@cosmail02.lsi.com>
	<2B044E14371DA244B71F8BF2514563F50410ECB7@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Now THAT's a bug!

On Tue, 17 Nov 2009 11:19:32 -0700 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:

> Forgot to mention, in Cougar we don't copy /mnt:
> cmd_flash-linux.c
>      34 /* List of files to copy for "copy all" command */
>      35 char *all_files = "boot etc home root sbin bin lib usr onstor
> var version";
> 
> 
> -----Original Message-----
> From: Kwan, Ed 
> Sent: Tuesday, November 17, 2009 10:08 AM
> To: Scheer, Larry; Sharp, Andy
> Subject: RE: please review code change for TED 17769 "system copy
> all" copies NFS mounts
> 
> I'm mark this as WAD, then.
> 
> -----Original Message-----
> From: Scheer, Larry 
> Sent: Monday, November 16, 2009 6:59 PM
> To: Sharp, Andy; Kwan, Ed
> Subject: RE: please review code change for TED 17769 "system copy
> all" copies NFS mounts
> 
> I agree with Andy. The only people who would have NFS mounts would be
> internal developers and QA. I have seen filers with /n and /homes
> mounted.
> 
> Removing /mnt from the system copy all will break system upgrade in
> the following scenario:
> 
> system copy all -i (or system copy init) followed by a  system
> upgrade.
> 
> I thought this defect was marked as WAD when it was first filed a
> year or so ago. Who attempts to do a system copy all with NFS mounts
> anyway? 
> 
> Why is this defect being addressed when there many more higher
> priority defects that need to be fixed. Has someone ran out of worthy
> work to do?
> 
> 
> ________________________________________
> From: Andrew Sharp [andy.sharp@lsi.com]
> Sent: Monday, November 16, 2009 6:20 PM
> To: Kwan, Ed
> Cc: Scheer, Larry
> Subject: Re: please review code change for TED 17769 "system copy
> all" copies NFS mounts
> 
> On Fri, 13 Nov 2009 11:34:27 -0700 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:
> 
> > Change 33808
> 
> Change 33808 by edk@edk-dev on 2009/11/13 10:33:14 *pending*
> 
>         For TED 17769 "system copy all" copies NFS mounts
>         Remove "mnt" from the list of files/directories to copy.
>         Reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#18 edit
> 
> 
> I strongly wish to NAK this one.  NFS mounted filesystems is not a
> supported configuration, hence the bug is WAD.  And, who's to say I
> don't have something on /mnt locally that I think should be copied?
> Also, just removing /mnt doesn't do it, there could be many NFS
> mounted directories in many places, or one in some other place, etc.
> 
> CC'ing to Larry for the tie breaker since he's pretty familiar with
> this code area too.
