AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1258477225.1793.39.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 17 Nov 2009 10:50:43 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: please review - 33822
Message-ID: <20091117105043.7220c618@ripper.onstor.net>
In-Reply-To: <1258477225.1793.39.camel@rendellf>
References: <1258402826.1793.29.camel@rendellf>
	<20091116155417.09a8f07c@ripper.onstor.net>
	<1258417136.1793.34.camel@rendellf>
	<20091116180602.0cbb226a@ripper.onstor.net>
	<1258477225.1793.39.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Looks good to me.

On Tue, 17 Nov 2009 10:00:25 -0700 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> Don't know what more to say than the following:
> 
> 
> Change 33822 by rendellf@rendellf-test on 2009/11/16 12:04:06
> *pending*
> 
>  Fix kernel, kernel module, and user apps build errors in numerous
>  files. Finish renaming kernel build flags (CONFIG_TUXRX to
>  CONFIG_ONSTOR_TUXSTOR) that was started by Andy in tuxrx branch.
> 
> 
> On Mon, 2009-11-16 at 19:06 -0700, Andrew Sharp wrote:
> > On Mon, 16 Nov 2009 17:18:56 -0700 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> > 
> > > Ok, I've added it all.  I actually had all the changes except the
> > > rcon.c one but they weren't include in this chg list. 
> > 
> > Looks good.  Add just a tad more verbiage in the comments, something
> > about a config variable changed etc.
> > 
> > 
> > > On Mon, 2009-11-16 at 16:54 -0700, Andrew Sharp wrote:
> > > > On Mon, 16 Nov 2009 13:20:26 -0700 Rendell Fong
> > > > <Rendell.Fong@lsi.com> wrote:
> > > > 
> > > > > I think this is about everything needed to fix the build.
> > > > > 
> > > > > 
> > > > > Change 33822 by rendellf@rendellf-test on 2009/11/16 12:04:06
> > > > > *pending*
> > > > > 
> > > > >         Fix kernel and kernel module build errors in tuxrx
> > > > > branch.
> > > > > 
> > > > > Affected files ...
> > > > > 
> > > > > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/
> > > > > onstor/tuxstor/prom.c#2 edit
> > > > > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/
> > > > > onstor/tuxstor/setup.c#2 edit
> > > > > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/arch/mips/
> > > > > onstor/tuxstor/time.c#1 edit
> > > > > ... //depot/tuxrx/nfx-tree/code/Makefile.acpu#2 edit
> > > > > ... //depot/tuxrx/nfx-tree/code/Makefile#2 edit
> > > > 
> > > > 
> > > > The following files also need fixing:
> > > > 
> > > > nfx-tree/
> > > > 	Includes/nfx-defs.h
> > > > 	Includes/nfx-types.h
> > > > 	code/Makefile
> > > > 	code/sm-dp-proxy/dp-proxy.c:513
> > > > 	code/sm-dp-proxy/dp-proxy.c:556
> > > > 	code/sm-file/file-lib.c:584
> > > > 	code/sm-rmc/rmc_eee.h:23
> > > > 	code/sm-sbm-rev2/sbm-api.h:421
> > > > 	code/sm-sbm-rev2/sbm-verify.c:319
> > > > 	code/sm-stats/kpi-api.c:948
> > > > 	code/sm-stats/kpi.h:32
> > > > 	code/sm-thread/thread-api.h:48
> > > > 	code/sm-timer/timer-api.h:1117
> > > > 	code/sm-ui/cmdtable.c:399
> > > > 	code/sm-ui/uihdr.h:304
> > > > 	code/sm-ui/commands.c:2679
> > > > 	code/sm-utils/txrx-utils-api.c:5682,5736,5759,5861
> > > 
> 
