AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Rendell.Fong@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	1258584795.1793.97.camel@rendellf
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 18 Nov 2009 15:01:53 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Rendell Fong <Rendell.Fong@lsi.com>
Subject: Re: kernel module loading questions
Message-ID: <20091118150153.1bdf0bc4@ripper.onstor.net>
In-Reply-To: <1258584795.1793.97.camel@rendellf>
References: <1258575637.1793.83.camel@rendellf>
	<20091118141013.59c0d399@ripper.onstor.net>
	<1258584795.1793.97.camel@rendellf>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 18 Nov 2009 15:53:15 -0700 Rendell Fong <Rendell.Fong@lsi.com>
wrote:

> Well, onstor-nas.ko must be MIA then because its nowhere to be found.

If it builds, it will be in the code directory.  If it doesn't build,
it's because an error happened, and you should see that when you try to
build.

The code isn't the thing making the module "too big", it's these static
arrays that are humongous.  Make them pointers or something, and
vmalloc the memory for them during module_init time.

There are many standard kernel modules in the kernel these days that
are 10 times the amount of code we have in this one.  Just a data point
for everyone to keep in mind.  I'm just sayin.

> On Wed, 2009-11-18 at 15:10 -0700, Andrew Sharp wrote:
> > On Wed, 18 Nov 2009 13:20:37 -0700 Rendell Fong
> > <Rendell.Fong@lsi.com> wrote:
> > 
> > > 
> > > I can't seem to find the onstor-nas.ko file anywhere.
> > > 
> > > Is it being built when do a "make -f Makefile.tuxstor" from the
> > > nfx-tree directory?
> > > 
> > > As a test I stripped out most of the code that is supposed to go
> > > into the monster module.  So theoretically, I ought to be able to
> > > load it. 
> > > 
> > > Am I supposed to put the onstor-nas.ko file
> > > in /lib/modules/2.6.22- cg/net/onstor and then modprobe/insmod it?
> > 
> > Hm.  Yes.  No.  Yes.
> 
