AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070502114209.464fb296@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E038C9672@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 2 May 2007 11:42:47 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070502114247.1b48d29f@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E038C9672@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E038C952E@onstor-exch02.onstor.net>
	<20070502112619.675a8e5e@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E038C9672@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Eeek!  And you definitely shouldn't ever do anything like this:

 //depot/FB-DELOREAN/nfx-tree/... //maximk-5/dd/...

which breaks the version of my script that I wrote just for doing your
reviews where I cd to the directory you have mapped the branch to!

~:^)

On Wed, 2 May 2007 11:27:12 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Why is this a problem?
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, May 02, 2007 11:26 AM
> To: Maxim Kozlovsky
> Subject: Re: Please review
> 
> I take it you don't have the FB-DELOREAN branch mapped
> to //maximk-5/FB-DELOREAN ...
> 
> 
> On Wed, 2 May 2007 09:28:03 -0700 "Maxim Kozlovsky"
> <maxim.kozlovsky@onstor.com> wrote:
> 
> > P4CLIENT=maximk-5
> > 
> > Change 23808 by maximk@maximk-5 on 2007/05/02 08:15:16 *pending*
> > 
> >         Fix the exception handler not using correct instruction to
> > store the pointers on FC, which is 64 bit register size but 32 bit
> > pointers.
> >            This was causing infinite exception loop with unaligned
> > double word
> >            store.
> > 
> > Affected files ...
> > 
> > ... //depot/FB-DELOREAN/nfx-tree/code/sm-except/exc-llhandler.S#1
> > edit ... //depot/FB-DELOREAN/nfx-tree/code/sm-except/except.h#1 edit
> > ... //depot/FB-DELOREAN/nfx-tree/code/sm-except/nmi.S#1 edit
