AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Ed.Kwan@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	2B044E14371DA244B71F8BF2514563F50427F917@cosmail03.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 14 Dec 2009 10:38:43 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Kwan, Ed" <Ed.Kwan@lsi.com>
Subject: Re: please review code change for TED 27740 Autosupport mail won't
 send just after reboot [SGI Japan Case 13371]
Message-ID: <20091214103843.140cc1a5@ripper.onstor.net>
In-Reply-To: <2B044E14371DA244B71F8BF2514563F50427F917@cosmail03.lsi.com>
References: <2B044E14371DA244B71F8BF2514563F50427F8E1@cosmail03.lsi.com>
	<20091211174940.6d10aaa6@ripper.onstor.net>
	<2B044E14371DA244B71F8BF2514563F50427F917@cosmail03.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

looks good.

On Fri, 11 Dec 2009 23:44:23 -0700 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:

> 1.  Fixed indentation.
> 2.  Yes, if the IP is ONStor private, we'll never get to
> nfxdns_gethostbyaddr(), even the way I code it, as sm_ipToHostent()
> won't return NULL in this case.  But your suggestion makes the
> code/concept more readable.
> 
> Please review again.
> 
> -----Original Message-----
> From: Andrew Sharp [mailto:andy.sharp@lsi.com] 
> Sent: Friday, December 11, 2009 5:50 PM
> To: Kwan, Ed
> Subject: Re: please review code change for TED 27740 Autosupport mail
> won't send just after reboot [SGI Japan Case 13371]
> 
> On Fri, 11 Dec 2009 16:20:03 -0700 "Kwan, Ed" <Ed.Kwan@lsi.com> wrote:
> 
> > Change 34027
> 
> 
> = Change 34027 by edk@edk-dev on 2009/12/11 15:19:13 *pending*
> = 
> = 	For TED 27740 Autosupport mail won't send just after reboot
> [SGI Japan = 	Case 13371]
> = 	Always return the management virtual server netbios name
> for IP = 	addresses 192.167.n.n intead of going through DNS.
> = 	Reviewed by
> = 
> 
> nfx-tree/code/sendmail/sendmail/conf.c
> 
>      line 4538, this is indented wrong, just use tabs w/tabstop set
>      to 4 spaces (and shift-width set to 4 for vi)
> 
>      line 4538-4544 this should be an 'else block' from the if-block
>      started on line 4526.  if it's our private IP, we should never
>      do an gethostbyaddr, right?
> 
