AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<bill.fisher@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 16 Dec 2009 18:36:37 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: Bill Fisher <bill.fisher@lsi.com>
Subject: header files
Message-ID: <20091216183637.7bc83e08@ripper.onstor.net>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hokay,

Here is the unedited text of my review of 33930 nee 33974, you can see
where I'm going with all the files that I say "please integrate the
nfx-tree version".  I was only halfway through your changelist, but you
should be able to figure out the rest.

You will have to change your code in places to be consistent with these
header files, but it should be very minimal as I expect most of the
differences don't actually affect your code.  According to my memory,
most of the differences were things like your version had the wrong
data type for a variable or a function declaration.


= Change 33930 by bfisher@fisher-tuxstor on 2009/12/01 18:28:55 *pending*
= 
= 	Initial checkin of headers and source for tpl, neteee2 and neteee-ui(rcon) for EEE(os) kernel support.
= 

linux/kernel/linux-mips-2.6/drivers/mgmt-bus/Kconfig

     looks good

linux/kernel/linux-mips-2.6/include/linux/onstor/bqueue.h

     >>add linux/kernel/linux-mips-2.6/include/linux/onstor/bqueue.h

     Can you not do an integrate from the current bqueue.h instead?
     This makes it very difficult to track the changes to this file
     through what is essentially a move.  It also makes it difficult
     to see what changed.

linux/kernel/linux-mips-2.6/include/linux/onstor/cache.h

     >>add linux/kernel/linux-mips-2.6/include/linux/onstor/cache.h

     We cannot use this file.  There should be no users of the macros
     in this file anyway, and it can't be used, so whatever reason
     you are adding it will have to be solved some other way.  If we
     absolutely need to control cache flushing and other such things,
     then it has to be done through the standard kernel interfaces.

     If we just need the first three #defines, those are available in
     standard kernel headers and must be used, because they have to
     be pertinent to whatever hardware we are building for.

linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-defs.h

     >>add linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-defs.h

     Again, if you are moving this, I would really like to see it as
     an integrate.


     line 14, this has to be set in a makefile, not a standard header
     file used by everything.

     line 15, I thought you were going to remove NFX_SMP.  It shouldn't
     be defined for TXRX code anyway.

     line 16, again, has to be set in a makefile, but it should not
     be used anyway, as this code will be on sibytes and x86.

     line 24, definitely not.  if NULL isn't defined the standard way,
     then we should hit an error so the user can fix that.

     line 47, i would recommend deleting this too, since it's buggy.
     the standard kernel macro for this should be enforced.  or just
     change this to refer to that macro.

     line 250, now that we're under Linux, do we not want all spinlocks
     to be spinlocks?



linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-error.h

     >>add linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-error.h

     Please do this as an integrate/delete rather than an add/delete.
     Enlist Larry's help if needed.

linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-types.h

     >>add linux/kernel/linux-mips-2.6/include/linux/onstor/nfx-types.h

     Again, should be an integrate

     line 10, surrounding ifndef is quite redundant, not sure why you
     would add that when it's already in every header file.

     line 16 this looks quite bogus and potentially disasterous.
     perhaps you meant to remove it?

     line 54, just remove this block, it's dead

     please eradicate trailing whitespace (there isn't any in nfx-tree
     version of this file)

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-cifs/ntstatus.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-cifs/ntstatus.h

     this is identical to the one in nfx-tree, please do an integrate,
     not an add/delete

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-api.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-api.h

     please use <> not "", and definitely no "../"

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-app.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-app.h

     please do an integrate from nfx-tree

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-desc.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-desc.h

     you should do an integrate from the nfx-tree version of this,
     as you've dropped numerous changes from that file which need to
     be there.  either that, or figure out which ones you've dropped
     and bring them over.

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-drv.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-drv.h

     ok

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-error.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-error.h

     please integrate from the nfx-tree file, it is unchanged

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-fwd.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-fwd.h

     please do an integrate the nfx-tree file to here

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-ipc.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-ipc.h

     please do an integrate from nfx-tree/code/neteee2/eee-ipc.h

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-mem.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-mem.h

     please do an integrate

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-platform.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-platform.h

     axe this file altogether, it should no longer be used

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-poll.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-poll.h

     please integrate the nfx-tree version over to here.  the changes
     there from this version are required for the txrx kernel module
     to build.

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-queue.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee-queue.h

     unchanged: integrate from nfx-tree

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee.h

     >>add linux/kernel/linux-mips-2.6/include/linux/onstor/sm-eee/eee.h

     line 45, not sure why you messed with the indenting...

     i wouldn't mind if you could integrate from nfx-tree, then add
     your changes.

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/acpu-conn-struct.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/acpu-conn-struct.h

     line 12 enum acpu_conn_flags, not sure why you felt the need to
     mess with the comments.  before they complied with the 80 column
     rule, now they don't.

     line 32-$ please make your comments fit inside 80 columns

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt-api.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt-api.h

     unchanged: please integrate from nfx-tree

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt-queue-api.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt-queue-api.h

     line 26; 87; 151; 212, 243, 261, 281, 290, 311, 312, 336, 343, 347,
     357, 361, 363, 387, 510, 538, 685, 722-756, 792, 797, 816-821   tws

     line 216, 295, 308, 410    80 columns please



linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt-queue-struct.h

     >>add
     linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt-queue-struct.h

     i think you should just integrate the nfx-tree version over.
     the includes in that version are probably needed for the kernel
     module to build.

     line 65 inexplicable tws

     line 107 ifdef LATER -- i'm pretty sure the module needs these
     definitions to build -- ?

linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt.h

     >>add linux/kernel/linux-mips-2.6/include/linux/onstor/sm-pkt/pkt.h

     line 85, changing this comment breaks the 80 column rule...?

     line 90, 128, 129, 130, 134, 144-5, 149, 157, 160,  inexplicable
     tws

     183 must be int, not boolean





