AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	DEC609CD0E54B2448DAF023C89AE9755E9275AF6@cosmail02.lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 17 Dec 2009 09:34:10 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: Please review change list 34049 Makefile changes for tuxstor
 build
Message-ID: <20091217093410.0ab35c35@ripper.onstor.net>
In-Reply-To: <DEC609CD0E54B2448DAF023C89AE9755E9275AF6@cosmail02.lsi.com>
References: <DEC609CD0E54B2448DAF023C89AE9755E9275AF4@cosmail02.lsi.com>
	<20091216141749.71c28549@ripper.onstor.net>
	<DEC609CD0E54B2448DAF023C89AE9755E9275AF6@cosmail02.lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 17 Dec 2009 00:18:45 -0700 "Scheer, Larry"
<Larry.Scheer@lsi.com> wrote:

> I decided to go with vmlinux.$(PROD) for the kernel names and make a
> hard link to vmlinux.bin in the boot directory for the SSC kernel so
> we don't have to wait for prom changes before we can use this stuff.
> 
> It was a bit more work than I planned on doing at this time, but I
> also removed references to bobcat and BSD stuff in nfx-tree/Makefile. 
> 
> I need to retest everything after these changes. (Doing that now.)
> 
> Tomorrow (Thursday) You may want to take another look at the latest
> changes.


You're THE man.  I'll bet it's super clean even though a bit more
effort.


> Later,
> 
> Larry
> ________________________________________
> From: Andrew Sharp [andy.sharp@lsi.com]
> Sent: Wednesday, December 16, 2009 2:17 PM
> To: Scheer, Larry
> Subject: Re: Please review change list 34049 Makefile changes for
> tuxstor build
> 
> On Tue, 15 Dec 2009 19:50:41 -0700 "Scheer, Larry"
> <Larry.Scheer@lsi.com> wrote:
> 
> > These are in my ~/src workspace on MD.
> >
> > Thanks,
> >
> > Larry
> >
> > Change 34049 by larrys@larrys on 2009/12/15 13:34:48 *pending*
> >
> >         Updates to the tuxstor make target in nfx-tree/Makefile:
> >         - build both linux kernels (SSC and TXRX)
> >         - build and install kernel modules into rootfs,
> >         - build the onstor-nas kernel module
> >         - build the SSC libraries, daemons, commands, and root file
> > system.
> >
> >         Other changes to nfx-tree/Makefiles:
> >         - Add new macro FSDIR to be used whenever a full path (verus
> > relative) to the release directory is needed.
> >         - Removed obsolete targets and rules.
> >         - General clean up and updates to make targets and rules
> > more useful. For instance a make ssc-clean PROD=tx will remove the
> > SSC derived objects for the tuxstor product and not the cheetah as
> > it did previously.
> >
> >         Change module directory in tuxstor-config to be:
> > lib/modules/2.6.22-tx
> >
> >         Add support for tuxstor platform to rootfs/Makefile
> >
> >         Updates to linux/kernel/Makefile:
> >         - set linux kernel binary to be txrx_cg.bin for tuxstor
> > platform
> >
> >         Reviewed by:
> >
> > Affected files ...
> >
> > ... //depot/tuxrx/descr-tx#1 branch
> > ... //depot/tuxrx/linux/kernel/Makefile#3 edit
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-config#5 edit
> > ... //depot/tuxrx/linux/kernel/linux-mips-2.6/tuxstor-debug-config#4
> > edit ... //depot/tuxrx/linux/rootfs/Makefile#1 edit
> > ... //depot/tuxrx/nfx-tree/Makefile#4 edit
> 
> 
> 
> 
> = Change 34049 by larrys@larrys on 2009/12/15 13:34:48 *pending*
> =
> =       Updates to the tuxstor make target in nfx-tree/Makefile:
> =       - build both linux kernels (SSC and TXRX)
> =       - build and install kernel modules into rootfs,
> =       - build the onstor-nas kernel module
> =       - build the SSC libraries, daemons, commands, and root file
> system. =
> =       Other changes to nfx-tree/Makefiles:
> =       - Add new macro FSDIR to be used whenever a full path (verus
> relative) =         to the release directory is needed.
> =       - Removed obsolete targets and rules.
> =       - General clean up and updates to make targets and rules more
> useful. =           For instance a make ssc-clean PROD=tx will remove
> the SSC derived =           objects for the tuxstor product and not
> the cheetah as it did =           previously.
> =
> =       Change module directory in tuxstor-config to be:
> lib/modules/2.6.22-tx =
> =       Add support for tuxstor platform to rootfs/Makefile
> =
> =       Updates to linux/kernel/Makefile:
> =       - set linux kernel binary to be txrx_cg.bin for tuxstor
> platform =
> =       Reviewed by:
> 
> 
> Fix the filename in above comment ~:^)  See my comments lower down
> about that.
> 
> 
> 
> descr-tx
> 
>      >>branch descr-tx
> 
>      okay
> 
> linux/kernel/Makefile
> 
>      lines 41-42 i'd like that filename to be a variable so that if
>      it changes, both KERN_FILE_* variables get the new value.
> 
>      line 45 boot image name should be vmlinux.tuxstor for tuxstor.
> 
> 
> linux/kernel/linux-mips-2.6/tuxstor-config
> 
>      looks good
> 
> linux/kernel/linux-mips-2.6/tuxstor-debug-config
> 
>      looks good
> 
> linux/rootfs/Makefile
> 
>      line 43 fix filename to vmlinux.tuxstor
> 
>      we could make the bootimage vmlinux.$(PROD) if you wanted.
>      that might be a good change.  then you would be forced to do
>      a prom upgrade before running tuxstor.  or, we could have a
>      permanent hard link of vmlinux.bin and vmlinux.cg.
> 
>      line 95, just make it inittab-$(PROD) since we will have a
> separate one for the 1480.  you can just copy inittab-cg to inittab-tx
>      and check it in (add it to this changelist).  later we can mod
>      it as necessary.
> 
>      line 170 fix name
> 
> 
> nfx-tree/Makefile
> 
>      line 124 you can get rid of 'fc' as well ~:^)
> 
>      line 127 ditto
> 
>      line 149 the tuxrx branch will never support bobcat.  i'm not
> sure what the right thing to do relative to that fact, so i guess no
>      real comment here.  just thought i would bring it up so it starts
>      to gel in people's minds.  ignore previous two comments.
> 
>      line 162 not sure what you meant to put here, but i know
> vmlinux.32 shouldn't be here, and i have no idea what vmlinux-ssc.32
> is all about.  or the other -ssc.* files.
> 
>      line 166 fix filename here
> 
>      line 762-775 uh, why are we calling /usr/bin/time? that doesn't
>      belong in a standard makefile.  if somebody wants to time
>      the build, they can say "time make all-parallel".
> 
