AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070502163333.070a54e8@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E038C952E@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 2 May 2007 16:33:48 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070502163348.0a5bef63@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E038C952E@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E038C952E@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 2 May 2007 09:28:03 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> P4CLIENT=maximk-5
> 
> Change 23808 by maximk@maximk-5 on 2007/05/02 08:15:16 *pending*
> 
>         Fix the exception handler not using correct instruction to
> store the pointers on FC, which is 64 bit register size but 32 bit
> pointers.
>            This was causing infinite exception loop with unaligned
> double word
>            store.
> 
> Affected files ...
> 
> ... //depot/FB-DELOREAN/nfx-tree/code/sm-except/exc-llhandler.S#1 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/sm-except/except.h#1 edit


+/* Macro for storing a pointer.
+ */
+#ifdef __long64
+#define PTR_S sd
+#else
+#define PTR_S sw
+#endif
+

This looks more like a macro for storing a long when a long is 64
bits.  That might be what you want, I can't tell.  But it seems to me
that if the macro is for pointers, it should be based on the size of
pointers.  I'm just sayin'.

> ... //depot/FB-DELOREAN/nfx-tree/code/sm-except/nmi.S#1 edit
