AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@lsi.com
RQ:
SSV:mhbs.lsil.com
NSV:
SSH:
R:<Bill.Fisher@lsi.com>,<Brian.Stark@lsi.com>,<Rendell.Fong@lsi.com>,<Larry.Scheer@lsi.com>
MAID:2
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/LSI/INBOX	0	4B4FDE26.50003@lsi.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 15 Jan 2010 15:50:46 -0800
From: Andrew Sharp <andy.sharp@lsi.com>
To: "Fisher, Bill" <Bill.Fisher@lsi.com>
Cc: "Stark, Brian" <Brian.Stark@lsi.com>, "Fong, Rendell"
 <Rendell.Fong@lsi.com>, "Scheer, Larry" <Larry.Scheer@lsi.com>
Subject: Re: tuxrx Branch Change List 34077 review requested
Message-ID: <20100115155046.35fd87f2@ripper.onstor.net>
In-Reply-To: <4B4FDE26.50003@lsi.com>
References: <4B4FDE26.50003@lsi.com>
Organization: LSI
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Just to be clear, it doesn't go in without at least these two reviews:
one from me and one from Rendell.  Rendell because of the vsvr
integration questions and possible userspace building questions, and me
to try and stem the chaos that has plagued things recently.  Apart from
deletes, I didn't see any makefile changes, so probably not much for
Larry to look at.

Bill, can you attempt to discuss with Max whatever his concern is?  I
say 'attempt' for obvious reasons.  You mentioned the vsvr pointer to
me many times ... I'd be shocked if you hadn't mentioned it to Max at
least once.  Just in case anybody cares, my stance is, as always: if
that's what needs doing, then that's what needs doing.  Anyway, I
thought in the comments you said it was moved, not deleted.

Cheers,

a


On Thu, 14 Jan 2010 20:16:54 -0700 William Fisher <bill.fisher@lsi.com>
wrote:

> Folks:
> 
> Attached is the p4 describe of the change list to merge the
> common headers between the nfx-tree/Includes and the kernel
> one's residing in include/linux/onstor/...
> 
> In addition, this change list also includes the code changes
> to the nfx-tree to get the txrx module to compile
> using the Makefile.acpu and the new common headers in addition
> to the one's residing in code/sm-*/*.h
> 
> The virtual server hooks and specific areas which
> need to be converted to Rendell's new implementation
> have been ifdef'ed VIRTUAL_SERVER_IMPLEMENTED
> in the code/sm-vsvr, code/sm-stats and in the
> NFS, CIFS and NetBIOS directories which cover
> the acpu_conn structure changing and moving to
> now hang off the kernel socket structure. The
> tpl code manages this user_data area
> and also contains the old bind and connection
> structure used in the tpl API's.
> 
> If either Andy, Rendell or Max could review these
> changes, I can proceed to add them to the branch.
> 
> Thanks,
> 
> -- Bill
